diff --git a/Changelog.md b/Changelog.md index 2afd96c5a07c01195c61f8474436e892d7be141c..4515a2bb2c666603be5c3cbfc24a1820a4aace1b 100644 --- a/Changelog.md +++ b/Changelog.md @@ -10,7 +10,7 @@ * Extract CommentService from CommentsController [#6307](https://github.com/diaspora/diaspora/pull/6307) * Extract user/profile discovery into the diaspora\_federation-rails gem [#6310](https://github.com/diaspora/diaspora/pull/6310) * Refactor PostPresenter [#6315](https://github.com/diaspora/diaspora/pull/6315) -* Convert BackToTop to a backbone view [#6279](https://github.com/diaspora/diaspora/pull/6279) +* Convert BackToTop to a backbone view [#6279](https://github.com/diaspora/diaspora/pull/6279) and [#6360](https://github.com/diaspora/diaspora/pull/6360) ## Bug fixes * Fix indentation and a link title on the default home page [#6212](https://github.com/diaspora/diaspora/pull/6212) diff --git a/app/assets/javascripts/app/app.js b/app/assets/javascripts/app/app.js index 841a0cbd2c4fb32c36abddafdba0c52c9188be4b..4ff89cf3efbc7d89a93beaa8f98de1b11489ccde 100644 --- a/app/assets/javascripts/app/app.js +++ b/app/assets/javascripts/app/app.js @@ -115,7 +115,7 @@ var app = { new app.views.AspectMembership({el: this}); }); app.sidebar = new app.views.Sidebar(); - app.backToTop = new app.views.BackToTop(); + app.backToTop = new app.views.BackToTop({el: $(document)}); }, /* mixpanel wrapper function */ diff --git a/spec/javascripts/app/views/back_to_top_view_spec.js b/spec/javascripts/app/views/back_to_top_view_spec.js index 8cfed56967506d2a44396f12fb574d5e84162332..726c1ae1b0a63621436c7758bce35b8da1005bbf 100644 --- a/spec/javascripts/app/views/back_to_top_view_spec.js +++ b/spec/javascripts/app/views/back_to_top_view_spec.js @@ -1,7 +1,16 @@ describe("app.views.BackToTop", function() { beforeEach(function() { spec.loadFixture("aspects_index"); - this.view = new app.views.BackToTop(); + this.view = new app.views.BackToTop({el: $(document)}); + }); + + describe("events hash", function() { + it("calls backToTop when clicking the back-to-top button", function() { + spyOn(this.view, "backToTop"); + this.view.delegateEvents(); + this.view.$("#back-to-top").click(); + expect(this.view.backToTop).toHaveBeenCalled(); + }); }); describe("backToTop", function() {