From 1d0446fcabafb589ca470710a8712a9b8759dfcd Mon Sep 17 00:00:00 2001
From: khall <kevinmichaelhall@gmail.com>
Date: Mon, 25 Aug 2014 15:50:53 -0700
Subject: [PATCH] Adding tabindex='0' attributes to non-blueprint view elements
since blueprint is so last week
---
app/assets/javascripts/app/views/aspect_membership_view.js | 3 ++-
.../aspect_memberships/_aspect_membership_dropdown.html.haml | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/app/assets/javascripts/app/views/aspect_membership_view.js b/app/assets/javascripts/app/views/aspect_membership_view.js
index f753c3134a..b299fcb005 100644
--- a/app/assets/javascripts/app/views/aspect_membership_view.js
+++ b/app/assets/javascripts/app/views/aspect_membership_view.js
@@ -10,7 +10,8 @@
app.views.AspectMembership = app.views.AspectsDropdown.extend({
events: {
- "click ul.aspect_membership.dropdown-menu > li.aspect_selector": "_clickHandler"
+ "click ul.aspect_membership.dropdown-menu > li.aspect_selector": "_clickHandler",
+ "keypress ul.aspect_membership.dropdown-menu > li.aspect_selector": "_clickHandler"
},
initialize: function() {
diff --git a/app/views/aspect_memberships/_aspect_membership_dropdown.html.haml b/app/views/aspect_memberships/_aspect_membership_dropdown.html.haml
index 49ec355ab4..7d1cab891c 100644
--- a/app/views/aspect_memberships/_aspect_membership_dropdown.html.haml
+++ b/app/views/aspect_memberships/_aspect_membership_dropdown.html.haml
@@ -1,5 +1,5 @@
.btn-group.aspect_dropdown.aspect_membership_dropdown
- %button.btn.btn-small.dropdown-toggle{:class => selected_aspects.size>0 ? "green" : "btn-default", "data-toggle" => "dropdown"}
+ %button.btn.btn-small.dropdown-toggle{:class => selected_aspects.size>0 ? "green" : "btn-default", "data-toggle" => "dropdown", :tabindex => '0'}
%span.text
- if selected_aspects.size == all_aspects.size
= t('all_aspects')
@@ -11,7 +11,7 @@
%ul.dropdown-menu{:class => ["pull-#{hang}", defined?(dropdown_class) && dropdown_class], :unSelectable => 'on', 'data-person_id' => (person.id if defined?(person) && person), 'data-service_uid' => (service_uid if defined?(service_uid)), 'data-person-short-name' => (person.first_name if defined?(person) && person)}
- for aspect in all_aspects
- %li.aspect_selector{ :class => ('selected' if aspect_membership_ids[aspect.id].present?), 'data-aspect_id' => aspect.id, 'data-membership_id' => aspect_membership_ids[aspect.id] }
+ %li.aspect_selector{ :class => ('selected' if aspect_membership_ids[aspect.id].present?), 'data-aspect_id' => aspect.id, 'data-membership_id' => aspect_membership_ids[aspect.id], :tabindex => '0' }
%a
%span.status_indicator
%i.icon-ok
--
GitLab