From 4b7c9315c82d13dfef25ddc4f122da772ec3a88d Mon Sep 17 00:00:00 2001 From: MrZYX <pr0fkill@gmail.com> Date: Sat, 2 Apr 2011 17:44:48 +0200 Subject: [PATCH] log error when receiving a post instead of letting the job fail with weired error later in the chain --- app/models/post.rb | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/app/models/post.rb b/app/models/post.rb index 0040843ee4..359e04aff4 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -91,11 +91,14 @@ class Post < ActiveRecord::Base return local_post end elsif !local_post - self.save - user.contact_for(person).receive_post(self) - user.notify_if_mentioned(self) - Rails.logger.info("event=receive payload_type=#{self.class} update=false status=complete sender=#{self.diaspora_handle}") - return self + if self.save + user.contact_for(person).receive_post(self) + user.notify_if_mentioned(self) + Rails.logger.info("event=receive payload_type=#{self.class} update=false status=complete sender=#{self.diaspora_handle}") + return self + else + Rails.logger.info("event=receive payload_type=#{self.class} update=false status=abort sender=#{self.diaspora_handle} reason=#{self.errors.full_messages}") + end else Rails.logger.info("event=receive payload_type=#{self.class} update=true status=abort sender=#{self.diaspora_handle} reason='update not from post owner' existing_post=#{self.id}") end -- GitLab