From 4f5b1dd845273d2276cde530e8a7874501faa15a Mon Sep 17 00:00:00 2001 From: Benjamin Neff <benjamin@coding4coffee.ch> Date: Sun, 6 Aug 2017 05:59:38 +0200 Subject: [PATCH] Fix creating share visibilities Validation fails because there is no user set. --- app/models/share_visibility.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/share_visibility.rb b/app/models/share_visibility.rb index 25384bc377..18c920a539 100644 --- a/app/models/share_visibility.rb +++ b/app/models/share_visibility.rb @@ -22,7 +22,7 @@ class ShareVisibility < ApplicationRecord # @param share [Shareable] # @return [void] def self.batch_import(user_ids, share) - return false unless ShareVisibility.new(shareable_id: share.id, shareable_type: share.class.base_class.to_s).valid? + return false if share.public? user_ids -= ShareVisibility.for_shareable(share).where(user_id: user_ids).pluck(:user_id) return false if user_ids.empty? -- GitLab