diff --git a/Changelog.md b/Changelog.md index dddc00074f49cf82483209c488ab132373e8f6de..e8d44746a5f1e9f02245c0f61b3948c301ff42d9 100644 --- a/Changelog.md +++ b/Changelog.md @@ -12,6 +12,7 @@ * Refactor left bar side menu, improve tag autosuggestion design [#4271](https://github.com/diaspora/diaspora/issues/4271), [#4316](https://github.com/diaspora/diaspora/pull/4316) * Extract and factorize the header css in a new file, fix ugly header in registration [#4389](https://github.com/diaspora/diaspora/pull/4389) * Move contact list on profile to profile information, show user his own contacts on profile [#4360](https://github.com/diaspora/diaspora/pull/4360) +* Refactor metas, HTML is now valid [#4356](https://github.com/diaspora/diaspora/pull/4356) ## Bug fixes * Check twitter write access before adding/authorizing it for a user. [#4124](https://github.com/diaspora/diaspora/issues/4124) diff --git a/app/helpers/open_graph_helper.rb b/app/helpers/open_graph_helper.rb index ad200af3d2c690d65ada7b2c25e16bc26fb6ec5b..4ee10a7a01dce4668d6f2f05b239f1026399e1b3 100644 --- a/app/helpers/open_graph_helper.rb +++ b/app/helpers/open_graph_helper.rb @@ -17,10 +17,6 @@ module OpenGraphHelper tags.join(' ') end - def og_site_name - meta_tag_with_property('og:site_name', 'Diaspora*') - end - def og_description(post) meta_tag_with_property('og:description', post_page_title(post, :length => 1000)) end diff --git a/app/views/layouts/application.html.haml b/app/views/layouts/application.html.haml index fb788d0a169921e4e4e0851a34dad56b43aef9f6..94f8cd314dd2572c0f269d5c8484bcda673e8dc5 100644 --- a/app/views/layouts/application.html.haml +++ b/app/views/layouts/application.html.haml @@ -5,20 +5,18 @@ !!! %html{:lang => I18n.locale.to_s, :dir => (rtl?) ? 'rtl' : 'ltr'} %head - %meta{:charset => 'utf-8'} - %meta{"http-equiv"=>"Content-Type", :content=>"text/html; charset=utf-8"} - - %meta{:name => "description", :content => "Diaspora*"} - %meta{:name => "author", :content => "Diaspora, Inc."} - = og_site_name + %title + = page_title yield(:page_title) + + %meta{:charset => 'utf-8'}/ + %meta{"http-equiv"=>"Content-Type", :content=>"text/html; charset=utf-8"}/ + %meta{:name => "description", :content => "Diaspora*"}/ + %meta{:name => "author", :content => "Diaspora, Inc."}/ + %meta{:property => "og:site_name", :content => "#{AppConfig.settings.pod_name}"}/ %link{:rel => 'shortcut icon', :href => "#{image_path('favicon.png')}" } %link{:rel => 'apple-touch-icon', :href => "#{image_path('apple-touch-icon.png')}"} - %title - = page_title yield(:page_title) - - = og_site_name = chartbeat_head_block = include_mixpanel diff --git a/app/views/layouts/application.mobile.haml b/app/views/layouts/application.mobile.haml index 4810a63b376f91f0584b07ef1985544540ca861b..a478d705819a1cda7a6ecea7228ba297ad52de46 100644 --- a/app/views/layouts/application.mobile.haml +++ b/app/views/layouts/application.mobile.haml @@ -8,17 +8,18 @@ %title = pod_name - %meta{:name => "description", :content => "Diaspora* Mobile"} - %meta{:name => "author", :content => "Diaspora, Inc."} - - %meta{"http-equiv"=>"Content-Type", :content=>"text/html; charset=utf-8"}/ + %meta{:name => "description", :content => "Diaspora* Mobile"}/ + %meta{:name => "author", :content => "Diaspora, Inc."}/ + %meta{:charset => 'utf-8'}/ + %meta{:property => "og:site_name", :content => "#{AppConfig.settings.pod_name}"}/ + / Viewport scale - %meta{:name =>'viewport', :content => "width=device-width, minimum-scale=1 maximum-scale=1"} - %meta{:name => "HandheldFriendly", :content => "True"} - %meta{:name => "MobileOptimized", :content => "320"} + %meta{:name =>'viewport', :content => "width=device-width, minimum-scale=1 maximum-scale=1"}/ + %meta{:name => "HandheldFriendly", :content => "True"}/ + %meta{:name => "MobileOptimized", :content => "320"}/ / Force cleartype on WP7 - %meta{'http-equiv' => "cleartype", :content => 'on'} - = og_site_name + %meta{'http-equiv' => "cleartype", :content => 'on'}/ + / Home screen icon (sized for retina displays) %link{:rel => 'apple-touch-icon', :href => '/apple-touch-icon.png'} / For Nokia devices