diff --git a/Changelog.md b/Changelog.md index e86ec633c2583b3fef88ba24b61b5d1c8997c940..083790cfcd25afb6044961b157579cc4d5bfded9 100644 --- a/Changelog.md +++ b/Changelog.md @@ -29,6 +29,7 @@ * Fix mobile more-button wording when there are less than 15 posts [#6118](https://github.com/diaspora/diaspora/pull/6118) * Fix reappearing flash boxes during sign-in [#6146](https://github.com/diaspora/diaspora/pull/6146) * Capitalize Wiki link [#6193](https://github.com/diaspora/diaspora/pull/6193) +* Fix mobile photos index page [#6243](https://github.com/diaspora/diaspora/pull/6243) ## Features * Add configuration options for some debug logs [#6090](https://github.com/diaspora/diaspora/pull/6090) diff --git a/app/controllers/photos_controller.rb b/app/controllers/photos_controller.rb index 7c543c140ab0b38fab582f36f9752f7ea2578d5f..8512ab75206ac522559d71fe77577d2fb8f1a6a2 100644 --- a/app/controllers/photos_controller.rb +++ b/app/controllers/photos_controller.rb @@ -34,6 +34,7 @@ class PhotosController < ApplicationController } render "people/show", layout: "with_header" end + format.mobile { render "people/show" } format.json{ render_for_api :backbone, :json => @posts, :root => :photos } end else diff --git a/app/views/people/show.mobile.haml b/app/views/people/show.mobile.haml index db85990ae6e0a243734c148b315bbcb57e6d1ea5..426fe088669289f120b9e1e7d6ca23784c3cd284 100644 --- a/app/views/people/show.mobile.haml +++ b/app/views/people/show.mobile.haml @@ -18,17 +18,17 @@ = Diaspora::Taggable.format_tags(@person.tag_string) .span12.profile_stream - - if @stream.stream_posts.length > 0 - - if @post_type == :photos - = render 'photos/index', :photos => @stream.stream_posts - - else - #main_stream.stream - = render 'shared/stream', :posts => @stream.stream_posts - = render 'shared/stream_more_button' + - if @post_type == :photos + = render "photos/index", photos: @posts - else - #main_stream - .dull - - if @block.present? - = t('.ignoring', :name => @person.first_name) - - elsif user_signed_in? && (current_user.person != @person) - = t('.has_not_shared_with_you_yet', :name => @person.first_name) + - if @stream.stream_posts.length > 0 + #main_stream.stream + = render "shared/stream", posts: @stream.stream_posts + = render "shared/stream_more_button" + - else + #main_stream + .dull + - if @block.present? + = t(".ignoring", name: @person.first_name) + - elsif user_signed_in? && (current_user.person != @person) + = t(".has_not_shared_with_you_yet", name: @person.first_name) diff --git a/app/views/photos/_index.html.haml b/app/views/photos/_index.mobile.haml similarity index 100% rename from app/views/photos/_index.html.haml rename to app/views/photos/_index.mobile.haml diff --git a/spec/controllers/photos_controller_spec.rb b/spec/controllers/photos_controller_spec.rb index 8efdfe7694ae36537c87a82e916e920883314a17..c0e2efcabfc21094cf695a03cab3304cfd32e8ce 100644 --- a/spec/controllers/photos_controller_spec.rb +++ b/spec/controllers/photos_controller_spec.rb @@ -82,6 +82,16 @@ describe PhotosController, :type => :controller do expect(response).to be_success end + it "succeeds on mobile devices without any available pictures" do + get :index, format: :mobile, person_id: FactoryGirl.create(:person).guid.to_s + expect(response).to be_success + end + + it "succeeds on mobile devices with available pictures" do + get :index, format: :mobile, person_id: bob.person.guid.to_s + expect(response).to be_success + end + it "displays the logged in user's pictures" do get :index, :person_id => alice.person.guid.to_s expect(assigns[:person]).to eq(alice.person)