diff --git a/config/application.rb b/config/application.rb index dd9ca5adfd4303890ebe894635e9a7709247f318..619b66070ce0986a9e99baf3b37884b9aa37297b 100644 --- a/config/application.rb +++ b/config/application.rb @@ -72,6 +72,7 @@ module Diaspora jquery_ujs.js main.js jsxc.js + bookmarklet.js mobile/bookmarklet.js mobile/mobile.js templates.js diff --git a/lib/bookmarklet_renderer.rb b/lib/bookmarklet_renderer.rb index 3114d5a807b01733e9a7d105da4d7cd3520882ae..0ecc9cf48a2d8fc2cd0b0f8c2d542aae3bd0d7e8 100644 --- a/lib/bookmarklet_renderer.rb +++ b/lib/bookmarklet_renderer.rb @@ -2,27 +2,35 @@ class BookmarkletRenderer class << self def cached_name - @cached ||= Rails.root.join("public", "assets", "bookmarklet.js") + @cached_name ||= if Rails.application.config.assets.compile + "bookmarklet.js" + else + Rails.application.assets_manifest.assets["bookmarklet.js"] + end end - def source_name + def cached_path + @cached_path ||= Rails.root.join("public", "assets", cached_name) + end + + def source @source ||= Rails.application.assets["bookmarklet.js"].pathname.to_s end def body - if !File.exist?(cached_name) && Rails.env.production? - raise "please run the Rake task to compile the bookmarklet: `bundle exec rake assets:uglify_bookmarklet`" + unless File.exist?(cached_path) || Rails.application.config.assets.compile + raise "Please run the rake task to compile the bookmarklet: `bin/rake assets:precompile`" end - compile unless Rails.env.production? # don't make me re-run rake in development - @body ||= File.read(cached_name) + compile if Rails.application.config.assets.compile + @body ||= File.read(cached_path) end def compile - src = File.read(source_name) + src = File.read(source) @body = Uglifier.compile(src) - FileUtils.mkdir_p cached_name.dirname - File.open(cached_name, "w") {|f| f.write(@body) } + FileUtils.mkdir_p cached_path.dirname + File.open(cached_path, "w") {|f| f.write(@body) } end end end diff --git a/lib/tasks/assets.rake b/lib/tasks/assets.rake index 0bf591cfb3c13e69d74d41602dfed514c36732dc..917630f62e031729167f8230f2419363e582eb25 100644 --- a/lib/tasks/assets.rake +++ b/lib/tasks/assets.rake @@ -5,11 +5,6 @@ namespace :assets do renderer.render end - desc "Uglify bookmarklet snippet" - task :uglify_bookmarklet => :environment do - BookmarkletRenderer.compile - end - desc "Create non digest assets" task non_digest_assets: :environment do logger = ::Logging::Logger["assets:non_digest_assets"] @@ -35,7 +30,6 @@ namespace :assets do # Augment precompile with error page generation task :precompile do Rake::Task["assets:generate_error_pages"].invoke - Rake::Task["assets:uglify_bookmarklet"].invoke Rake::Task["assets:non_digest_assets"].invoke end end