diff --git a/Changelog.md b/Changelog.md index b4ee9094353dd396e04c77c01a89c9da30da911f..c9b28d8f59e4c0951eba356d779d0e7144e43a05 100644 --- a/Changelog.md +++ b/Changelog.md @@ -8,6 +8,7 @@ * Fix first comment in mobile view with french locale [#7441](https://github.com/diaspora/diaspora/pull/7441) * Use post page title and post author in atom feed [#7420](https://github.com/diaspora/diaspora/pull/7420) * Handle broken public keys when receiving posts [#7448](https://github.com/diaspora/diaspora/pull/7448) +* Fix welcome message when podmin is set to an invalid username [#7452](https://github.com/diaspora/diaspora/pull/7452) ## Features diff --git a/app/models/user.rb b/app/models/user.rb index e8a09a322db9049c22cf689182f1314de689e94f..55fd554c53c1edcac56d99312fc344c0f8320d71 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -431,6 +431,7 @@ class User < ActiveRecord::Base return unless AppConfig.settings.welcome_message.enabled? && AppConfig.admins.account? sender_username = AppConfig.admins.account.get sender = User.find_by(username: sender_username) + return if sender.nil? conversation = sender.build_conversation( participant_ids: [sender.person.id, person.id], subject: AppConfig.settings.welcome_message.subject.get, diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index da59913cef38596c4537dbb6d3d85b648db34760..f12f0390cf832ef5961cdc6d244cba0ca89cee3e 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -875,6 +875,12 @@ describe User, :type => :model do user.send_welcome_message expect(user.conversations.count).to eq 0 end + + it "should send no welcome message if podmin is invalid" do + AppConfig.admins.account = "invalid" + user.send_welcome_message + expect(user.conversations.count).to eq 0 + end end context "with welcome message disabled" do