From a0a9f01be188b8f0fe136b9f7510e563a99b6c7c Mon Sep 17 00:00:00 2001
From: James Fleming <jflemingprod@gmail.com>
Date: Thu, 27 Jun 2013 16:10:11 +0200
Subject: [PATCH] Remove tests for strong parameters
Remove a duplicated test.
---
spec/controllers/aspects_controller_spec.rb | 58 +--------------------
1 file changed, 1 insertion(+), 57 deletions(-)
diff --git a/spec/controllers/aspects_controller_spec.rb b/spec/controllers/aspects_controller_spec.rb
index 8da2b25541..7f0a0d875f 100644
--- a/spec/controllers/aspects_controller_spec.rb
+++ b/spec/controllers/aspects_controller_spec.rb
@@ -41,36 +41,12 @@ describe AspectsController do
response.should be_redirect
end
it 'redirects on an invalid id' do
- get :show, 'id' => 4341029835
+ get :show, 'id' => 4341029834
response.should be_redirect
end
end
describe "#create" do
- context "strong parameters" do
- it "permits 'name', 'contacts_visible' and 'order_id'" do
- post :create, "aspect" => {
- "name" => "new aspect",
- "contacts_visible" => true,
- "order_id" => 1
- }
- aspect = alice.aspects.last
- aspect.name.should eq("new aspect")
- aspect.contacts_visible.should eq(true)
- aspect.order_id.should eq(1)
- end
-
- it "forbids other params" do
- post :create, "aspect" => {
- "name" => "new aspect",
- "user_id" => 123
- }
- aspect = Aspect.last
- aspect.name.should eq("new aspect")
- aspect.user_id.should_not eq(123)
- end
- end
-
context "with valid params" do
it "creates an aspect" do
alice.aspects.count.should == 2
@@ -121,38 +97,6 @@ describe AspectsController do
@alices_aspect_1 = alice.aspects.create(:name => "Bruisers")
end
- context "strong parameters" do
- it "permits 'name', 'contacts_visible' and 'order_id'" do
- put 'update', :id => @alices_aspect_1.id, "aspect" => {
- "name" => "new aspect",
- "contacts_visible" => true,
- "order_id" => 1
- }
- aspect = Aspect.find(@alices_aspect_1.id)
- aspect.name.should eq("new aspect")
- aspect.contacts_visible.should eq(true)
- aspect.order_id.should eq(1)
- end
-
- it "forbids other params" do
- put :update, :id => @alices_aspect_1.id, "aspect" => {
- "name" => "new aspect",
- "user_id" => 123
- }
- aspect = Aspect.find(@alices_aspect_1.id)
- aspect.name.should eq("new aspect")
- aspect.user_id.should_not eq(123)
- end
- end
-
- it "doesn't overwrite random attributes" do
- new_user = FactoryGirl.create :user
- params = {"name" => "Bruisers"}
- params[:user_id] = new_user.id
- put('update', :id => @alices_aspect_1.id, "aspect" => params)
- Aspect.find(@alices_aspect_1.id).user_id.should == alice.id
- end
-
it "should return the name and id of the updated item" do
params = {"name" => "Bruisers"}
put('update', :id => @alices_aspect_1.id, "aspect" => params)
--
GitLab