From a29a1bec3ee8044f1932acbd9fefd8b22eb89b3b Mon Sep 17 00:00:00 2001
From: Raphael <raphael@joindiaspora.com>
Date: Thu, 26 Aug 2010 11:07:26 -0700
Subject: [PATCH] Add some logging to comments
---
.gitignore | 2 +-
app/models/comment.rb | 5 +++++
spec/models/user/receive_spec.rb | 14 ++++++++++++--
3 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/.gitignore b/.gitignore
index dafc5e44d9..d57f5a3387 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,7 +5,7 @@
*~
.bundle
db/*.sqlite3
-log/*.log
+log/*
tmp/**/*
Gemfile.lock
gpg/diaspora-development/*.gpg
diff --git a/app/models/comment.rb b/app/models/comment.rb
index b4f2fb2d97..bd72721eeb 100644
--- a/app/models/comment.rb
+++ b/app/models/comment.rb
@@ -57,6 +57,11 @@ class Comment
verify_signature(post_creator_signature, post.person)
end
+ def signature_valid?
+ Rails.logger.warn "Received comment has person #{person.inspect}"
+ Rails.logger.warn "Received comment has person key #{person.serialized_key}" if person
+ verify_signature(creator_signature, person) && verify_signature(post_creator_signator, post.person)
+ end
protected
def sign_if_my_post
diff --git a/spec/models/user/receive_spec.rb b/spec/models/user/receive_spec.rb
index bd2afb6ddb..2a08ba76a1 100644
--- a/spec/models/user/receive_spec.rb
+++ b/spec/models/user/receive_spec.rb
@@ -8,6 +8,10 @@ describe User do
@user2 = Factory.create(:user)
@group2 = @user2.group(:name => 'losers')
+
+ @user3 = Factory.create(:user)
+ @group3 = @user3.group(:name => 'heroes')
+
friend_users(@user, @group, @user2, @group2)
end
@@ -36,11 +40,17 @@ describe User do
@user.groups.size.should == num_groups
end
+ describe 'comments' do
+ it 'should receive comments from unknown users' do
+ friend_users(@user, @group, @user2, @group2)
+
+ status_message = @user.post, :status_message, :message => 'message', :to => @group.id
+ end
+ end
describe 'post refs' do
before do
- @user3 = Factory.create(:user)
- @group3 = @user3.group(:name => 'heroes')
+
end
it "should add the post to that user's posts when a user posts it" do
--
GitLab