From a9919fabd18875117aac7b6de1a8ca55d31e2ddf Mon Sep 17 00:00:00 2001
From: realtin <juliakbln@gmail.com>
Date: Mon, 13 Jul 2015 14:23:32 +0200
Subject: [PATCH] refactor test to use let and rm unused variables
---
spec/models/aspect_spec.rb | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/spec/models/aspect_spec.rb b/spec/models/aspect_spec.rb
index 4d85a2b1fc..301a7d3a49 100644
--- a/spec/models/aspect_spec.rb
+++ b/spec/models/aspect_spec.rb
@@ -6,20 +6,14 @@ require 'spec_helper'
describe Aspect, :type => :model do
describe 'creation' do
- before do
- @name = alice.aspects.first.name
- end
+ let(:name) { alice.aspects.first.name }
it 'does not allow duplicate names' do
- expect {
- invalid_aspect = alice.aspects.create(:name => @name)
- }.not_to change(Aspect, :count)
+ expect { alice.aspects.create(:name => name) }.not_to change(Aspect, :count)
end
it 'validates case insensitiveness on names' do
- expect {
- invalid_aspect = alice.aspects.create(:name => @name.titleize)
- }.not_to change(Aspect, :count)
+ expect { alice.aspects.create(:name => name.titleize) }.not_to change(Aspect, :count)
end
it 'has a 20 character limit on names' do
--
GitLab