Skip to content
Extraits de code Groupes Projets
  • Benaka's avatar
    7d35aea0
    Several fixes/improvements to angular period selector (#12319) · 7d35aea0
    Benaka a rédigé
    * If a period is filtered out, the result of the periods array becomes an object which breaks the period selector which expects an array.
    
    * Use $onInit instead of directive constructor. Seems angular.js silences errors when this is done.
    
    * Parse previousN/lastN dates correctly in angular periods service.
    
    * Parse periods using piwikPeriods client side, since we cannot assume a date range. Also if an invalid is used for period/date, display ERROR in the period selector.
    
    * Angular will swallow errors from datepicker.parseDate, so add a console.log for developer sanity + make sure period selector has consistent state even when period/date values are invalid (& result in failed date parsing).
    
    * Update misc/log-analytics submodule to latest.
    7d35aea0
    Historique
    Several fixes/improvements to angular period selector (#12319)
    Benaka a rédigé
    * If a period is filtered out, the result of the periods array becomes an object which breaks the period selector which expects an array.
    
    * Use $onInit instead of directive constructor. Seems angular.js silences errors when this is done.
    
    * Parse previousN/lastN dates correctly in angular periods service.
    
    * Parse periods using piwikPeriods client side, since we cannot assume a date range. Also if an invalid is used for period/date, display ERROR in the period selector.
    
    * Angular will swallow errors from datepicker.parseDate, so add a console.log for developer sanity + make sure period selector has consistent state even when period/date values are invalid (& result in failed date parsing).
    
    * Update misc/log-analytics submodule to latest.