diff --git a/core/Access.php b/core/Access.php index 7d35ed72cf5e6d501f74b59e2a69c3c38f9477de..5490cc5d419cea24d8895e42290be48492728310 100644 --- a/core/Access.php +++ b/core/Access.php @@ -275,12 +275,21 @@ class Access return $this->token_auth; } + /** + * @see Access::getConfigSuperUserLogin() + * @deprecated deprecated since version 2.0.4 + */ + public function getSuperUserLogin() + { + return $this->getConfigSuperUserLogin(); + } + /** * Returns the super user's login. * * @return string */ - public function getSuperUserLogin() + public function getConfigSuperUserLogin() { $superuser = Config::getInstance()->superuser; return $superuser['login']; @@ -445,7 +454,7 @@ class Access private function setConfigUserLoginIfCurrentUserHasNotSuperUserAccess() { if (!Piwik::hasTheUserSuperUserAccess($this->login)) { - $this->login = $this->getSuperUserLogin(); + $this->login = $this->getConfigSuperUserLogin(); } } } diff --git a/core/Piwik.php b/core/Piwik.php index 49f839d66582fa1cb83d0ece4ba267abf42131c6..5c787ed7a121a64086fac7c30b5c188f6cbaf966 100644 --- a/core/Piwik.php +++ b/core/Piwik.php @@ -230,7 +230,7 @@ class Piwik */ static public function getConfigSuperUserLogin() { - return Access::getInstance()->getSuperUserLogin(); + return Access::getInstance()->getConfigSuperUserLogin(); } /** diff --git a/tests/PHPUnit/Core/DeprecatedMethodsTest.php b/tests/PHPUnit/Core/DeprecatedMethodsTest.php index 2f0e63a5d86f590c812550070f117bbc93f92210..9f51d568749dc44585907f8bd307d517a05ad4f6 100644 --- a/tests/PHPUnit/Core/DeprecatedMethodsTest.php +++ b/tests/PHPUnit/Core/DeprecatedMethodsTest.php @@ -31,8 +31,10 @@ class DeprecatedMethodsTest extends PHPUnit_Framework_TestCase $this->assertDeprecatedMethodIsRemoved('\Piwik\Piwik', 'getSuperUserLogin', $validTill); $this->assertDeprecatedMethodIsRemoved('\Piwik\Access', 'isSuperUser', $validTill); $this->assertDeprecatedMethodIsRemoved('\Piwik\Access', 'checksUserIsSuperUser', $validTill); + $this->assertDeprecatedMethodIsRemoved('\Piwik\Access', 'getSuperUserLogin', $validTill); $this->assertDeprecatedMethodIsRemoved('\FakeAccess', 'checksUserIsSuperUser', $validTill); $this->assertDeprecatedMethodIsRemoved('\FakeAccess', 'setSuperUser', $validTill); + $this->assertDeprecatedMethodIsRemoved('\FakeAccess', 'getSuperUserLogin', $validTill); } private function assertDeprecatedMethodIsRemoved($className, $method, $removalDate) diff --git a/tests/PHPUnit/FakeAccess.php b/tests/PHPUnit/FakeAccess.php index 83447f49b4699d6577e828600df39a35bf801f5d..7a9d7ce2ca4458d92ad957bc220dfeaf5d3be341 100644 --- a/tests/PHPUnit/FakeAccess.php +++ b/tests/PHPUnit/FakeAccess.php @@ -183,8 +183,17 @@ class FakeAccess return $result; } - public function getSuperUserLogin() + public function getConfigSuperUserLogin() { return self::$superUserLogin; } + + /** + * @see FakeAccess::getConfigSuperUserLogin() + * @deprecated deprecated since version 2.0.4 + */ + public function getSuperUserLogin() + { + return $this->getConfigSuperUserLogin(); + } }