From 5231d5703bd6fa690d86c21e6b5d6afc225242e8 Mon Sep 17 00:00:00 2001
From: mattab <matthieu.aubry@gmail.com>
Date: Thu, 20 Nov 2014 11:37:25 +1300
Subject: [PATCH] Fix unit test after I disabled some tests in
13c730f35381b441b1b02b22e3990f3f5148de59 cc @sgiehl
---
.../Translate/Filter/ByParameterCountTest.php | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/tests/PHPUnit/Unit/Translate/Filter/ByParameterCountTest.php b/tests/PHPUnit/Unit/Translate/Filter/ByParameterCountTest.php
index 220e90f9a6..b014b0a9f1 100644
--- a/tests/PHPUnit/Unit/Translate/Filter/ByParameterCountTest.php
+++ b/tests/PHPUnit/Unit/Translate/Filter/ByParameterCountTest.php
@@ -10,6 +10,9 @@ namespace Piwik\Tests\Unit\Translate\Filter;
use Piwik\Translate\Filter\ByParameterCount;
+/**
+ * @group ByParameterCountTest
+ */
class ByParameterCountTest extends \PHPUnit_Framework_TestCase
{
public function getFilterTestData()
@@ -44,11 +47,7 @@ class ByParameterCountTest extends \PHPUnit_Framework_TestCase
'key' => 'value',
)
),
- array(
- 'test' => array(
- 'test' => 'test',
- )
- ),
+ array(),
array(
'test' => array(
'key' => 'val%sue',
@@ -97,9 +96,6 @@ class ByParameterCountTest extends \PHPUnit_Framework_TestCase
'empty' => array(
'test' => 't%1$sest'
),
- 'test' => array(
- 'empty' => ' ',
- )
),
array(
'test' => array(
@@ -118,7 +114,8 @@ class ByParameterCountTest extends \PHPUnit_Framework_TestCase
{
$filter = new ByParameterCount($baseTranslations);
$result = $filter->filter($translations);
- $this->assertEquals($expected, $result);
+ $message = sprintf("got %s but expected %s", var_export($result, true), var_export($expected, true));
+ $this->assertEquals($expected, $result, $message);
$this->assertEquals($filteredData, $filter->getFilteredData());
}
}
--
GitLab