From 53dbf66437d659a90345634f7f6e4f31b22ce529 Mon Sep 17 00:00:00 2001
From: mattpiwik <matthieu.aubry@gmail.com>
Date: Fri, 31 Aug 2012 21:49:33 +0000
Subject: [PATCH] Fixes #3354 Do not use filter_var
git-svn-id: http://dev.piwik.org/svn/trunk@6893 59fd770c-687e-43c8-a1e3-f5a4ff64c105
---
core/Updates/1.8.3-b1.php | 2 +-
plugins/PDFReports/PDFReports.php | 6 +-----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/core/Updates/1.8.3-b1.php b/core/Updates/1.8.3-b1.php
index df747d837d..0d899ba3d0 100644
--- a/core/Updates/1.8.3-b1.php
+++ b/core/Updates/1.8.3-b1.php
@@ -80,7 +80,7 @@ class Piwik_Updates_1_8_3_b1 extends Piwik_Updates
$parameters[Piwik_PDFReports::ADDITIONAL_EMAILS_PARAMETER] = preg_split('/,/', $additional_emails);
}
- $parameters[Piwik_PDFReports::EMAIL_ME_PARAMETER] = is_null($email_me) ? Piwik_PDFReports::EMAIL_ME_PARAMETER_DEFAULT_VALUE : filter_var($email_me, FILTER_VALIDATE_BOOLEAN);
+ $parameters[Piwik_PDFReports::EMAIL_ME_PARAMETER] = is_null($email_me) ? Piwik_PDFReports::EMAIL_ME_PARAMETER_DEFAULT_VALUE : (bool)$email_me;
$parameters[Piwik_PDFReports::DISPLAY_FORMAT_PARAMETER] = $display_format;
Piwik_Query(
diff --git a/plugins/PDFReports/PDFReports.php b/plugins/PDFReports/PDFReports.php
index 0a1d442c9f..be87c0b4a3 100644
--- a/plugins/PDFReports/PDFReports.php
+++ b/plugins/PDFReports/PDFReports.php
@@ -135,11 +135,7 @@ class Piwik_PDFReports extends Piwik_Plugin
}
else
{
- $parameters[self::EMAIL_ME_PARAMETER] =
- filter_var(
- $parameters[self::EMAIL_ME_PARAMETER],
- FILTER_VALIDATE_BOOLEAN
- );
+ $parameters[self::EMAIL_ME_PARAMETER] = (bool)$parameters[self::EMAIL_ME_PARAMETER];
}
// additionalEmails is an optional parameter
--
GitLab