From 53e4bc25b025b853a3260e0d108125b3f18917eb Mon Sep 17 00:00:00 2001
From: diosmosis <benakamoorthi@fastmail.fm>
Date: Tue, 15 Jul 2014 18:18:13 -0700
Subject: [PATCH] Complete rendering even if capture selector cannot be found
so failing tests can be better debugged. In screenshot testing lib.
---
tests/lib/screenshot-testing/support/page-renderer.js | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/lib/screenshot-testing/support/page-renderer.js b/tests/lib/screenshot-testing/support/page-renderer.js
index 960879b655..aa0fb12f87 100644
--- a/tests/lib/screenshot-testing/support/page-renderer.js
+++ b/tests/lib/screenshot-testing/support/page-renderer.js
@@ -280,7 +280,8 @@ PageRenderer.prototype.capture = function (outputPath, callback, selector) {
}, selector);
if (!result) {
- throw new Error("Cannot find element " + selector);
+ console.log("Cannot find element " + selector);
+ return;
}
if (result && result.__isCallError) {
@@ -290,8 +291,10 @@ PageRenderer.prototype.capture = function (outputPath, callback, selector) {
if (null === result.left
|| null === result.top
|| null === result.bottom
- || null === result.right) {
- throw new Error("Element(s) " + selector + " found but none is visible");
+ || null === result.right
+ ) {
+ console.log("Element(s) " + selector + " found but none is visible");
+ return;
}
page.clipRect = result;
--
GitLab