diff --git a/core/Plugin/ViewDataTable.php b/core/Plugin/ViewDataTable.php index cc57e5e0f18200811bda0ee493a84c583e5c3f18..a5d4b6164842e66a56af4a2eba2009cdcd64b6bf 100644 --- a/core/Plugin/ViewDataTable.php +++ b/core/Plugin/ViewDataTable.php @@ -297,6 +297,6 @@ abstract class ViewDataTable implements ViewInterface public static function canDisplayViewDataTable(ViewDataTable $view) { - return $view->config->show_graph_views_icons; + return $view->config->show_all_views_icons; } } \ No newline at end of file diff --git a/core/ViewDataTable/Config.php b/core/ViewDataTable/Config.php index b9bf673c4d5b0eda0729467507a785e32acc96bb..233f9f21c8e60462a218a6e05b6162699cf9bbee 100644 --- a/core/ViewDataTable/Config.php +++ b/core/ViewDataTable/Config.php @@ -179,11 +179,11 @@ class Config public $columns_to_display = array(); /** - * Controls whether the graph footer icons are shown or not. + * Controls whether graph and non core viewDataTable footer icons are shown or not. * * Default value: true */ - public $show_graph_views_icons = true; + public $show_all_views_icons = true; /** * Controls whether to display a tiny upside-down caret over the currently active view icon. diff --git a/core/ViewDataTable/Manager.php b/core/ViewDataTable/Manager.php index c3c3b0cccc08d67014a92b9fea01a36af68d640c..c6516b6c5284113e2f3d5d31fec1df1f908bd587 100644 --- a/core/ViewDataTable/Manager.php +++ b/core/ViewDataTable/Manager.php @@ -169,7 +169,7 @@ class Manager 'buttons' => array(), ); - if ($view->config->show_graph_views_icons) { + if ($view->config->show_all_views_icons) { if ($view->config->show_bar_chart) { $graphViewIcons['buttons'][] = static::getFooterIconFor(Bar::ID); } diff --git a/plugins/Actions/Actions.php b/plugins/Actions/Actions.php index 3154c2ac75aa31432695dbb05892ebc22588b65b..9687b957994d8074271a5c667b7dbf10fadb52a5 100644 --- a/plugins/Actions/Actions.php +++ b/plugins/Actions/Actions.php @@ -692,7 +692,7 @@ class Actions extends \Piwik\Plugin if ($this->pluginName == $view->requestConfig->getApiModuleToRequest()) { if ($view->isRequestingSingleDataTable()) { // make sure custom visualizations are shown on actions reports - $view->config->show_graph_views_icons = true; + $view->config->show_all_views_icons = true; $view->config->show_bar_chart = false; $view->config->show_pie_chart = false; $view->config->show_tag_cloud = false; @@ -706,7 +706,7 @@ class Actions extends \Piwik\Plugin $view->config->search_recursive = true; $view->config->show_table_all_columns = false; $view->requestConfig->filter_limit = self::ACTIONS_REPORT_ROWS_DISPLAY; - $view->config->show_graph_views_icons = false; + $view->config->show_all_views_icons = false; if ($view->isViewDataTableId(HtmlTable::ID)) { $view->config->show_embedded_subtable = true; diff --git a/plugins/CoreHome/DataTableRowAction/RowEvolution.php b/plugins/CoreHome/DataTableRowAction/RowEvolution.php index 427d455bdaf9a610c04f92b59d112135de5ce5f2..13b63610db9aacca963cd2335195d22aad00a3a8 100644 --- a/plugins/CoreHome/DataTableRowAction/RowEvolution.php +++ b/plugins/CoreHome/DataTableRowAction/RowEvolution.php @@ -198,7 +198,7 @@ class RowEvolution } $view->config->show_goals = false; - $view->config->show_graph_views_icons = false; + $view->config->show_all_views_icons = false; $view->config->show_active_view_icon = false; $view->config->show_related_reports = false; $view->config->show_series_picker = false; diff --git a/plugins/CoreVisualizations/Visualizations/JqplotGraph/Evolution/Config.php b/plugins/CoreVisualizations/Visualizations/JqplotGraph/Evolution/Config.php index 0a642eb3a53ac23555c4873be010cc1d9f69d48e..5596d0456f546c8bddb1c3266d154e8fc3833e18 100644 --- a/plugins/CoreVisualizations/Visualizations/JqplotGraph/Evolution/Config.php +++ b/plugins/CoreVisualizations/Visualizations/JqplotGraph/Evolution/Config.php @@ -29,7 +29,7 @@ class Config extends JqplotGraphConfig { parent::__construct(); - $this->show_graph_views_icons = false; + $this->show_all_views_icons = false; $this->show_table = false; $this->show_table_all_columns = false; $this->hide_annotations_view = false; diff --git a/plugins/Goals/Goals.php b/plugins/Goals/Goals.php index 57e905640e8b14f974be3ded9783cd55df532016..4c0265bdd8cdba1bd18e8602aae2fabdfbc2bed9 100644 --- a/plugins/Goals/Goals.php +++ b/plugins/Goals/Goals.php @@ -569,7 +569,7 @@ class Goals extends \Piwik\Plugin $view->config->columns_to_display = array('label', 'nb_conversions'); $view->config->show_offset_information = false; $view->config->show_pagination_control = false; - $view->config->show_graph_views_icons = false; + $view->config->show_all_views_icons = false; $view->requestConfig->filter_sort_column = 'label'; $view->requestConfig->filter_sort_order = 'asc'; @@ -586,7 +586,7 @@ class Goals extends \Piwik\Plugin $view->config->show_search = false; $view->config->show_exclude_low_population = false; $view->config->show_table_all_columns = false; - $view->config->show_graph_views_icons = false; + $view->config->show_all_views_icons = false; $view->config->show_offset_information = false; $view->config->show_pagination_control = false; $view->config->columns_to_display = array('label', 'nb_conversions'); @@ -611,7 +611,7 @@ class Goals extends \Piwik\Plugin $view->config->show_ecommerce = true; $view->config->show_table = false; - $view->config->show_graph_views_icons = false; + $view->config->show_all_views_icons = false; $view->config->show_exclude_low_population = false; $view->config->show_table_all_columns = false; $view->config->addTranslation('label', $label); diff --git a/plugins/Live/Live.php b/plugins/Live/Live.php index bbab6290cf18ee869200bba6115b5ec720efaab7..fd73ccadf1371747df28fa7dd26bde3bd5e9cfe7 100644 --- a/plugins/Live/Live.php +++ b/plugins/Live/Live.php @@ -97,7 +97,7 @@ class Live extends \Piwik\Plugin $view->config->show_search = false; $view->config->show_exclude_low_population = false; $view->config->show_offset_information = false; - $view->config->show_graph_views_icons = false; + $view->config->show_all_views_icons = false; $view->config->show_table_all_columns = false; $view->config->show_export_as_rss_feed = false; diff --git a/plugins/UserSettings/UserSettings.php b/plugins/UserSettings/UserSettings.php index 3063b6c7f2de31b40d549c361d9b36d100063bd0..540a20a5deaed221488189f989ef4ce9e4cbb600 100644 --- a/plugins/UserSettings/UserSettings.php +++ b/plugins/UserSettings/UserSettings.php @@ -329,7 +329,7 @@ class UserSettings extends \Piwik\Plugin $view->config->show_offset_information = false; $view->config->show_pagination_control = false; $view->config->show_limit_control = false; - $view->config->show_graph_views_icons = false; + $view->config->show_all_views_icons = false; $view->config->show_table_all_columns = false; $view->config->columns_to_display = array('label', 'nb_visits_percentage', 'nb_visits'); $view->config->show_footer_message = Piwik::translate('UserSettings_PluginDetectionDoesNotWorkInIE'); diff --git a/plugins/VisitorInterest/VisitorInterest.php b/plugins/VisitorInterest/VisitorInterest.php index 8dbcf130fec066d9ffcdfb2c2a833cbf8c474dcb..6651c4d4ca1e703e7fb5adadf9743521ba2cad6d 100644 --- a/plugins/VisitorInterest/VisitorInterest.php +++ b/plugins/VisitorInterest/VisitorInterest.php @@ -237,7 +237,7 @@ class VisitorInterest extends \Piwik\Plugin $view->config->show_limit_control = false; $view->config->show_search = false; $view->config->show_table_all_columns = false; - $view->config->show_graph_views_icons = false; + $view->config->show_all_views_icons = false; } private function configureViewForGetNumberOfVisitsByDaysSinceLast(ViewDataTable $view) @@ -251,7 +251,7 @@ class VisitorInterest extends \Piwik\Plugin $view->config->show_offset_information = false; $view->config->show_pagination_control = false; $view->config->show_limit_control = false; - $view->config->show_graph_views_icons = false; + $view->config->show_all_views_icons = false; $view->config->show_table_all_columns = false; $view->config->show_exclude_low_population = false; $view->config->addTranslation('label', Piwik::translate('General_DaysSinceLastVisit'));