diff --git a/plugins/Actions/ArchivingHelper.php b/plugins/Actions/ArchivingHelper.php index 5cecd26d1cd4717e7cc564d5662ccdf7106df7a0..dc1c6301cb27b45cf24f678db3597c48c8692355 100644 --- a/plugins/Actions/ArchivingHelper.php +++ b/plugins/Actions/ArchivingHelper.php @@ -42,7 +42,7 @@ class Piwik_Actions_ArchivingHelper $row['idaction'] = -$row['type']; } - $url = false; + $url = ''; if(!empty($row['name']) && $row['name'] != Piwik_DataTable::LABEL_SUMMARY_ROW && $row['type'] != Piwik_Tracker_Action::TYPE_ACTION_NAME) @@ -83,10 +83,6 @@ class Piwik_Actions_ArchivingHelper } } - unset($row['name']); - unset($row['type']); - unset($row['idaction']); - unset($row['url_prefix']); if (is_null($actionRow)) { @@ -98,8 +94,7 @@ class Piwik_Actions_ArchivingHelper // For example http://piwik.org and http://id.piwik.org are reported in Piwik > Actions > Pages with /index // But, we must make sure http://piwik.org is used to link & for transitions // Note: this code is partly duplicated from Piwik_DataTable_Row->sumRowMetadata() - if( !empty($url) - && $actionType != Piwik_Tracker_Action::TYPE_ACTION_NAME + if( $row['type'] != Piwik_Tracker_Action::TYPE_ACTION_NAME && !$actionRow->isSummaryRow()) { if(($existingUrl = $actionRow->getMetadata('url')) !== false) @@ -118,6 +113,11 @@ class Piwik_Actions_ArchivingHelper } } + unset($row['name']); + unset($row['type']); + unset($row['idaction']); + unset($row['url_prefix']); + foreach($row as $name => $value) { // in some edge cases, we have twice the same action name with 2 different idaction diff --git a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_Actions.getPageUrls_firstSite_lastN__API.getProcessedReport_day.xml b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_Actions.getPageUrls_firstSite_lastN__API.getProcessedReport_day.xml index 464781cae86964dcfb720aec8c65b1885a6d2f87..b84615a11f0713580fb49cf6430fd4f6387f5a87 100644 --- a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_Actions.getPageUrls_firstSite_lastN__API.getProcessedReport_day.xml +++ b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_Actions.getPageUrls_firstSite_lastN__API.getProcessedReport_day.xml @@ -109,7 +109,11 @@ <url>http://example.org/products</url> </row> </result> - <result prettyDate="Monday 4 January 2010" /> + <result prettyDate="Monday 4 January 2010"> + <row> + <url /> + </row> + </result> <result prettyDate="Tuesday 5 January 2010"> <row> <url>http://example.org/index.htm</url> @@ -117,6 +121,9 @@ <row> <url>http://example.org/thankyou</url> </row> + <row> + <url /> + </row> </result> <result prettyDate="Wednesday 6 January 2010" /> <result prettyDate="Thursday 7 January 2010" /> diff --git a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_day.xml b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_day.xml index 7e74036e3f1550cf141bbd946eee0433c9fe70eb..ecbc005807679f276311344eea63f92bce2328ae 100644 --- a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_day.xml +++ b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_day.xml @@ -42,6 +42,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> </result> <result date="2010-01-05"> @@ -83,6 +84,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> </result> <result date="2010-01-06" /> @@ -118,6 +120,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> </result> <result date="2010-01-05" /> diff --git a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_month.xml b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_month.xml index 082ac02215a768f2c8a9e8d683ad9cf9e247d8b9..733039fac3cee5013ee17c556a27d1cccc24b7fd 100644 --- a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_month.xml +++ b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_month.xml @@ -27,6 +27,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> <row> <label>/products</label> @@ -94,6 +95,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> </result> <result date="2010-02" /> diff --git a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_week.xml b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_week.xml index 1cea30753866172e0b28f2c00db4e00eef16db7d..ba482d9d1b65002e464cd76108334c3e89ae93f8 100644 --- a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_week.xml +++ b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_week.xml @@ -42,6 +42,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> <row> <label>/index.htm</label> @@ -107,6 +108,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> </result> <result date="From 2010-01-11 to 2010-01-17" /> diff --git a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_year.xml b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_year.xml index 915c126496cf992d69d7de013ba0b67f0a301e6a..1806e680c76f772c85e7dac7a45bd4ebd860cfcb 100644 --- a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_year.xml +++ b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays__Actions.getPageUrls_year.xml @@ -27,6 +27,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> <row> <label>/products</label> @@ -94,6 +95,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> </result> <result date="2011" /> diff --git a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_day.xml b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_day.xml index 9c6ce30724184de866ef8806cb819e262aee489f..b4a9f6ef60e864afd240d70535c49d5563237b54 100644 --- a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_day.xml +++ b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_day.xml @@ -41,6 +41,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> </result> <result date="2010-01-05"> @@ -82,6 +83,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> </result> <result date="2010-01-06" /> diff --git a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_month.xml b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_month.xml index d924940f54749355b8860701d0ed95fad99079fd..1487979451129b191ef44731b334991eccd1ae31 100644 --- a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_month.xml +++ b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_month.xml @@ -26,6 +26,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> <row> <label>/products</label> diff --git a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_week.xml b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_week.xml index 95a894ed44d7fa1fc6b38b2b5829f476211e41f9..cf32d0ed6f7b1f27976642ad22dbf6d053391883 100644 --- a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_week.xml +++ b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_week.xml @@ -41,6 +41,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> <row> <label>/index.htm</label> diff --git a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_year.xml b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_year.xml index 918dd96ba65a3bdd86c296783e58426ed079ecef..f52b7ab618d3eb47fd921294c0ca73d50760423d 100644 --- a/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_year.xml +++ b/tests/integration/expected/test_TwoVisitors_twoWebsites_differentDays_idSiteOne___Actions.getPageUrls_year.xml @@ -26,6 +26,7 @@ <avg_time_on_page>0</avg_time_on_page> <bounce_rate>0%</bounce_rate> <exit_rate>0%</exit_rate> + <url /> </row> <row> <label>/products</label>