From 7974635631db3adf2ee60351b2e19d01c68e26fc Mon Sep 17 00:00:00 2001
From: Matthieu Napoli <matthieu@mnapoli.fr>
Date: Wed, 27 May 2015 18:26:18 +0200
Subject: [PATCH] Removed the .box-shadow mixins as they are useless and broken
 (break compiling to CSS)

They are useless since box-shadow is supported in all browsers except IE 8 (in which using a prefix doesn't help anyway).
---
 plugins/Dashboard/stylesheets/widget.less      |  2 +-
 plugins/ExampleTheme/stylesheets/theme.less    |  3 +++
 plugins/Morpheus/stylesheets/base/mixins.less  | 18 ------------------
 .../Morpheus/stylesheets/general/_forms.less   |  4 ++--
 plugins/Morpheus/stylesheets/main.less         |  8 ++++----
 .../Morpheus/stylesheets/ui/_components.less   |  6 +++---
 plugins/Morpheus/stylesheets/ui/_tooltip.less  |  2 +-
 7 files changed, 14 insertions(+), 29 deletions(-)

diff --git a/plugins/Dashboard/stylesheets/widget.less b/plugins/Dashboard/stylesheets/widget.less
index aa7d618ae2..3590004a72 100644
--- a/plugins/Dashboard/stylesheets/widget.less
+++ b/plugins/Dashboard/stylesheets/widget.less
@@ -3,7 +3,7 @@
     background: @theme-color-background-base;
     border: 1px solid @color-silver-l85;
     .border-radius();
-    .box-shadow-1(0 1px 1px rgba(204,204,204,.5));
+    box-shadow: 0 1px 1px rgba(204,204,204,.5);
     overflow: hidden;
     z-index: 1;
 
diff --git a/plugins/ExampleTheme/stylesheets/theme.less b/plugins/ExampleTheme/stylesheets/theme.less
index e954c49993..110427d15c 100644
--- a/plugins/ExampleTheme/stylesheets/theme.less
+++ b/plugins/ExampleTheme/stylesheets/theme.less
@@ -1,5 +1,8 @@
 @theme-fontFamily-base: Verdana, sans-serif;
 
+@theme-color-background-base: #b8ffe3;
+@theme-color-brand: #70cad4;
+
 /*
 @theme-color-brand:                    #d4291f;
 @theme-color-brand-contrast:           #ffffff;
diff --git a/plugins/Morpheus/stylesheets/base/mixins.less b/plugins/Morpheus/stylesheets/base/mixins.less
index 2ef9ff021b..b1557ea82a 100644
--- a/plugins/Morpheus/stylesheets/base/mixins.less
+++ b/plugins/Morpheus/stylesheets/base/mixins.less
@@ -27,24 +27,6 @@
     background-clip:         padding-box;
 }
 
-.box-shadow (@string, @string1) {
-    -webkit-box-shadow: @string @string1;
-    -moz-box-shadow:    @string @string1;
-    box-shadow:         @string @string1;
-}
-
-.box-shadow-1 (@string) {
-    -webkit-box-shadow: @string;
-    -moz-box-shadow:    @string;
-    box-shadow:         @string;
-}
-
-.no-box-shadow () {
-    -webkit-box-shadow: none;
-    -moz-box-shadow:    none;
-    box-shadow:         none;
-}
-
 #gradient {
 
   .horizontal(@start-color: #555, @end-color: #333, @start-percent: 0%, @end-percent: 100%) {
diff --git a/plugins/Morpheus/stylesheets/general/_forms.less b/plugins/Morpheus/stylesheets/general/_forms.less
index 0473ef2cae..1b50e73141 100644
--- a/plugins/Morpheus/stylesheets/general/_forms.less
+++ b/plugins/Morpheus/stylesheets/general/_forms.less
@@ -17,7 +17,7 @@ button[type="button"],
     .border-radius(3px) !important;
     background: none !important;
     background-color: @theme-color-brand !important;
-    .box-shadow(~"0 1px 1px rgba(13,13,13,.3), inset 0 -1px 0 rgba(13,13,13,.1)");
+    box-shadow: 0 1px 1px rgba(13,13,13,.3), inset 0 -1px 0 rgba(13,13,13,.1);
     #gradient > .vertical(rgba(255,255,255,.15), rgba(255,255,255,0)) !important;
     .font-default(12px, 16px) !important;
     color: @theme-color-brand-contrast !important;;
@@ -89,7 +89,7 @@ button[type="button"],
         border-color: @theme-color-background-lowContrast;
         .border-radius(0px);
         background: @theme-color-background-base;
-        .box-shadow(~"inset 1px 1px 3px #d8d8d8");
+        box-shadow: inset 1px 1px 3px #d8d8d8;
         padding: 0;
         color: @theme-color-text;
         text-transform: uppercase;
diff --git a/plugins/Morpheus/stylesheets/main.less b/plugins/Morpheus/stylesheets/main.less
index 74bda38153..0442907423 100644
--- a/plugins/Morpheus/stylesheets/main.less
+++ b/plugins/Morpheus/stylesheets/main.less
@@ -173,7 +173,7 @@ table.entityTable tr td a:hover {
         border-top: 0px !important;
         border-right: 0px !important;
         border-left: 0px !important;
-        .box-shadow-1(~"inset 0 2px 4px #d8d8d8");
+        box-shadow: inset 0 2px 4px #d8d8d8;
     }
 
     .widgetize {
@@ -604,7 +604,7 @@ div.sparkline {
 }
 
 .visitor-profile-info {
-    .no-box-shadow() !important;
+    box-shadow: none !important;
 }
 
 .visitor-profile-latest-visit-loc {
@@ -691,13 +691,13 @@ div.sparkline {
 
 .visitor-profile {
     background: none;
-    .box-shadow(none);
+    box-shadow: none;
     border: 0;
     .border-radius(0px);
     .visitor-profile-info {
         .border-radius(0px);
         border: 0px;
-        .box-shadow(none) !important;
+        box-shadow: none !important;
 
         > div {
             border: 0px !important;
diff --git a/plugins/Morpheus/stylesheets/ui/_components.less b/plugins/Morpheus/stylesheets/ui/_components.less
index e16b8b9775..f6fe5169f4 100644
--- a/plugins/Morpheus/stylesheets/ui/_components.less
+++ b/plugins/Morpheus/stylesheets/ui/_components.less
@@ -206,7 +206,7 @@
 
     #date {
         .border-radius(0px);
-        .box-shadow(~"inset 1px 1px 3px #d8d8d8");
+        box-shadow: inset 1px 1px 3px #d8d8d8;
         padding: 8px 10px;
         color: @theme-color-text-lighter;
         text-transform: uppercase;
@@ -276,14 +276,14 @@
 }
 
 .jqplot-seriespicker-popover {
-    .box-shadow-1(none);
+    box-shadow: none;
 }
 
 // transition box
 #Transitions_Container {
     #Transitions_CenterBox {
         border: 1px solid @color-gray;
-        .box-shadow-1(none);
+        box-shadow: none;
         .border-radius(6px);
         margin: 27px 0 0 319px;
         width: 258px;
diff --git a/plugins/Morpheus/stylesheets/ui/_tooltip.less b/plugins/Morpheus/stylesheets/ui/_tooltip.less
index af989db078..50ab20ec6c 100644
--- a/plugins/Morpheus/stylesheets/ui/_tooltip.less
+++ b/plugins/Morpheus/stylesheets/ui/_tooltip.less
@@ -2,7 +2,7 @@ body .ui-tooltip,
 body .ui-tooltip.Transitions_Tooltip_Small {
     border: 0px !important;
     background: #000000 !important;
-    .box-shadow-1(none) !important;
+    box-shadow: none !important;
     .border-radius(3px);
     .ui-tooltip-content {
         background: #000000;
-- 
GitLab