From a4e3e6f0a59633c7416f5528a34775981a842c56 Mon Sep 17 00:00:00 2001
From: diosmosis <benaka@piwik.pro>
Date: Mon, 7 Sep 2015 13:01:22 -0700
Subject: [PATCH] Quick refactor to BulkTracking Response.
---
plugins/BulkTracking/Tracker/Response.php | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/plugins/BulkTracking/Tracker/Response.php b/plugins/BulkTracking/Tracker/Response.php
index 1580f1dbce..e8d3667eec 100644
--- a/plugins/BulkTracking/Tracker/Response.php
+++ b/plugins/BulkTracking/Tracker/Response.php
@@ -69,9 +69,7 @@ class Response extends Tracker\Response
'invalid' => count($this->invalidRequests),
);
- if ($this->isAuthenticated) {
- $result['invalid_indices'] = $this->invalidRequests;
- }
+ $this->addInvalidIndicesIfAuthenticated($result);
// send error when in debug mode
if ($tracker->isDebugModeEnabled()) {
@@ -89,9 +87,7 @@ class Response extends Tracker\Response
'invalid' => count($this->invalidRequests),
);
- if ($this->isAuthenticated) {
- $result['invalid_indices'] = $this->invalidRequests;
- }
+ $this->addInvalidIndicesIfAuthenticated($result);
return $result;
}
@@ -105,4 +101,11 @@ class Response extends Tracker\Response
{
$this->isAuthenticated = $isAuthenticated;
}
+
+ private function addInvalidIndicesIfAuthenticated(&$result)
+ {
+ if ($this->isAuthenticated) {
+ $result['invalid_indices'] = $this->invalidRequests;
+ }
+ }
}
--
GitLab