diff --git a/core/API/Inconsistencies.php b/core/API/Inconsistencies.php index 58bd7404ba59ae655624a1f765751c26c188ed9e..5d0c20d418d22b3e971ed1f7119261435f71b54c 100644 --- a/core/API/Inconsistencies.php +++ b/core/API/Inconsistencies.php @@ -12,7 +12,10 @@ namespace Piwik\API; * to provide a way to clean up existing Piwik code and behavior without breaking * backwards compatibility immediately. * - * Should be removed before releasing Piwik 3.0. [TODO: note in issue about 3.0.] + * Code that handles the case when the 'format_metrics' query parameter value is + * 'bc' should be removed as well. This code is in API\Request and DataTablePostProcessor. + * + * Should be removed before releasing Piwik 3.0. */ class Inconsistencies { diff --git a/core/API/Request.php b/core/API/Request.php index 610cf80935fc0ead7568366a09ace554d3c82ecf..979f1299d0bd1a4d807366291b1d2f0f53c05ac7 100644 --- a/core/API/Request.php +++ b/core/API/Request.php @@ -93,7 +93,6 @@ class Request $defaultRequest['segment'] = $requestRaw['segment']; } - // TODO: comment on why this code is here, and make sure to mention in Inconsistencies class if (empty($defaultRequest['format_metrics'])) { $defaultRequest['format_metrics'] = 'bc'; } diff --git a/plugins/Goals/API.php b/plugins/Goals/API.php index 2a0de787568e21a6026c1e2f8fc63e55297ece89..1e65acf05f3be53d4635073fb2620d56658e6e6d 100644 --- a/plugins/Goals/API.php +++ b/plugins/Goals/API.php @@ -232,7 +232,7 @@ class API extends \Piwik\Plugin\API // First rename the avg_price_viewed column $renameColumn = array(self::AVG_PRICE_VIEWED => 'avg_price'); - $dataTable->filter('ReplaceColumnNames', array($renameColumn)); // TODO: benchmark this change + $dataTable->filter('ReplaceColumnNames', array($renameColumn)); $dataTable->queueFilter('ReplaceColumnNames'); $dataTable->queueFilter('ReplaceSummaryRowLabel'); diff --git a/plugins/Goals/Columns/Metrics/GoalSpecificProcessedMetric.php b/plugins/Goals/Columns/Metrics/GoalSpecificProcessedMetric.php index 353018c2340a929c6eebb8adf67fd8e036fcff09..1ae1c411491740fd441d2db1d1b6710b4a831561 100644 --- a/plugins/Goals/Columns/Metrics/GoalSpecificProcessedMetric.php +++ b/plugins/Goals/Columns/Metrics/GoalSpecificProcessedMetric.php @@ -46,7 +46,7 @@ abstract class GoalSpecificProcessedMetric extends ProcessedMetric $this->idGoal = $idGoal; } - protected function getColumnPrefix() // TODO: should cache this information somehow + protected function getColumnPrefix() { return 'goal_' . $this->idGoal; }