From b29040519ce25dc41f47ed98340832b58cdbac33 Mon Sep 17 00:00:00 2001
From: diosmosis <benaka@piwik.pro>
Date: Tue, 18 Nov 2014 03:12:29 -0800
Subject: [PATCH] Tweaking docs and removing TODOs.
---
core/API/Inconsistencies.php | 5 ++++-
core/API/Request.php | 1 -
plugins/Goals/API.php | 2 +-
.../Goals/Columns/Metrics/GoalSpecificProcessedMetric.php | 2 +-
4 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/core/API/Inconsistencies.php b/core/API/Inconsistencies.php
index 58bd7404ba..5d0c20d418 100644
--- a/core/API/Inconsistencies.php
+++ b/core/API/Inconsistencies.php
@@ -12,7 +12,10 @@ namespace Piwik\API;
* to provide a way to clean up existing Piwik code and behavior without breaking
* backwards compatibility immediately.
*
- * Should be removed before releasing Piwik 3.0. [TODO: note in issue about 3.0.]
+ * Code that handles the case when the 'format_metrics' query parameter value is
+ * 'bc' should be removed as well. This code is in API\Request and DataTablePostProcessor.
+ *
+ * Should be removed before releasing Piwik 3.0.
*/
class Inconsistencies
{
diff --git a/core/API/Request.php b/core/API/Request.php
index 610cf80935..979f1299d0 100644
--- a/core/API/Request.php
+++ b/core/API/Request.php
@@ -93,7 +93,6 @@ class Request
$defaultRequest['segment'] = $requestRaw['segment'];
}
- // TODO: comment on why this code is here, and make sure to mention in Inconsistencies class
if (empty($defaultRequest['format_metrics'])) {
$defaultRequest['format_metrics'] = 'bc';
}
diff --git a/plugins/Goals/API.php b/plugins/Goals/API.php
index 2a0de78756..1e65acf05f 100644
--- a/plugins/Goals/API.php
+++ b/plugins/Goals/API.php
@@ -232,7 +232,7 @@ class API extends \Piwik\Plugin\API
// First rename the avg_price_viewed column
$renameColumn = array(self::AVG_PRICE_VIEWED => 'avg_price');
- $dataTable->filter('ReplaceColumnNames', array($renameColumn)); // TODO: benchmark this change
+ $dataTable->filter('ReplaceColumnNames', array($renameColumn));
$dataTable->queueFilter('ReplaceColumnNames');
$dataTable->queueFilter('ReplaceSummaryRowLabel');
diff --git a/plugins/Goals/Columns/Metrics/GoalSpecificProcessedMetric.php b/plugins/Goals/Columns/Metrics/GoalSpecificProcessedMetric.php
index 353018c234..1ae1c41149 100644
--- a/plugins/Goals/Columns/Metrics/GoalSpecificProcessedMetric.php
+++ b/plugins/Goals/Columns/Metrics/GoalSpecificProcessedMetric.php
@@ -46,7 +46,7 @@ abstract class GoalSpecificProcessedMetric extends ProcessedMetric
$this->idGoal = $idGoal;
}
- protected function getColumnPrefix() // TODO: should cache this information somehow
+ protected function getColumnPrefix()
{
return 'goal_' . $this->idGoal;
}
--
GitLab