diff --git a/core/Log/Formatter/LineMessageFormatter.php b/core/Log/Formatter/LineMessageFormatter.php index 3119de3bfb54c9236980de6e4dfd10e314be0eff..909760079695e9d265fb8ef6d0e2812ffa8b0957 100644 --- a/core/Log/Formatter/LineMessageFormatter.php +++ b/core/Log/Formatter/LineMessageFormatter.php @@ -9,7 +9,7 @@ namespace Piwik\Log\Formatter; /** - * Formats a log message into a single line of text. + * Formats a log message into a line of text. */ class LineMessageFormatter extends Formatter { @@ -39,6 +39,8 @@ class LineMessageFormatter extends Formatter $this->logMessageFormat ); + $message = str_replace("\n", "\n ", $message); + $message .= "\n"; return $message; diff --git a/core/Log/Handler/FileHandler.php b/core/Log/Handler/FileHandler.php index 44dcaa08dba9bc48dfaaf075f911e68eb78aa1d4..c8f8440fdc6d5e976296c213538ef21fd9944e01 100644 --- a/core/Log/Handler/FileHandler.php +++ b/core/Log/Handler/FileHandler.php @@ -33,13 +33,12 @@ class FileHandler extends AbstractProcessingHandler protected function write(array $record) { - $message = str_replace("\n", "\n ", trim($record['formatted'])) . "\n"; - - if (!@file_put_contents($this->logToFilePath, $message, FILE_APPEND) + if (!@file_put_contents($this->logToFilePath, $record['formatted'], FILE_APPEND) && !defined('PIWIK_TEST_MODE') ) { - $message = Filechecks::getErrorMessageMissingPermissions($this->logToFilePath); - throw new \Exception($message); + throw new \Exception( + Filechecks::getErrorMessageMissingPermissions($this->logToFilePath) + ); } } } diff --git a/tests/PHPUnit/Integration/LogTest.php b/tests/PHPUnit/Integration/LogTest.php index c5ff9c6f9e55988b9749e807e4f77e9a94c8185a..d8f2e6cb3e430d3cb5e8d5660158813e801bdda9 100644 --- a/tests/PHPUnit/Integration/LogTest.php +++ b/tests/PHPUnit/Integration/LogTest.php @@ -42,7 +42,7 @@ dummy backtrace</div></div>', 'file' => '[Piwik\Tests\Integration\LogTest] LogTest.php(174): dummy error message dummy backtrace', 'database' => '[Piwik\Tests\Integration\LogTest] LogTest.php(174): dummy error message -dummy backtrace' + dummy backtrace' ); public static $expectedErrorOutput = array( @@ -55,7 +55,7 @@ dummy backtrace</div></div>', 'file' => '[Piwik\Tests\Integration\LogTest] dummyerrorfile.php(145): Unknown error (102) - dummy error string dummy backtrace', 'database' => '[Piwik\Tests\Integration\LogTest] dummyerrorfile.php(145): Unknown error (102) - dummy error string -dummy backtrace' + dummy backtrace' ); private $screenOutput;