From c488e33605c183cf3f73d1ac5716438951b39d52 Mon Sep 17 00:00:00 2001
From: Dillon Brock <okay19@users.noreply.github.com>
Date: Fri, 17 Mar 2017 17:05:20 -0400
Subject: [PATCH] Add system check for the hash() function (#11455)
* Add system check for the hash() function
* Update expected screenshot for hash() system check
---
.../Diagnostic/PhpFunctionsCheck.php | 2 ++
plugins/Installation/lang/en.json | 3 ++-
.../Installation_system_check.png | Bin 131 -> 131 bytes
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/plugins/Diagnostics/Diagnostic/PhpFunctionsCheck.php b/plugins/Diagnostics/Diagnostic/PhpFunctionsCheck.php
index 26e30326be..736fc73877 100644
--- a/plugins/Diagnostics/Diagnostic/PhpFunctionsCheck.php
+++ b/plugins/Diagnostics/Diagnostic/PhpFunctionsCheck.php
@@ -59,6 +59,7 @@ class PhpFunctionsCheck implements Diagnostic
'debug_backtrace',
'create_function',
'eval',
+ 'hash',
'gzcompress',
'gzuncompress',
'pack',
@@ -101,6 +102,7 @@ class PhpFunctionsCheck implements Diagnostic
'debug_backtrace' => 'Installation_SystemCheckDebugBacktraceHelp',
'create_function' => 'Installation_SystemCheckCreateFunctionHelp',
'eval' => 'Installation_SystemCheckEvalHelp',
+ 'hash' => 'Installation_SystemCheckHashHelp',
'gzcompress' => 'Installation_SystemCheckGzcompressHelp',
'gzuncompress' => 'Installation_SystemCheckGzuncompressHelp',
'pack' => 'Installation_SystemCheckPackHelp',
diff --git a/plugins/Installation/lang/en.json b/plugins/Installation/lang/en.json
index 6e13414628..131b40a2a1 100644
--- a/plugins/Installation/lang/en.json
+++ b/plugins/Installation/lang/en.json
@@ -84,6 +84,7 @@
"SystemCheckGlobHelp": "This built-in function has been disabled on your host. Piwik will attempt to emulate this function but may encounter further security restrictions. Functionality may be impacted.",
"SystemCheckGzcompressHelp": "You need to enable the zlib extension and gzcompress function.",
"SystemCheckGzuncompressHelp": "You need to enable the zlib extension and gzuncompress function.",
+ "SystemCheckHashHelp": "You need to configure and rebuild PHP with hash() support enabled by excluding the option --disable-hash.",
"SystemCheckIconvHelp": "You need to configure and rebuild PHP with \"iconv\" support enabled, --with-iconv.",
"SystemCheckJsonHelp": "The php5-json extension is required for Piwik to read and write JSON data.",
"SystemCheckMailHelp": "Feedback and Lost Password messages will not be sent without mail().",
@@ -144,4 +145,4 @@
"CannotConnectToDb": "Cannot connect to the database",
"CannotConnectToDbResolvingExplanation": "This may be a temporary issue, try %1$srefreshing the page%2$s. If the problem persists please contact your Piwik administrator."
}
-}
\ No newline at end of file
+}
diff --git a/tests/UI/expected-screenshots/Installation_system_check.png b/tests/UI/expected-screenshots/Installation_system_check.png
index 0d0af0024b9e526c6edc42afa22735a159927776..2b068301b132f4377581230171d7c62c2e18c5e4 100644
GIT binary patch
delta 84
zcmV~$%ME}q2msLZ+9@0XX!&#qhadupXK!A+fFt|fZo7SQ5*0@VX~+QPFt7wtMmKkY
dfoLhk=94hEP$Ej_T4kIb*Xqyx=7F-5q5sSm7Nr0H
delta 84
zcmV~$!3}^g2nEpe+9@2NE#w13ID`e7c=qPC3pldx?Xt^<lNm^&o)#XtW;9#S3{9}P
d!4-lb19CBOh`IWt>6*^7#Z{mC&7(t=rT+RW7l;4=
--
GitLab