From f3575224d95661edb70cf6a158ff8c1740fee350 Mon Sep 17 00:00:00 2001
From: mattab <matthieu.aubry@gmail.com>
Date: Mon, 5 Oct 2015 16:17:49 +1300
Subject: [PATCH] Add new Custom Segments: outlinkURL and downloadUrl to
segment on any Clicked URL or Downloaded file
---
core/Tracker/TableLogAction.php | 2 ++
plugins/Actions/Columns/ClickedUrl.php | 12 ++++++++++--
plugins/Actions/Columns/DownloadUrl.php | 12 ++++++++++--
3 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/core/Tracker/TableLogAction.php b/core/Tracker/TableLogAction.php
index eb7d5b7b26..db9f7859fd 100644
--- a/core/Tracker/TableLogAction.php
+++ b/core/Tracker/TableLogAction.php
@@ -202,6 +202,8 @@ class TableLogAction
private static function guessActionTypeFromSegment($segmentName)
{
$exactMatch = array(
+ 'outlinkUrl' => Action::TYPE_OUTLINK,
+ 'downloadUrl' => Action::TYPE_DOWNLOAD,
'eventAction' => Action::TYPE_EVENT_ACTION,
'eventCategory' => Action::TYPE_EVENT_CATEGORY,
'eventName' => Action::TYPE_EVENT_NAME,
diff --git a/plugins/Actions/Columns/ClickedUrl.php b/plugins/Actions/Columns/ClickedUrl.php
index 6f5fc29010..e1815904a1 100644
--- a/plugins/Actions/Columns/ClickedUrl.php
+++ b/plugins/Actions/Columns/ClickedUrl.php
@@ -9,13 +9,21 @@
namespace Piwik\Plugins\Actions\Columns;
use Piwik\Piwik;
-use Piwik\Plugin\Dimension\ActionDimension;
+use Piwik\Plugins\Actions\Segment;
-class ClickedUrl extends ActionDimension
+class ClickedUrl extends PageUrl
{
public function getName()
{
return Piwik::translate('Actions_ColumnClickedURL');
}
+ protected function configureSegments()
+ {
+ $segment = new Segment();
+ $segment->setSegment('outlinkUrl');
+ $segment->setName('Actions_ColumnClickedURL');
+ $this->addSegment($segment);
+ }
+
}
diff --git a/plugins/Actions/Columns/DownloadUrl.php b/plugins/Actions/Columns/DownloadUrl.php
index 230069a9ed..0905181573 100644
--- a/plugins/Actions/Columns/DownloadUrl.php
+++ b/plugins/Actions/Columns/DownloadUrl.php
@@ -9,13 +9,21 @@
namespace Piwik\Plugins\Actions\Columns;
use Piwik\Piwik;
-use Piwik\Plugin\Dimension\ActionDimension;
+use Piwik\Plugins\Actions\Segment;
-class DownloadUrl extends ActionDimension
+class DownloadUrl extends PageUrl
{
public function getName()
{
return Piwik::translate('Actions_ColumnDownloadURL');
}
+ protected function configureSegments()
+ {
+ $segment = new Segment();
+ $segment->setSegment('downloadUrl');
+ $segment->setName('Actions_ColumnDownloadURL');
+ $this->addSegment($segment);
+ }
+
}
--
GitLab