From fdbcce150714ba5bdd6eb4dc72a015bd49eaf7b0 Mon Sep 17 00:00:00 2001
From: sgiehl <stefan@piwik.org>
Date: Wed, 30 Sep 2015 22:08:38 +0200
Subject: [PATCH] fixes #8863 - open plugin popover for all plugin detail links
---
plugins/CorePluginsAdmin/javascripts/marketplace.js | 2 +-
plugins/CorePluginsAdmin/templates/macros.twig | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/plugins/CorePluginsAdmin/javascripts/marketplace.js b/plugins/CorePluginsAdmin/javascripts/marketplace.js
index 64cb5087ab..ceb498a401 100755
--- a/plugins/CorePluginsAdmin/javascripts/marketplace.js
+++ b/plugins/CorePluginsAdmin/javascripts/marketplace.js
@@ -13,7 +13,7 @@ $(document).ready(function () {
watch: 'window'
});
- $('.marketplace').on('click', '.plugin-details', function (event) {
+ $('a.plugin-details[data-pluginName]').on('click', function (event) {
event.preventDefault();
var pluginName = $(this).attr('data-pluginName');
diff --git a/plugins/CorePluginsAdmin/templates/macros.twig b/plugins/CorePluginsAdmin/templates/macros.twig
index 0b6e24e37a..0c0ea9e279 100644
--- a/plugins/CorePluginsAdmin/templates/macros.twig
+++ b/plugins/CorePluginsAdmin/templates/macros.twig
@@ -15,13 +15,13 @@
{% for name,plugin in pluginsHavingUpdate %}
<tr {% if plugin.isActivated|default(false) %}class="active-plugin"{% else %}class="inactive-plugin"{% endif %}>
<td class="name">
- <a href="javascript:void(0);" data-pluginName="{{ plugin.name|e('html_attr') }}">
+ <a href="javascript:void(0);" data-pluginName="{{ plugin.name|e('html_attr') }}" class="plugin-details">
{{ plugin.name }}
</a>
</td>
<td class="vers">
{% if plugin.repositoryChangelogUrl %}
- <a href="javascript:void(0);" title="{{ 'CorePluginsAdmin_Changelog'|translate }}" data-activePluginTab="changelog" data-pluginName="{{ plugin.name|e('html_attr') }}">{{ plugin.currentVersion }} => {{ plugin.latestVersion }}</a>
+ <a href="javascript:void(0);" title="{{ 'CorePluginsAdmin_Changelog'|translate }}" class="plugin-details" data-activePluginTab="changelog" data-pluginName="{{ plugin.name|e('html_attr') }}">{{ plugin.currentVersion }} => {{ plugin.latestVersion }}</a>
{% else %}
{{ plugin.currentVersion }} => {{ plugin.latestVersion }}
{% endif %}
@@ -156,7 +156,7 @@
<td class="name" style="white-space:nowrap;">
<a name="{{ name|e('html_attr') }}"></a>
{% if not plugin.isCorePlugin and name in marketplacePluginNames -%}
- <a href="javascript:void(0);"
+ <a href="javascript:void(0);" class="plugin-details"
data-pluginName="{{ name|e('html_attr') }}"
>{{ name }}</a>
{%- else %}
--
GitLab