Using recommanded ENV.fetch mechanism

app/models/event_callbacks.rb

@@ -72,10 +72,10 @@ class EventCallbacks
   # Tweet this event, if configured using apache/system variables!
   def self.tweet(event)
     client = Twitter::REST::Client.new do |config|
-      config.consumer_key        = ENV['TWITTER_CONSUMER_KEY']
-      config.consumer_secret     = ENV['TWITTER_CONSUMER_SECRET']
-      config.access_token        = ENV['TWITTER_ACCESS_TOKEN']
-      config.access_token_secret = ENV['TWITTER_ACCESS_SECRET']
+      config.consumer_key        = ENV.fetch('TWITTER_CONSUMER_KEY', nil)
+      config.consumer_secret     = ENV.fetch('TWITTER_CONSUMER_SECRET', nil)
+      config.access_token        = ENV.fetch('TWITTER_ACCESS_TOKEN', nil)
+      config.access_token_secret = ENV.fetch('TWITTER_ACCESS_SECRET', nil)
     end
     client.update event.to_tweet if client.consumer_key
   end

app/views/moderations/validate.html.haml

@@ -15,7 +15,7 @@
       %em.fa.fa-thumbs-up
       = t '.ok'
 
-- if ENV['TWITTER_CONSUMER_KEY'] || Rails.env.development?
+- if ENV.fetch('TWITTER_CONSUMER_KEY', Rails.env.development?)
   %fieldset
     %legend
       %em.fab.fa-twitter

deploy/before_restart

@@ -5,13 +5,13 @@ def run(cmd)
   exit($CHILD_STATUS.exitstatus) unless system "umask 002 && #{cmd}"
 end
 
-RAILS_ENV   = ENV['RAILS_ENV'] || 'production'
+RAILS_ENV   = ENV.fetch('RAILS_ENV', 'production')
 use_bundler = File.file? 'Gemfile'
 rake_cmd    = use_bundler ? 'bundle exec rake' : 'rake'
 
 if use_bundler
   bundler_args = ['--deployment']
-  BUNDLE_WITHOUT = ENV['BUNDLE_WITHOUT'] || 'development:test'
+  BUNDLE_WITHOUT = ENV.fetch('BUNDLE_WITHOUT', 'development:test')
   bundler_args << '--without' << BUNDLE_WITHOUT unless BUNDLE_WITHOUT.empty?
 
   # update gem bundle