Skip to content
Extraits de code Groupes Projets
  • Akihiko Odaki's avatar
    552e886b
    Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673) · 552e886b
    Akihiko Odaki a rédigé
    The old implementation had two queries:
    1. The query constructed in Api::V1::FavouritesController#results
    2. The query constructed in #cached_favourites, which is merged with 1.
    
    Both of them are issued againt PostgreSQL. The combination of the two
    queries caused the following problems:
    - The small window between the two queries involves race conditions.
    - Minor performance inefficiency.
    
    Moreover, the construction of query 2, which involves merging with query
    1 has a bug. Query 1 is finalized with paginate_by_id, but paginate_by_id
    returns an array when min_id parameter is specified. The behavior prevents
    from merging the query, and in the real world, ActiveRecord simply ignores
    the merge (!), which results in querying the entire scan of statuses and
    favourites table.
    
    This change fixes these issues by simply letting query 1 get all the works
    done.
    Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673)
    Akihiko Odaki a rédigé
    The old implementation had two queries:
    1. The query constructed in Api::V1::FavouritesController#results
    2. The query constructed in #cached_favourites, which is merged with 1.
    
    Both of them are issued againt PostgreSQL. The combination of the two
    queries caused the following problems:
    - The small window between the two queries involves race conditions.
    - Minor performance inefficiency.
    
    Moreover, the construction of query 2, which involves merging with query
    1 has a bug. Query 1 is finalized with paginate_by_id, but paginate_by_id
    returns an array when min_id parameter is specified. The behavior prevents
    from merging the query, and in the real world, ActiveRecord simply ignores
    the merge (!), which results in querying the entire scan of statuses and
    favourites table.
    
    This change fixes these issues by simply letting query 1 get all the works
    done.