Skip to content
Extraits de code Groupes Projets
  • Claire's avatar
    c8dbbd60
    Fix error-prone SQL queries (#15828) · c8dbbd60
    Claire a rédigé
    * Fix error-prone SQL queries in Account search
    
    While this code seems to not present an actual vulnerability, one could
    easily be introduced by mistake due to how the query is built.
    
    This PR parameterises the `to_tsquery` input to make the query more robust.
    
    * Harden code for Status#tagged_with_all and Status#tagged_with_none
    
    Those two scopes aren't used in a way that could be vulnerable to an SQL
    injection, but keeping them unchanged might be a hazard.
    
    * Remove unneeded spaces surrounding tsquery term
    
    * Please CodeClimate
    
    * Move advanced_search_for SQL template to its own function
    
    This avoids one level of indentation while making clearer that the SQL template
    isn't build from all the dynamic parameters of advanced_search_for.
    
    * Add tests covering tagged_with, tagged_with_all and tagged_with_none
    
    * Rewrite tagged_with_none to avoid multiple joins and make it more robust
    
    * Remove obsolete brakeman warnings
    
    * Revert "Remove unneeded spaces surrounding tsquery term"
    
    The two queries are not strictly equivalent.
    
    This reverts commit 86f16c537e06c6ba4a8b250f25dcce9f049023ff.
    c8dbbd60
    Historique
    Fix error-prone SQL queries (#15828)
    Claire a rédigé
    * Fix error-prone SQL queries in Account search
    
    While this code seems to not present an actual vulnerability, one could
    easily be introduced by mistake due to how the query is built.
    
    This PR parameterises the `to_tsquery` input to make the query more robust.
    
    * Harden code for Status#tagged_with_all and Status#tagged_with_none
    
    Those two scopes aren't used in a way that could be vulnerable to an SQL
    injection, but keeping them unchanged might be a hazard.
    
    * Remove unneeded spaces surrounding tsquery term
    
    * Please CodeClimate
    
    * Move advanced_search_for SQL template to its own function
    
    This avoids one level of indentation while making clearer that the SQL template
    isn't build from all the dynamic parameters of advanced_search_for.
    
    * Add tests covering tagged_with, tagged_with_all and tagged_with_none
    
    * Rewrite tagged_with_none to avoid multiple joins and make it more robust
    
    * Remove obsolete brakeman warnings
    
    * Revert "Remove unneeded spaces surrounding tsquery term"
    
    The two queries are not strictly equivalent.
    
    This reverts commit 86f16c537e06c6ba4a8b250f25dcce9f049023ff.