manually pulled in manuels latest commits

public/javascripts/aspects-dropdown.js

@@ -27,7 +27,7 @@ var AspectsDropdown = {
   
   toggleCheckbox: 
     function(check){
-      check.parent('li').toggleClass('selected');
+      check.toggleClass('selected');
     },
 };
 

public/javascripts/contact-edit.js

@@ -35,8 +35,7 @@ var ContactEdit = {
     var button = li.find('.button');
     if(button.hasClass('disabled') || li.hasClass('newItem')){ return; }
 
-    var checkbox = li.find('img.check'),
-        selected = li.hasClass("selected"),
+    var selected = li.hasClass("selected"),
         routedId = selected ? "/42" : "";
 
     $.post("/aspect_memberships" + routedId + ".json", {
@@ -45,7 +44,7 @@ var ContactEdit = {
       "_method": (selected) ? "DELETE" : "POST"
     }, function(aspectMembership) {
       li.removeClass('loading')
-      ContactEdit.toggleCheckbox(checkbox);
+      ContactEdit.toggleCheckbox(li);
       ContactEdit.updateNumber(li.closest(".dropdown_list"), li.parent().data("person_id"), aspectMembership.aspect_ids.length, 'in_aspect');
       Diaspora.widgets.publish("aspectDropdown/updated", [li.parent().data("person_id"), li.parents(".dropdown").parent(".right").html()]);
     });

public/javascripts/publisher.js

@@ -347,11 +347,9 @@ var Publisher = {
   bindAspectToggles: function() {
     $('#publisher .dropdown .dropdown_list li').bind("click", function(evt){
       var li = $(this),
-          button = li.find('.button'),
-          checkbox = li.find('img.check');
-      if(button.hasClass('disabled')) { return; }
+          button = li.parent('.dropdown').find('.button');
 
-      AspectsDropdown.toggleCheckbox(checkbox);
+      AspectsDropdown.toggleCheckbox(li);
       AspectsDropdown.updateNumber(li.closest(".dropdown_list"), null, li.parent().find('li.selected').length, '');
 
       Publisher.toggleAspectIds(li.attr('data-aspect_id'));
@@ -376,7 +374,7 @@ var Publisher = {
     }
   },
   onSuccess: function(data, json, xhr){
-    var isPostVisible = false;
+    var isPostVisible = AspectFilters.selectedGUIDS.length == 0;
     var postedTo = Publisher.selectedAspectIds();
     $.each(AspectFilters.selectedGUIDS, function(index, value){
       if(postedTo.indexOf(parseInt(value))>-1)