Skip to content
Extraits de code Groupes Projets
Non vérifiée Valider 4cb365a6 rédigé par Steffen van Bergerem's avatar Steffen van Bergerem Validation de Benjamin Neff
Parcourir les fichiers

Fix missing photos in the single post view

closes #7545
parent b49b3367
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
...@@ -17,15 +17,14 @@ app.views.Content = app.views.Base.extend({ ...@@ -17,15 +17,14 @@ app.views.Content = app.views.Base.extend({
largePhoto : function() { largePhoto : function() {
var photos = this.model.get("photos"); var photos = this.model.get("photos");
if(!photos || photos.length === 0) { return } if (!photos || photos.length === 0) { return false; }
return photos[0]; return photos[0];
}, },
smallPhotos : function() { smallPhotos : function() {
var photos = this.model.get("photos"); var photos = this.model.get("photos");
if(!photos || photos.length < 2) { return } if (!photos || photos.length < 2) { return false; }
photos.splice(0, 1); // remove first photo as it is already shown as largePhoto return photos.slice(1); // remove first photo as it is already shown as largePhoto
return photos;
}, },
expandPost: function(evt) { expandPost: function(evt) {
......
...@@ -4,11 +4,17 @@ describe("app.views.Content", function(){ ...@@ -4,11 +4,17 @@ describe("app.views.Content", function(){
this.view = new app.views.Content({model : this.post}); this.view = new app.views.Content({model : this.post});
}); });
describe("rendering", function(){ describe("smallPhotos", function() {
it("should return all but the first photo from the post", function() { it("should return all but the first photo from the post", function() {
this.post.set({photos : [1,2]}); // set 2 Photos this.post.set({photos : [1,2]}); // set 2 Photos
expect(this.view.smallPhotos().length).toEqual(1); expect(this.view.smallPhotos().length).toEqual(1);
}); });
it("shouldn't change the photos array", function() {
this.post.set({photos: [1, 2]}); // set 2 Photos
this.view.smallPhotos();
expect(this.post.get("photos").length).toEqual(2);
});
}); });
describe("presenter", function(){ describe("presenter", function(){
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter