Merge pull request #5108 from blase/feature/5107-set-top-margin-on-body

Set top margin only on the body element

Changelog.md

@@ -6,6 +6,7 @@
 * Port getting started to Bootstrap [#5057](https://github.com/diaspora/diaspora/pull/5057)
 * Port people search page to Bootstrap [#5077](https://github.com/diaspora/diaspora/pull/5077)
 * Clarify explanations and defaults in diaspora.yml.example [#5088](https://github.com/diaspora/diaspora/pull/5088)
+* Consistent header spacing on Bootstrap pages [#5108](https://github.com/diaspora/diaspora/pull/5108)
 
 ## Bug fixes
 * Fix hiding of poll publisher on close [#5029](https://github.com/diaspora/diaspora/issues/5029)

app/assets/stylesheets/conversations.css.scss

 .conversations_container {
-  padding-top: 40px;
-
   .stream_element {
     border-bottom: 1px solid $border-grey;
     &:first-child {

app/assets/stylesheets/getting-started.css.scss

@@ -13,7 +13,7 @@
   }
 
   .hero-unit {
-    margin: 58px 42px;
+    margin: 20px 42px;
     padding: 40px 80px;
   }
 

app/assets/stylesheets/header.css.scss

@@ -3,8 +3,6 @@
   border-bottom: none;
 }
 
-body > #container { margin-top: 50px; } /* to avoid being hidden under the header in the SPV */
-
 body > header {
   @include box-shadow(0,1px,3px,rgba(0,0,0,0.9));
   background: url('header-bg.png') rgb(40,35,35);

app/assets/stylesheets/new_styles/_base.scss

@@ -5,6 +5,7 @@ body {
 }
 
 body {
+  margin-top: 40px;
   padding : none;
 
   &.lock {
@@ -146,12 +147,6 @@ $bring-dark-accent-forward-color: #DDD;
   }
 }
 
-/* padder helper to push content below the header, to be removed when porting to bootstrap is complete */
-.bootstrap_header_padding {
-  padding-top: 40px;
-}
-
-
 #back-to-top {
   display: block;
   color: white;

app/assets/stylesheets/new_styles/_registration.scss

@@ -4,8 +4,6 @@
   min-height: 100%;
   background-color : #afc652;
   color: #fff;
-  
-  .container { margin-top: 50px; }
 
   #create-something-text {
     font-family : Roboto-Light;

app/assets/stylesheets/notifications.css.scss

 #notifications_container {
-  padding-top: 50px;
-
   .nav.nav-tabs{
     li > a {
       color: $text-dark-grey;

app/assets/templates/help_tpl.jst.hbs

-
-<div class="bootstrap_header_padding"></div>
-
 <div class="container">
 
   <div id="section_header">
@@ -78,4 +75,4 @@
     <div class="span9 last" id=faq>
     </div>
   </div>
-</div>
\ No newline at end of file
+</div>

app/views/people/index.html.haml

@@ -9,8 +9,6 @@
   = javascript_include_tag :people
   = javascript_include_tag 'contact-list'
 
-.bootstrap_header_padding
-
 .container-fluid#people_search
   .row-fluid
     .page-header

app/views/posts/show.html.haml

@@ -6,4 +6,4 @@
   = post_page_title @post
 
 - content_for :content do
-  #container
+  #container.container-fluid