JSHint semicolon errors

app/assets/javascripts/app/app.js

@@ -36,7 +36,7 @@ var app = {
 
   user: function(userAttrs) {
     if(userAttrs) { return this._user = new app.models.User(userAttrs) }
-    return this._user || false
+    return this._user || false;
   },
 
   initialize: function() {
@@ -52,21 +52,21 @@ var app = {
   },
 
   hasPreload : function(prop) {
-    return !!(window.gon.preloads && window.gon.preloads[prop]) //returning boolean variable so that parsePreloads, which cleans up properly is used instead
+    return !!(window.gon.preloads && window.gon.preloads[prop]); //returning boolean variable so that parsePreloads, which cleans up properly is used instead
   },
 
   setPreload : function(prop, val) {
-    window.gon.preloads = window.gon.preloads || {}
-    window.gon.preloads[prop] = val
+    window.gon.preloads = window.gon.preloads || {};
+    window.gon.preloads[prop] = val;
   },
 
   parsePreload : function(prop) {
       if(!app.hasPreload(prop)) { return }
 
-      var preload = window.gon.preloads[prop]
-      delete window.gon.preloads[prop] //prevent dirty state across navigates
+      var preload = window.gon.preloads[prop];
+      delete window.gon.preloads[prop]; //prevent dirty state across navigates
 
-      return(preload)
+      return(preload);
   },
 
   setupDummyPreloads: function() {
@@ -101,8 +101,8 @@ var app = {
       evt.preventDefault();
       var link = $(this);
 
-      $(".stream_title").text(link.text())
-      app.router.navigate(link.attr("href").substring(1) ,true)
+      $(".stream_title").text(link.text());
+      app.router.navigate(link.attr("href").substring(1) ,true);
     });
   },
 
@@ -118,7 +118,7 @@ var app = {
   /* mixpanel wrapper function */
   instrument : function(type, name, object, callback) {
     if(!window.mixpanel) { return }
-    window.mixpanel[type](name, object, callback)
+    window.mixpanel[type](name, object, callback);
   },
 
   setupDisabledLinks: function() {
@@ -132,4 +132,3 @@ $(function() {
   app.initialize();
 });
 // @license-end
-

app/assets/javascripts/app/collections/aspect_memberships.js

@@ -2,5 +2,5 @@
 
 app.collections.AspectMemberships = Backbone.Collection.extend({
   model: app.models.AspectMembership
-})
+});
 // @license-end

app/assets/javascripts/app/collections/aspects.js

@@ -25,6 +25,5 @@ app.collections.Aspects = Backbone.Collection.extend({
     var separator = Diaspora.I18n.t("comma") + ' ';
     return this.selectedAspects('name').join(separator).replace(/,\s([^,]+)$/, ' ' + Diaspora.I18n.t("and") + ' $1') || Diaspora.I18n.t("my_aspects");
   }
-})
+});
 // @license-end
-

app/assets/javascripts/app/collections/comments.js

@@ -16,8 +16,8 @@ app.collections.Comments = Backbone.Collection.extend({
     var deferred = comment.save({}, {
       url: '/posts/'+this.post.id+'/comments',
       success: function() {
-        comment.set({author: app.currentUser.toJSON(), parent: self.post })
-        self.add(comment)
+        comment.set({author: app.currentUser.toJSON(), parent: self.post });
+        self.add(comment);
       }
     });
 
@@ -25,4 +25,3 @@ app.collections.Comments = Backbone.Collection.extend({
   }
 });
 // @license-end
-

app/assets/javascripts/app/collections/likes.js

@@ -4,8 +4,7 @@ app.collections.Likes = Backbone.Collection.extend({
   model: app.models.Like,
 
   initialize : function(models, options) {
-    this.url = "/posts/" + options.post.id + "/likes" //not delegating to post.url() because when it is in a stream collection it delegates to that url
+    this.url = "/posts/" + options.post.id + "/likes"; //not delegating to post.url() because when it is in a stream collection it delegates to that url
   }
 });
 // @license-end
-

app/assets/javascripts/app/collections/photos.js

@@ -4,7 +4,7 @@ app.collections.Photos = Backbone.Collection.extend({
   url : "/photos",
 
   model: function(attrs, options) {
-    var modelClass = app.models.Photo
+    var modelClass = app.models.Photo;
     return new modelClass(attrs, options);
   },
 
@@ -13,4 +13,3 @@ app.collections.Photos = Backbone.Collection.extend({
   }
 });
 // @license-end
-

app/assets/javascripts/app/helpers/date_formatter.js

@@ -14,7 +14,6 @@
 
       return timestamp || 0;
     }
-  }
+  };
 })();
 // @license-end
-

app/assets/javascripts/app/helpers/handlebars-helpers.js

 // @license magnet:?xt=urn:btih:0b31508aeb0634b347b8270c7bee4d411b5d4109&dn=agpl-3.0.txt AGPL-v3-or-Later
 
 Handlebars.registerHelper('t', function(scope, values) {
-  return Diaspora.I18n.t(scope, values.hash)
+  return Diaspora.I18n.t(scope, values.hash);
 });
 
 Handlebars.registerHelper('txtDirClass', function(str) {
@@ -29,7 +29,7 @@ Handlebars.registerHelper('linkToAuthor', function(context, block) {
       html += block.fn(context);
       html += "</a>";
 
-  return html
+  return html;
 });
 
 Handlebars.registerHelper('linkToPerson', function(context, block) {
@@ -38,7 +38,7 @@ Handlebars.registerHelper('linkToPerson', function(context, block) {
       html += block.fn(context);
       html += "</a>";
 
-  return html
+  return html;
 });
 
 // relationship indicator for profile page
@@ -132,4 +132,3 @@ Handlebars.registerHelper('aspectMembershipIndicator', function(contact,in_aspec
   return html;
 });
 // @license-end
-

app/assets/javascripts/app/helpers/handlebars-partials.js

@@ -2,7 +2,6 @@
 
 /* we need to wrap this in a document ready to ensure JST is accessible */
 $(function(){
-  Handlebars.registerPartial('status-message', HandlebarsTemplates['status-message_tpl'])
+  Handlebars.registerPartial('status-message', HandlebarsTemplates['status-message_tpl']);
 });
 // @license-end
-

app/assets/javascripts/app/helpers/o_embed.js

@@ -7,12 +7,11 @@
 
       var data = o_embed_cache.data;
       if (data.type == "photo") {
-        return '<img src="' + data.url + '" width="' + data.width + '" height="' + data.height + '" />'
+        return '<img src="' + data.url + '" width="' + data.width + '" height="' + data.height + '" />';
       } else {
-        return data.html || ""
+        return data.html || "";
       }
     }
-  }
+  };
 })();
 // @license-end
-

app/assets/javascripts/app/models/post.js

@@ -4,17 +4,17 @@ app.models.Post = Backbone.Model.extend(_.extend({}, app.models.formatDateMixin,
   urlRoot : "/posts",
 
   initialize : function() {
-    this.interactions = new app.models.Post.Interactions(_.extend({post : this}, this.get("interactions")))
-    this.delegateToInteractions()
+    this.interactions = new app.models.Post.Interactions(_.extend({post : this}, this.get("interactions")));
+    this.delegateToInteractions();
   },
 
   delegateToInteractions : function(){
-    this.comments = this.interactions.comments
-    this.likes = this.interactions.likes
+    this.comments = this.interactions.comments;
+    this.likes = this.interactions.likes;
 
     this.comment = function(){
-      this.interactions.comment.apply(this.interactions, arguments)
-    }
+      this.interactions.comment.apply(this.interactions, arguments);
+    };
   },
 
   interactedAt : function() {
@@ -26,7 +26,7 @@ app.models.Post = Backbone.Model.extend(_.extend({}, app.models.formatDateMixin,
   },
 
   reshareAuthor : function(){
-    return this.get("author")
+    return this.get("author");
   },
 
   blockAuthor: function() {
@@ -38,7 +38,7 @@ app.models.Post = Backbone.Model.extend(_.extend({}, app.models.formatDateMixin,
   },
 
   toggleFavorite : function(options){
-    this.set({favorite : !this.get("favorite")})
+    this.set({favorite : !this.get("favorite")});
 
     /* guard against attempting to save a model that a user doesn't own */
     if(options.save){ this.save() }
@@ -46,28 +46,28 @@ app.models.Post = Backbone.Model.extend(_.extend({}, app.models.formatDateMixin,
 
   headline : function() {
     var headline = this.get("text").trim()
-      , newlineIdx = headline.indexOf("\n")
-    return (newlineIdx > 0 ) ? headline.substr(0, newlineIdx) : headline
+      , newlineIdx = headline.indexOf("\n");
+    return (newlineIdx > 0 ) ? headline.substr(0, newlineIdx) : headline;
   },
 
   body : function(){
     var body = this.get("text").trim()
-      , newlineIdx = body.indexOf("\n")
-    return (newlineIdx > 0 ) ? body.substr(newlineIdx+1, body.length) : ""
+      , newlineIdx = body.indexOf("\n");
+    return (newlineIdx > 0 ) ? body.substr(newlineIdx+1, body.length) : "";
   },
 
   //returns a promise
   preloadOrFetch : function(){
-    var action = app.hasPreload("post") ? this.set(app.parsePreload("post")) : this.fetch()
-    return $.when(action)
+    var action = app.hasPreload("post") ? this.set(app.parsePreload("post")) : this.fetch();
+    return $.when(action);
   },
 
   hasPhotos : function(){
-    return this.get("photos") && this.get("photos").length > 0
+    return this.get("photos") && this.get("photos").length > 0;
   },
 
   hasText : function(){
-    return $.trim(this.get("text")) !== ""
+    return $.trim(this.get("text")) !== "";
   }
 }));
 // @license-end

app/assets/javascripts/app/models/post/interactions.js

@@ -4,80 +4,80 @@
 
 app.models.Post.Interactions = Backbone.Model.extend({
   url : function(){
-    return this.post.url() + "/interactions"
+    return this.post.url() + "/interactions";
   },
 
   initialize : function(options){
-    this.post = options.post
-    this.comments = new app.collections.Comments(this.get("comments"), {post : this.post})
+    this.post = options.post;
+    this.comments = new app.collections.Comments(this.get("comments"), {post : this.post});
     this.likes = new app.collections.Likes(this.get("likes"), {post : this.post});
     this.reshares = new app.collections.Reshares(this.get("reshares"), {post : this.post});
   },
 
   parse : function(resp){
-    this.comments.reset(resp.comments)
-    this.likes.reset(resp.likes)
-    this.reshares.reset(resp.reshares)
+    this.comments.reset(resp.comments);
+    this.likes.reset(resp.likes);
+    this.reshares.reset(resp.reshares);
 
     var comments = this.comments
       , likes = this.likes
-      , reshares = this.reshares
+      , reshares = this.reshares;
 
     return {
       comments : comments,
       likes : likes,
       reshares : reshares,
       fetched : true
-    }
+    };
   },
 
   likesCount : function(){
-    return (this.get("fetched") ? this.likes.models.length : this.get("likes_count") )
+    return (this.get("fetched") ? this.likes.models.length : this.get("likes_count") );
   },
 
   resharesCount : function(){
-    return this.get("fetched") ? this.reshares.models.length : this.get("reshares_count")
+    return this.get("fetched") ? this.reshares.models.length : this.get("reshares_count");
   },
 
   commentsCount : function(){
-    return this.get("fetched") ? this.comments.models.length : this.get("comments_count")
+    return this.get("fetched") ? this.comments.models.length : this.get("comments_count");
   },
 
   userLike : function(){
-    return this.likes.select(function(like){ return like.get("author").guid == app.currentUser.get("guid")})[0]
+    return this.likes.select(function(like){ return like.get("author").guid == app.currentUser.get("guid")})[0];
   },
 
   userReshare : function(){
     return this.reshares.select(function(reshare){
-      return reshare.get("author") &&  reshare.get("author").guid == app.currentUser.get("guid")})[0]
+      return reshare.get("author") &&  reshare.get("author").guid == app.currentUser.get("guid")})[0];
   },
 
   toggleLike : function() {
     if(this.userLike()) {
-      this.unlike()
+      this.unlike();
     } else {
-      this.like()
+      this.like();
     }
   },
 
   like : function() {
     var self = this;
     this.likes.create({}, {success : function(){
-      self.trigger("change")
-      self.set({"likes_count" : self.get("likes_count") + 1})
-    }})
+      self.trigger("change");
+      self.set({"likes_count" : self.get("likes_count") + 1});
+    }});
 
-    app.instrument("track", "Like")
+    app.instrument("track", "Like");
   },
 
   unlike : function() {
     var self = this;
     this.userLike().destroy({success : function(model, resp) {
-      self.trigger('change')
-      self.set({"likes_count" : self.get("likes_count") - 1})
+      self.trigger('change');
+      self.set({"likes_count" : self.get("likes_count") - 1});
     }});
 
-    app.instrument("track", "Unlike")
+    app.instrument("track", "Unlike");
   },
 
   comment : function (text) {
@@ -90,12 +90,12 @@ app.models.Post.Interactions = Backbone.Model.extend({
         notice: Diaspora.I18n.t("failed_to_post_message")
       });
     }).done(function() {
-      self.trigger('change') //updates after sync
+      self.trigger('change'); //updates after sync
     });
 
-    this.trigger("change") //updates count in an eager manner
+    this.trigger("change"); //updates count in an eager manner
 
-    app.instrument("track", "Comment")
+    app.instrument("track", "Comment");
   },
 
   reshare : function(){
@@ -117,12 +117,12 @@ app.models.Post.Interactions = Backbone.Model.extend({
         });
       }
     }).done(function(){
-        interactions.reshares.add(reshare)
+        interactions.reshares.add(reshare);
       }).done(function(){
-        interactions.trigger("change")
+        interactions.trigger("change");
       });
 
-    app.instrument("track", "Reshare")
+    app.instrument("track", "Reshare");
   },
 
   userCanReshare : function(){
@@ -137,4 +137,3 @@ app.models.Post.Interactions = Backbone.Model.extend({
   }
 });
 // @license-end
-

app/assets/javascripts/app/models/profile.js

@@ -5,19 +5,19 @@ app.models.Profile = Backbone.Model.extend({
 }, {
 
   preloadOrFetch : function(id){
-    return app.hasPreload("person") ? this.preload() : this.findByGuid(id)
+    return app.hasPreload("person") ? this.preload() : this.findByGuid(id);
   },
 
   preload : function(){
-    var person = new app.models.Profile(app.parsePreload("person"))
-    person.deferred = $.when(true)
-    return person
+    var person = new app.models.Profile(app.parsePreload("person"));
+    person.deferred = $.when(true);
+    return person;
   },
 
   findByGuid : function(personId){
-    var person =  new app.models.Profile({ id : personId})
-    person.deferred = person.fetch()
-    return person
+    var person =  new app.models.Profile({ id : personId});
+    person.deferred = person.fetch();
+    return person;
   }
 });
 // @license-end

app/assets/javascripts/app/models/reshare.js

@@ -5,15 +5,15 @@ app.models.Reshare = app.models.Post.extend({
 
   rootPost : function(){
     this._rootPost = this._rootPost || new app.models.Post(this.get("root"));
-    return this._rootPost
+    return this._rootPost;
   },
 
   reshare : function(){
-    return this.rootPost().reshare()
+    return this.rootPost().reshare();
   },
 
   reshareAuthor : function(){
-    return this.rootPost().reshareAuthor()
+    return this.rootPost().reshareAuthor();
   }
 });
 // @license-end

app/assets/javascripts/app/models/status_message.js

@@ -17,7 +17,7 @@ app.models.StatusMessage = app.models.Post.extend({
       photos : this.photos && this.photos.pluck("id"),
       services : this.get("services"),
       poll : this.get("poll")
-    }
+    };
   }
 });
 // @license-end

app/assets/javascripts/app/models/stream.js

@@ -4,7 +4,7 @@
 //= require ../collections/photos
 app.models.Stream = Backbone.Collection.extend({
   initialize : function(models, options){
-    var collectionClass = app.collections.Posts
+    var collectionClass = app.collections.Posts;
     if( options ) {
       options.collection && (collectionClass = options.collection);
       options.basePath && (this.streamPath = options.basePath);
@@ -14,11 +14,11 @@ app.models.Stream = Backbone.Collection.extend({
 
   collectionOptions :function(){
       var order = this.sortOrder();
-      return { comparator : function(item) { return -item[order](); } }
+      return { comparator : function(item) { return -item[order](); } };
   },
 
   url : function(){
-    return _.any(this.items.models) ? this.timeFilteredPath() : this.basePath()
+    return _.any(this.items.models) ? this.timeFilteredPath() : this.basePath();
   },
 
   _fetchOpts: function(opts) {
@@ -57,11 +57,11 @@ app.models.Stream = Backbone.Collection.extend({
 
   maxTime: function(){
     var lastPost = _.last(this.items.models);
-    return lastPost[this.sortOrder()]()
+    return lastPost[this.sortOrder()]();
   },
 
   sortOrder : function() {
-    return this.basePath().match(/activity/) ? "interactedAt" : "createdAt"
+    return this.basePath().match(/activity/) ? "interactedAt" : "createdAt";
   },
 
   /* This function is for adding a large number of posts one by one.
@@ -71,7 +71,7 @@ app.models.Stream = Backbone.Collection.extend({
    * stream for the changes to take effect in the infinite stream view
    */
   add : function(models){
-    this.items.add(models)
+    this.items.add(models);
   },
 
   /* This function is for adding a single post. It immediately triggers
@@ -84,14 +84,13 @@ app.models.Stream = Backbone.Collection.extend({
   },
 
   preloadOrFetch : function(){ //hai, plz test me THNX
-    return $.when(app.hasPreload("stream") ? this.preload() : this.fetch())
+    return $.when(app.hasPreload("stream") ? this.preload() : this.fetch());
   },
 
   preload : function(){
-    this.items.reset(app.parsePreload("stream"))
-    this.deferred = $.when(true)
-    this.trigger("fetched")
+    this.items.reset(app.parsePreload("stream"));
+    this.deferred = $.when(true);
+    this.trigger("fetched");
   }
 });
 // @license-end
-

app/assets/javascripts/app/models/stream_aspects.js

@@ -3,7 +3,7 @@
 app.models.StreamAspects = app.models.Stream.extend({
 
   url : function(){
-    return _.any(this.items.models) ? this.timeFilteredPath() : this.basePath()
+    return _.any(this.items.models) ? this.timeFilteredPath() : this.basePath();
   },
 
   initialize : function(models, options){

app/assets/javascripts/app/models/user.js

@@ -12,11 +12,11 @@ app.models.User = Backbone.Model.extend({
   },
 
   expProfileUrl : function(){
-    return "/people/" + app.currentUser.get("guid") + "?ex=true"
+    return "/people/" + app.currentUser.get("guid") + "?ex=true";
   },
 
   isServiceConfigured : function(providerName) {
-    return _.include(this.get("configured_services"), providerName)
+    return _.include(this.get("configured_services"), providerName);
   },
 
   isAuthorOf: function(model) {

app/assets/javascripts/app/pages/single-post-viewer.js

@@ -11,8 +11,8 @@ app.pages.SinglePostViewer = app.views.Base.extend({
   initialize : function(options) {
     this.model = new app.models.Post({ id : options.id });
     this.model.preloadOrFetch().done(_.bind(this.initViews, this));
-    this.model.interactions.fetch() //async, yo, might want to throttle this later.
-    this.setupLightbox()
+    this.model.interactions.fetch(); //async, yo, might want to throttle this later.
+    this.setupLightbox();
   },
 
   setupLightbox : function(){
@@ -41,4 +41,3 @@ app.pages.SinglePostViewer = app.views.Base.extend({
 
 });
 // @license-end
-

app/assets/javascripts/app/router.js

@@ -113,7 +113,7 @@ app.Router = Backbone.Router.extend({
       var followedTagsAction = new app.views.TagFollowingAction(
             {tagText: decodeURIComponent(name).toLowerCase()}
           );
-      $("#author_info").prepend(followedTagsAction.render().el)
+      $("#author_info").prepend(followedTagsAction.render().el);
       app.tags = new app.views.Tags({tagName: name});
     }
     this._hideInactiveStreamLists();
@@ -151,7 +151,7 @@ app.Router = Backbone.Router.extend({
   },
 
   bookmarklet: function() {
-    var contents = (window.gon) ? gon.preloads.bookmarklet : {}
+    var contents = (window.gon) ? gon.preloads.bookmarklet : {};
     app.bookmarklet = new app.views.Bookmarklet(
       _.extend({}, {el: $('#bookmarklet')}, contents)
     ).render();
@@ -164,4 +164,3 @@ app.Router = Backbone.Router.extend({
   }
 });
 // @license-end
-