Skip to content
Extraits de code Groupes Projets
Valider b94e6ae4 rédigé par danielvincent's avatar danielvincent
Parcourir les fichiers

shift+enter submits new messages/comments

parent 5c1c31b2
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
...@@ -16,7 +16,7 @@ var Stream = { ...@@ -16,7 +16,7 @@ var Stream = {
}); });
$stream.delegate("textarea.comment_box", "keydown", function(e){ $stream.delegate("textarea.comment_box", "keydown", function(e){
if (e.keyCode === 13) { if (e.shiftKey && e.keyCode === 13) {
$(this).closest("form").submit(); $(this).closest("form").submit();
} }
}); });
......
...@@ -35,7 +35,7 @@ var View = { ...@@ -35,7 +35,7 @@ var View = {
/* Submitting the status message form when the user hits enter */ /* Submitting the status message form when the user hits enter */
$(this.publisher.selector) $(this.publisher.selector)
.keyup(this.publisher.keyup); .keydown(this.publisher.keydown);
/* User menu */ /* User menu */
$(this.userMenu.selector) $(this.userMenu.selector)
...@@ -118,8 +118,8 @@ var View = { ...@@ -118,8 +118,8 @@ var View = {
}, },
publisher: { publisher: {
keyup: function(e) { keydown: function(e) {
if(e.keyCode === 13) { if(e.shiftKey && e.keyCode === 13) {
$(this).closest("form").submit(); $(this).closest("form").submit();
} }
}, },
......
...@@ -102,19 +102,20 @@ describe("View", function() { ...@@ -102,19 +102,20 @@ describe("View", function() {
); );
}); });
describe("keyup", function() { describe("keydown", function() {
it("is called when the user types", function() { it("is called when the user types", function() {
spyOn(View.publisher, "keyup"); spyOn(View.publisher, "keydown");
View.initialize(); View.initialize();
$(View.publisher.selector).trigger("keyup"); $(View.publisher.selector).trigger("keydown");
expect(View.publisher.keyup).toHaveBeenCalled(); expect(View.publisher.keydown).toHaveBeenCalled();
}); });
it("submits the form if the user hits enter while the textarea is focused", function() { it("submits the form if the user hits enter while the textarea is focused", function() {
spyOn($.fn, "submit"); spyOn($.fn, "submit");
View.initialize(); View.initialize();
$(View.publisher.selector).focus(); $(View.publisher.selector).focus();
var event = $.Event("keyup"); var event = $.Event("keydown");
var event.ShiftKey = true;
event.keyCode = 13; event.keyCode = 13;
$(View.publisher.selector).trigger(event); $(View.publisher.selector).trigger(event);
expect($.fn.submit).toHaveBeenCalled(); expect($.fn.submit).toHaveBeenCalled();
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter