- août 12, 2017
-
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
Otherwise Rails 5 would ignore the migration version and create the tables with bitints as IDs on MySQL.
-
Dennis Schubert a rédigé
we released that in 0.5.0.0 in 2015, we do not support skipping majors anyway, and this is broken in Rails 5, so let's remove this. If people upgrade from before 0.5.0.0, they have to upgrade via 0.6.0.0, but that's written in the documenation.
-
Dennis Schubert a rédigé
Although this is contrary to rails best-practises, we cannot provide a schema.rb that works for both MySQL and PostgreSQL, so we have no choice. Our migrations are maintained, so it should always be possible to get back to a "clean" database schema anyway.
-
Dennis Schubert a rédigé
-
Dennis Schubert a rédigé
-
Dennis Schubert a rédigé
... this breaks the Rails 5 upgrade, and it's actually no longer needed. New installations will have the right size anyway, and even if some older installations miss the migration by not updating for 2 years, it still doesn't matter since there is no risk that we will ever have emojis in our migration filenames.
-
Benjamin Neff a rédigé
The change in assets.rb should be enough, but it doesn't work, because sprockets `after_initialize` runs before it and initializes sprockets with unfiltered paths. But the trick with the underscore works, because bootstrap-sass has named the file `_bootstrap.scss`, and rails-assets-bootstrap has `bootstrap.scss`, so with `_bootstrap` it uses the correct bootstrap.
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
* load records to array to check them * test that only 15 people are returned
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
* don't use `double` for queries * use `second` instead of `at()`.
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
Or remove it where not needed
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
Validation fails because there is no user set.
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
Return in scope fails with `LocalJumpError: unexpected return`
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
Also remove some unused html responses
-
Benjamin Neff a rédigé
The hashes don't work properly with rails 5, there are different classes loaded when called from the rails engine with missing inheritance. Also the hashes never worked well with spring.
-
Benjamin Neff a rédigé
ActionController::Parameters no longer inherits from HashWithIndifferentAccess
-
Benjamin Neff a rédigé
There were validation errors because `answer.poll` wasn't set.
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
-
Benjamin Neff a rédigé
Needed for `assigns` in controller specs
-