Skip to content
Extraits de code Groupes Projets
DataTableTest.php 27,5 ko
Newer Older
  • Learn to ignore specific revisions
  • sgiehl's avatar
    sgiehl a validé
    <?php
    /**
     * Piwik - Open source web analytics
     *
     * @link http://piwik.org
     * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
     * @version $Id$
     */
    class DataTableTest extends PHPUnit_Framework_TestCase
    {
        /**
         * @group Core
         * @group DataTable
         */
        public function testApplyFilter()
        {
            $table = $this->_getDataTable1ForTest();
            $this->assertEquals(4, $table->getRowsCount());
            $table->filter('Limit', array(2,2));
            $this->assertEquals(2, $table->getRowsCount());
            $table->filter('Piwik_DataTable_Filter_Limit', array(0,1));
            $this->assertEquals(1, $table->getRowsCount());
        }
        
        protected function _getSimpleTestDataTable()
        {
            $table = new Piwik_DataTable;
            $table->addRowsFromArray(
            array(
                array(Piwik_DataTable_Row::COLUMNS => array('label'=>'ten',     'count' => 10)),
                array(Piwik_DataTable_Row::COLUMNS => array('label'=>'ninety',  'count' => 90)),
                array(Piwik_DataTable_Row::COLUMNS => array('label'=>'hundred', 'count' => 100)),
                Piwik_DataTable::ID_SUMMARY_ROW => array( Piwik_DataTable_Row::COLUMNS => array('label'=> 'summary', 'count' => 200))
                )
            );
            return $table;
        }
        
        /**
         * @group Core
         * @group DataTable
         */
        public function testRenameColumn()
        {
            $table = $this->_getSimpleTestDataTable();
            $this->assertEquals(array(10,90,100,200), $table->getColumn('count'));
            $table->renameColumn('count', 'renamed');
            $this->assertEquals(array(false, false, false, false), $table->getColumn('count'));
            $this->assertEquals(array(10,90,100,200), $table->getColumn('renamed'));
        }
    
        /**
         * @group Core
         * @group DataTable
         */
        public function testDeleteColumn()
        {
            $table = $this->_getSimpleTestDataTable();
            $this->assertEquals(array(10,90,100,200), $table->getColumn('count'));
            $table->deleteColumn('count');
            $this->assertEquals(array(false, false, false, false), $table->getColumn('count'));
        }
    
        /**
         * @group Core
         * @group DataTable
         */
        public function testDeleteRow()
        {
            $table = $this->_getSimpleTestDataTable();
            
            // normal row
            $idToDelete = 1;
            $this->assertEquals(2, count($table->getRowFromId($idToDelete)->getColumns()));
            $table->deleteRow($idToDelete);
            $this->assertFalse($table->getRowFromId($idToDelete));
    
            // summary row special case
            $idToDelete = Piwik_DataTable::ID_SUMMARY_ROW;
            $this->assertEquals(2, count($table->getRowFromId($idToDelete)->getColumns()));
            $table->deleteRow($idToDelete);
            $this->assertFalse($table->getRowFromId($idToDelete));
        }
        
        /**
         * @group Core
         * @group DataTable
         */
        public function testGetLastRow()
        {
            $table = $this->_getSimpleTestDataTable();
            $rowsCount = $table->getRowsCount();
    
            $this->assertEquals($table->getLastRow(), $table->getRowFromId(Piwik_DataTable::ID_SUMMARY_ROW));
            $table->deleteRow(Piwik_DataTable::ID_SUMMARY_ROW);
            
            $this->assertEquals($table->getLastRow(), $table->getRowFromId($rowsCount-2));
        }
        
        /**
         * @group Core
         * @group DataTable
         */
        public function testGetRowFromIdSubDataTable()
        {
            $table1 = $this->_getDataTable1ForTest();
            $idTable1 = $table1->getId();
            $table2 = $this->_getDataTable2ForTest();
            $this->assertFalse($table2->getRowFromIdSubDataTable($idTable1));
            
            $table2->getFirstRow()->addSubtable($table1);
            $this->assertEquals($table2->getRowFromIdSubDataTable($idTable1), $table2->getFirstRow());
            
            $table3 = $this->_getDataTable1ForTest();
            $idTable3 = $table3->getId();
            $table2->getLastRow()->addSubtable($table3);
            $this->assertEquals($table2->getRowFromIdSubDataTable($idTable3), $table2->getLastRow());
        }
        
        /**
         * we test the count rows and the count rows recursive version
         * on a Simple array (1 level only)
         * 
         * @group Core
         * @group DataTable
         */
        function testCountRowsSimple()
        {
            
             $table = new Piwik_DataTable;
             $idcol = Piwik_DataTable_Row::COLUMNS;
             $rows = array(
                  array( $idcol => array('label'=>'google')),
                  array( $idcol => array('label'=>'ask')),
                  array( $idcol => array('label'=>'piwik')),
                  array( $idcol => array('label'=>'yahoo')),
                  array( $idcol => array('label'=>'amazon')),
                  array( $idcol => array('label'=>'238975247578949')),
                  array( $idcol => array('label'=>'Q*(%&*("$&%*(&"$*")"))')));
             
             $table->addRowsFromArray( $rows );
             
             $this->assertEquals(count($rows), $table->getRowsCount());
             $this->assertEquals(count($rows), $table->getRowsCountRecursive());
        }
        /**
         * we test the count rows and the count rows recursive version
         * on a Complex array (rows with 2 and 3 levels only)
         * 
         * the recursive count returns 
         *         the sum of the number of rows of all the subtables 
         *         + the number of rows in the parent table
         * 
         * @group Core
         * @group DataTable
         */
        function testCountRowsComplex()
        {
            
            $idcol = Piwik_DataTable_Row::COLUMNS;
            $idsubtable = Piwik_DataTable_Row::DATATABLE_ASSOCIATED;
            
            // table to go in the SUB table of RoW1
            $tableSubOfSubOfRow1 = new Piwik_DataTable;
            $rows1sub = array(
                  array( $idcol => array('label'=>'google')),
                  array( $idcol => array('label'=>'google78')),
                  array( $idcol => array('label'=>'googlaegge')),
                  array( $idcol => array('label'=>'gogeoggle')),
                  array( $idcol => array('label'=>'goaegaegaogle')),
                  array( $idcol => array('label'=>'ask')),
                  array( $idcol => array('label'=>'238975247578949')),
            );
            $tableSubOfSubOfRow1->addRowsFromArray( $rows1sub );
            
            // table to go in row1
            $tableSubOfRow1 = new Piwik_DataTable;
            $rows1 = array(
                  array( $idcol => array('label'=>'google'), $idsubtable =>$tableSubOfSubOfRow1),
                  array( $idcol => array('label'=>'ask')),
                  array( $idcol => array('label'=>'238975247578949')),
            );
            $tableSubOfRow1->addRowsFromArray( $rows1 );
            
            // table to go in row2
            $tableSubOfRow2 = new Piwik_DataTable;
            $rows2 = array(
                  array( $idcol => array('label'=>'google')),
                  array( $idcol => array('label'=>'ask')),
                  array( $idcol => array('label'=>'238975247578949')),
                  array( $idcol => array('label'=>'agaegaesk')),
                  array( $idcol => array('label'=>'23g  8975247578949')),
            );
            $tableSubOfRow2->addRowsFromArray( $rows2 );
            
            // main parent table
            $table = new Piwik_DataTable;
            $rows = array(
                  array( $idcol => array('label'=>'row1')),
                  array( $idcol => array('label'=>'row2'), 
                              $idsubtable => $tableSubOfRow1),
                  array( $idcol => array('label'=>'row3'), 
                              $idsubtable => $tableSubOfRow2),
            );
            $table->addRowsFromArray( $rows );
            
            
            $this->assertEquals(count($rows), $table->getRowsCount());
            $countAllRows =  count($rows)+count($rows1)+count($rows2) + count($rows1sub);
            $this->assertEquals($countAllRows, $table->getRowsCountRecursive());
        }
        
        /**
         * Simple test of the DataTable_Row
         * 
         * @group Core
         * @group DataTable
         */
        function testRow()
        {
            $columns = array('test_column'=> 145,
                            092582495 => new Piwik_Timer,
                            'super'=>array('this column has an array value, amazing'));
            $metadata = array('logo'=> 'piwik.png',
                            'super'=>array('this column has an array value, amazing'));
            $arrayRow = array(
                Piwik_DataTable_Row::COLUMNS => $columns,
                Piwik_DataTable_Row::METADATA => $metadata,
                'fake useless key'=>38959,
                43905724897=>'value');
            $row = new Piwik_DataTable_Row($arrayRow);
            
            $this->assertEquals($columns, $row->getColumns());
            $this->assertEquals($metadata, $row->getMetadata());
            $this->assertNull($row->getIdSubDataTable());
            
        }
        
        /**
         * Simple test of the DataTable_Row
         * 
         * @group Core
         * @group DataTable
         */
        function testSumRow()
        {
            $columns = array('test_int'=> 145,
                            'test_float'=> 145.5,
                            'test_float3'=> 1.5,
                            'test_stringint'=> "145",
                            "test" => 'string fake',
                            'super'=>array('this column has an array string that will be 0 when algorithm sums the value'),
                            'integerArrayToSum'=>array( 1 => 1, 2 => 10.0, 3 => array(1 => 2, 2 => 3)),
                            );
            $metadata = array('logo'=> 'piwik.png',
                            'super'=>array('this column has an array value, amazing'));
            $arrayRow = array(
                Piwik_DataTable_Row::COLUMNS => $columns,
                Piwik_DataTable_Row::METADATA => $metadata,
                'fake useless key'=>38959,
                43905724897=>'value');
            $row1 = new Piwik_DataTable_Row($arrayRow);
            
            $columns2 = array('test_int'=> 5,
                            'test_float'=> 4.5,
                            'test_float2'=> 14.5,
                            'test_stringint'=> "5",
                            0925824 => 'toto',
                            'super'=>array('this column has geagaean array value, amazing'),
                            'integerArrayToSum'=>array( 1 => 5, 2 => 5.5, 3 => array(2 => 4)),
                        );
            $finalRow = new Piwik_DataTable_Row( array(Piwik_DataTable_Row::COLUMNS => $columns2));
            $finalRow->sumRow($row1);
            $columnsWanted = array('test_int'=> 150,
                            'test_float'=> 150.0,
                            'test_float2'=> 14.5,
                            'test_float3'=> 1.5,
                            'test_stringint'=> 150, //add also strings!!
                            'super'=>array(0),
                            'test' => 0,
                            'integerArrayToSum' => array( 1 => 6, 2 => 15.5, 3 => array(1 => 2, 2 => 7)),
                            0925824 => 'toto',
                    );
            $rowWanted = new Piwik_DataTable_Row( array(Piwik_DataTable_Row::COLUMNS => $columnsWanted));
            $this->assertTrue( Piwik_DataTable_Row::isEqual($rowWanted, $finalRow));
        }
        
        /**
         * Test serialize with an infinite recursion (a row linked to a table in the parent hierarchy)
         * After 100 recursion must throw an exception
         * 
         * @group Core
         * @group DataTable
         */
        function testSerializeWithInfiniteRecursion()
        {
    
            try {
                $table = new Piwik_DataTable;
                $table->addRowFromArray(array(Piwik_DataTable_Row::COLUMNS => array( 'visits'=>245,'visitors'=>245),
                                      Piwik_DataTable_Row::DATATABLE_ASSOCIATED => $table,));
    
                $table->getSerialized();
            } catch (Exception $e) {
                return;
            }
            $this->fail('Expected exception not raised');
    
    sgiehl's avatar
    sgiehl a validé
    307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715
        }
        
        
        /**
         * Test queing filters
         * 
         * @group Core
         * @group DataTable
         */
         function testFilterQueueSortString()
         {
            
            $idcol = Piwik_DataTable_Row::COLUMNS;
            
            $table = new Piwik_DataTable;
            $rows = array(
                  array( $idcol => array('label'=>'google')),//0
                  array( $idcol => array('label'=>'tsk')),//1
                  array( $idcol => array('label'=>'Q*(%&*("$&%*(&"$*")"))')),//2
                  );
            $table->addRowsFromArray( $rows );
            
            $expectedtable = new Piwik_DataTable;
            $rows = array(
                  array( $idcol => array('label'=>'google')),//0
                  array( $idcol => array('label'=>'Q*(%&*("$&%*(&"$*")"))')),//2
                  array( $idcol => array('label'=>'tsk')),//1
                  );
            $expectedtable->addRowsFromArray( $rows );
            
            $expectedtableReverse = new Piwik_DataTable;
            $expectedtableReverse->addRowsFromArray(array_reverse($rows));
            
            $tableCopy = clone $table;
            $this->assertTrue(Piwik_DataTable::isEqual($tableCopy, $table));
            
            // queue the filter and check the table didnt change
            $table->queueFilter("Sort", array('label', 'asc'));
            $this->assertTrue(Piwik_DataTable::isEqual($tableCopy, $table));
            
            // apply filter and check the table is sorted
            $table->applyQueuedFilters();
            $this->assertTrue(Piwik_DataTable::isEqual($expectedtable, $table));
            
            // apply one more filter check it hasnt changed
            $table->queueFilter("Sort", array('label', 'desc'));
            $this->assertTrue(Piwik_DataTable::isEqual($expectedtable, $table));
            
            // now apply the second sort and check it is correctly sorted
            $table->applyQueuedFilters();
            $this->assertTrue(Piwik_DataTable::isEqual($expectedtableReverse, $table));
            
            // do one more time to make sure it doesnt change
            $table->applyQueuedFilters();
            $this->assertTrue(Piwik_DataTable::isEqual($expectedtableReverse, $table));
         }
        
        
    
        /**
         * General tests that tries to test the normal behaviour of DataTable
         * 
         * We create some tables, add rows, some of the rows link to sub tables
         * 
         * Then we serialize everything, and we check that the unserialize give the same object back
         * 
         * @group Core
         * @group DataTable
         */
        function testGeneral()
        {
            /*
             * create some fake tables to make sure that the serialized array of the first TABLE
             * does not take in consideration those tables
             */
            $useless1 = new Piwik_DataTable;
            $useless1->addRowFromArray(array(Piwik_DataTable_Row::COLUMNS => array( 13,),));
            /*
             * end fake tables
             */
            
            /*
             * MAIN TABLE
             */
            $table = new Piwik_DataTable;
            $subtable = new Piwik_DataTable;
            $idtable = $table->getId();
            $idsubtable = $subtable->getId();
            
            /*
             * create some fake tables to make sure that the serialized array of the first TABLE
             * does not take in consideration those tables
             * -> we check that the DataTable_Manager is not impacting DataTable 
             */
            $useless2 = new Piwik_DataTable;
            $useless1->addRowFromArray(array(Piwik_DataTable_Row::COLUMNS => array( 8487,),));
            $useless3 = new Piwik_DataTable;
            $useless3->addRowFromArray(array(Piwik_DataTable_Row::COLUMNS => array( 8487,),));
            /*
             * end fake tables
             */
            
            $row = array(Piwik_DataTable_Row::COLUMNS => array( 0 => 1554,    1 => 42,    2 => 657,3 => 155744,),
                          Piwik_DataTable_Row::METADATA => array('logo' => 'test.png'));
            $row = new Piwik_DataTable_Row($row);
            
            $table->addRow($row);
            $table->addRowFromArray(array( Piwik_DataTable_Row::COLUMNS => array( 0 => 1554,1 => 42,),
                                  Piwik_DataTable_Row::METADATA => array('url' => 'piwik.org')));
            
            $table->addRowFromArray(array( Piwik_DataTable_Row::COLUMNS => array( 0 => 787877888787,),
                                  Piwik_DataTable_Row::METADATA => array('url' => 'OUPLA ADDED'),
                                  Piwik_DataTable_Row::DATATABLE_ASSOCIATED => $subtable));
                  
            /*
             * SUB TABLE
             */                
            
            
            $row = array(         Piwik_DataTable_Row::COLUMNS => array( 0 => 1554,),
                                  Piwik_DataTable_Row::METADATA => array('searchengine' => 'google'),
                              );
            $subtable->addRowFromArray($row);
            
            $row = array(         Piwik_DataTable_Row::COLUMNS => array( 0 => 84894,),
                                  Piwik_DataTable_Row::METADATA => array('searchengine' => 'yahoo'),
                              );
            $subtable->addRowFromArray($row);
            $row = array(         Piwik_DataTable_Row::COLUMNS => array( 0 => 4898978989,),
                                  Piwik_DataTable_Row::METADATA => array('searchengine' => 'ask'),
                              );          
            $subtable->addRowFromArray($row);
            
            
            /*
             * SUB SUB TABLE
             */
            $subsubtable = new Piwik_DataTable;
            $subsubtable->addRowFromArray(array(Piwik_DataTable_Row::COLUMNS => array( 245),
                                  Piwik_DataTable_Row::METADATA => array('yes' => 'subsubmetadata1'),)
                                  );      
                                  
            $subsubtable->addRowFromArray(array(Piwik_DataTable_Row::COLUMNS => array( 13,),
                                  Piwik_DataTable_Row::METADATA => array('yes' => 'subsubmetadata2'),)
                                  );
                                  
            $row = array(     Piwik_DataTable_Row::COLUMNS => array( 0 => 666666666666666,),
                                  Piwik_DataTable_Row::METADATA => array('url' => 'NEW ROW ADDED'),
                                  Piwik_DataTable_Row::DATATABLE_ASSOCIATED => $subsubtable);
            
            $subtable->addRowFromArray($row);
            
            $idsubsubtable = $subsubtable->getId();
            
            $serialized = ($table->getSerialized());
            
            $this->assertEquals(array_keys($serialized), array($idsubsubtable,$idsubtable,0));
            $tableAfter = new Piwik_DataTable;
            $tableAfter->addRowsFromSerializedArray($serialized[0]);
            $this->assertEquals($table->getRows(),$tableAfter->getRows());
    
            $subsubtableAfter = new Piwik_DataTable;
            $subsubtableAfter->addRowsFromSerializedArray($serialized[$idsubsubtable]);
            $this->assertEquals($subsubtable->getRows(),$subsubtableAfter->getRows());
            
            $this->assertEquals($table, Piwik_DataTable_Manager::getInstance()->getTable($idtable));
            $this->assertEquals($subsubtable, Piwik_DataTable_Manager::getInstance()->getTable($idsubsubtable));
        }
        
        /**
         * for all datatable->addDatatable tests we check that
         * - row uniqueness is based on the label + presence of the SUBTABLE id
         *         => the label is the criteria used to match 2 rows in 2 datatable
         * - no metadata are lost in the first datatable rows that have been changed
         * - when a subtable
         */
         
         
        /**
         * add an empty datatable to a normal datatable
         * 
         * @group Core
         * @group DataTable
         */
        public function testAddSimpleNoRowTable2()
        {
            $table = $this->_getDataTable1ForTest();
            $tableEmpty = new Piwik_DataTable;
            $tableAfter = clone $table;
            $tableAfter->addDataTable($tableEmpty);
            $this->assertTrue( Piwik_DataTable::isEqual($table, $tableAfter) );
        }
        
        /**
         * add a normal datatable to an empty datatable
         * 
         * @group Core
         * @group DataTable
         */
        public function testAddSimpleNoRowTable1()
        {
            $table = $this->_getDataTable1ForTest();
            $tableEmpty = new Piwik_DataTable;
            $tableEmpty->addDataTable($table);
            $this->assertTrue( Piwik_DataTable::isEqual($tableEmpty, $table) );
        }
    
        /**
         * add to the datatable another datatable// they don't have any row in common
         * 
         * @group Core
         * @group DataTable
         */
        public function testAddSimpleNoCommonRow()
        {
            $table1 = $this->_getDataTable1ForTest();
            $table2 = $this->_getDataTable2ForTest();
            
            $table1->addDataTable($table2);
            
            $rowsExpected = array_merge($this->_getRowsDataTable1ForTest(),$this->_getRowsDataTable2ForTest());
            $tableExpected = new Piwik_DataTable;
            $tableExpected->addRowsFromArray( $rowsExpected );
            
            $this->assertTrue( Piwik_DataTable::isEqual($table1, $tableExpected) );
        }
        
        /**
         * add 2 datatable with some common rows
         * 
         * @group Core
         * @group DataTable
         */
        public function testAddSimpleSomeCommonRow()
        {
            
            $idcol = Piwik_DataTable_Row::COLUMNS;
            
            $rows = array(
                  array( $idcol => array('label'=>'google', 'visits' => 1)),
                  array( $idcol => array('label'=>'ask', 'visits' => 2)),
                  array( $idcol => array('label'=>'123', 'visits' => 2)),
                  Piwik_DataTable::ID_SUMMARY_ROW => array( $idcol => array('label'=>Piwik_DataTable::LABEL_SUMMARY_ROW, 'visits' => 7))
            );          
            $table = new Piwik_DataTable;
            $table->addRowsFromArray( $rows );
            
            $rows2 = array(
                  array( $idcol => array('label'=>'test', 'visits' => 1)),
                  array( $idcol => array('label'=>'ask', 'visits' => 111)),
                  array( $idcol => array('label'=>' google ', 'visits' => 5)),
                  array( $idcol => array('label'=>'123', 'visits' => 2)),
              );          
            $table2 = new Piwik_DataTable;
            $table2->addRowsFromArray( $rows2 );
            
            $table->addDataTable($table2);
            
            $rowsExpected = array(
                  array( $idcol => array('label'=>'google', 'visits' => 1)),
                  array( $idcol => array('label'=>'ask', 'visits' => 113)),
                  array( $idcol => array('label'=>'123', 'visits' => 4)),
                  array( $idcol => array('label'=>'test', 'visits' => 1)),
                  array( $idcol => array('label'=>' google ', 'visits' => 5)),
                  Piwik_DataTable::ID_SUMMARY_ROW => array( $idcol  => array('label'=>Piwik_DataTable::LABEL_SUMMARY_ROW, 'visits' => 7))
            );          
            $tableExpected = new Piwik_DataTable;
            $tableExpected->addRowsFromArray( $rowsExpected );
            
            $this->assertTrue( Piwik_DataTable::isEqual($table, $tableExpected) );
        }
        
        /**
         * add 2 datatable with only common rows
         * 
         * @group Core
         * @group DataTable
         */
        public function testAddSimpleAllCommonRow()
        {
            $idcol = Piwik_DataTable_Row::COLUMNS;
            
            $rows = array(
                  array( $idcol => array('label'=>'google', 'visits' => 1)),
                  array( $idcol => array('label'=>'ask', 'visits' => 2)),
                  array( $idcol => array('label'=>'123', 'visits' => 2)),
                  Piwik_DataTable::ID_SUMMARY_ROW => array( $idcol  => array('label'=>Piwik_DataTable::LABEL_SUMMARY_ROW, 'visits' => 7))
            );          
            $table = new Piwik_DataTable;
            $table->addRowsFromArray( $rows );
            
            $rows2 = array(
                  array( $idcol => array('label'=>'google', 'visits' => -1)),
                  array( $idcol => array('label'=>'ask', 'visits' => 0)),
                  array( $idcol => array('label'=>'123', 'visits' => 1.5)),
                  Piwik_DataTable::ID_SUMMARY_ROW => array( $idcol  => array('label'=>Piwik_DataTable::LABEL_SUMMARY_ROW, 'visits' => 8))
            );          
            $table2 = new Piwik_DataTable;
            $table2->addRowsFromArray( $rows2 );
            
            $table->addDataTable($table2);
            
            $rowsExpected = array(
                  array( $idcol => array('label'=>'google', 'visits' => 0)),
                  array( $idcol => array('label'=>'ask', 'visits' => 2)),
                  array( $idcol => array('label'=>'123', 'visits' => 3.5)),
                  Piwik_DataTable::ID_SUMMARY_ROW => array( $idcol  => array('label'=>Piwik_DataTable::LABEL_SUMMARY_ROW, 'visits' => 15))
            );          
            $tableExpected = new Piwik_DataTable;
            $tableExpected->addRowsFromArray( $rowsExpected );
            
            $this->assertTrue( Piwik_DataTable::isEqual($table, $tableExpected) );
        }
        
        /**
         * test add 2 different tables to the same table
         * 
         * @group Core
         * @group DataTable
         */
        public function testAddDataTable2times()
        {
         
            $idcol = Piwik_DataTable_Row::COLUMNS;
            
            $rows = array(
                  array( $idcol => array('label'=>'google', 'visits' => 1)),
                  array( $idcol => array('label'=>'ask', 'visits' => 0)),
                  array( $idcol => array('label'=>'123', 'visits' => 2)),
                  Piwik_DataTable::ID_SUMMARY_ROW => array( $idcol  => array('label'=>Piwik_DataTable::LABEL_SUMMARY_ROW, 'visits' => 1))
            );          
            $table = new Piwik_DataTable;
            $table->addRowsFromArray( $rows );
            
            $rows2 = array(
                  array( $idcol => array('label'=>'google2', 'visits' => -1)),
                  array( $idcol => array('label'=>'ask', 'visits' => 100)),
                  array( $idcol => array('label'=>'123456', 'visits' => 1.5)),
            );          
            $table2 = new Piwik_DataTable;
            $table2->addRowsFromArray( $rows2 );
            
            $rows3 = array(
                  array( $idcol => array('label'=>'google2', 'visits' => -1)),
                  array( $idcol => array('label'=>'ask', 'visits' => -10)),
                  array( $idcol => array('label'=>'123ab', 'visits' => 1.5)),
                  Piwik_DataTable::ID_SUMMARY_ROW => array( $idcol  => array('label'=>Piwik_DataTable::LABEL_SUMMARY_ROW, 'visits' => 3))
            );          
            $table3 = new Piwik_DataTable;
            $table3->addRowsFromArray( $rows3 );
            
            // add the 2 tables
            $table->addDataTable($table2);
            $table->addDataTable($table3);
            
            $rowsExpected = array(
                  array( $idcol => array('label'=>'google', 'visits' => 1)),
                  array( $idcol => array('label'=>'ask', 'visits' => 90)),
                  array( $idcol => array('label'=>'123', 'visits' => 2)),
                  array( $idcol => array('label'=>'google2', 'visits' => -2)),
                  array( $idcol => array('label'=>'123456', 'visits' => 1.5)),
                  array( $idcol => array('label'=>'123ab', 'visits' => 1.5)),
                  Piwik_DataTable::ID_SUMMARY_ROW => array( $idcol  => array('label'=>Piwik_DataTable::LABEL_SUMMARY_ROW, 'visits' => 4))
            );
            $tableExpected = new Piwik_DataTable;
            $tableExpected->addRowsFromArray( $rowsExpected );
            
            $this->assertTrue( Piwik_DataTable::isEqual($table, $tableExpected) );
        }
        
        protected function _getDataTable1ForTest()
        {
            $rows = $this->_getRowsDataTable1ForTest();
            $table = new Piwik_DataTable;
            $table->addRowsFromArray( $rows );
            return $table;
        }
    
        protected function _getDataTable2ForTest()
        {
            $rows = $this->_getRowsDataTable2ForTest();    
            $table = new Piwik_DataTable;
            $table->addRowsFromArray( $rows );
            return $table;
        }
        
        protected function _getRowsDataTable1ForTest()
        {
            $rows = array(
                  array( Piwik_DataTable_Row::COLUMNS => array('label'=>'google', 'visits' => 1)),
                  array( Piwik_DataTable_Row::COLUMNS => array('label'=>'ask', 'visits' => 2)),
                  array( Piwik_DataTable_Row::COLUMNS => array('label'=>'123', 'visits' => 2)),
                  Piwik_DataTable::ID_SUMMARY_ROW => array( Piwik_DataTable_Row::COLUMNS  => array('label'=>Piwik_DataTable::LABEL_SUMMARY_ROW, 'visits' => 4))
                  
            );
            return $rows;
        }
    
        protected function _getRowsDataTable2ForTest()
        {
            $rows = array(
                  array( Piwik_DataTable_Row::COLUMNS => array('label'=>'test', 'visits' => 1)),
                  array( Piwik_DataTable_Row::COLUMNS => array('label'=>' google ', 'visits' => 3)),
                  array( Piwik_DataTable_Row::COLUMNS => array('label'=>'123a', 'visits' => 2)),
            );
            return $rows;
        }
    
    }