Add maxlength attributes to various input boxes (#10829)

* add maxlength attributes to goal input boxes

values are limited to that length by database restrictions

* limit site name input box to database limit

* limit user input boxes to database limits

plugins/Goals/templates/_formAddGoal.twig

@@ -10,11 +10,13 @@
     <div piwik-form>
         <div piwik-field uicontrol="text" name="goal_name"
              ng-model="manageGoals.goal.name"
+             maxlength="50"
              title="{{ 'Goals_GoalName'|translate|e('html_attr') }}">
         </div>
 
         <div piwik-field uicontrol="text" name="goal_description"
              ng-model="manageGoals.goal.description"
+             maxlength="255"
              title="{{ 'General_Description'|translate|e('html_attr') }}">
         </div>
 
@@ -85,6 +87,7 @@
             <div class="col s12 m6 l4">
                 <div piwik-field uicontrol="text" name="pattern"
                      ng-model="manageGoals.goal.pattern"
+                     maxlength="255"
                      title="{{ 'Goals_Pattern'|translate|e('html_attr') }}"
                      full-width="true">
                 </div>

plugins/SitesManager/templates/sites-list/site-fields.html

@@ -71,7 +71,7 @@
 
         <div class="form-group row">
             <div class="col s12 m6 input-field">
-                <input type="text" ng-model="site.name"/>
+                <input type="text" ng-model="site.name" maxlength="90" />
                 <label>{{ 'General_Name'|translate }}</label>
             </div>
             <div class="col s12 m6"></div>

plugins/UsersManager/angularjs/manage-users/manage-users.controller.js

@@ -144,10 +144,10 @@
             newRowId = 'row' + newRowId;
 
             $($.parseHTML(' <tr id="' + newRowId + '" class="addNewUserRow">\
-				<td><input id="useradd_login" placeholder="username" size="10" /></td>\
+				<td><input id="useradd_login" placeholder="username" size="10" maxlength="100" /></td>\
 				<td><input id="useradd_password" placeholder="password" size="10" /></td>\
-				<td><input id="useradd_email" placeholder="email@domain.com" size="15" /></td>\
-				<td><input id="useradd_alias" placeholder="alias" size="15" /></td>\
+				<td><input id="useradd_email" placeholder="email@domain.com" size="15" maxlength="100" /></td>\
+				<td><input id="useradd_alias" placeholder="alias" size="15" maxlength="45" /></td>\
 				<td>-</td>\
                 <td>-</td>\
 				<td><input type="submit" class="btn adduser"  value="' + _pk_translate('General_Save') + '" /></td>\

plugins/UsersManager/templates/userSettings.twig

@@ -22,12 +22,14 @@
 
         <div piwik-field uicontrol="text" name="alias"
              ng-model="personalSettings.alias"
+             maxlength="45"
              title="{{ 'UsersManager_Alias'|translate|e('html_attr') }}"
              value="{{ userAlias|raw }}">
         </div>
 
         <div piwik-field uicontrol="text" name="email"
              ng-model="personalSettings.email"
+             maxlength="100"
              title="{{ 'UsersManager_Email'|translate|e('html_attr') }}"
              value="{{ userEmail }}">
         </div>