applied some more best practice recommendations for angular that were...

applied some more best practice recommendations for angular that were published a few days ago, see https://docs.google.com/document/d/1XXMvReO8-Awi1EZXAXS4PzDzdNvV6pGcuaF4Q9821Es/pub

plugins/CoreHome/CoreHome.php

@@ -93,24 +93,24 @@ class CoreHome extends \Piwik\Plugin
 
         $jsFiles[] = "plugins/CoreHome/javascripts/piwikAppConfig.js";
 
-        $jsFiles[] = "plugins/CoreHome/javascripts/services/services.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/services/piwik.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/services/piwikApi.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/services/service.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/services/piwik-service.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/services/piwik-api-service.js";
 
-        $jsFiles[] = "plugins/CoreHome/javascripts/filters/filters.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/filters/htmldecode.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/filters/translate.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/filters/filter.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/filters/htmldecode-filter.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/filters/translate-filter.js";
 
-        $jsFiles[] = "plugins/CoreHome/javascripts/directives/directives.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/directives/autocompleteMatched.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/directives/focusAnywhereButHere.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/directives/ignoreClick.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/directives/directive.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/directives/autocomplete-matched-directive.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/directives/focus-anywhere-but-here-directive.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/directives/ignore-click-directive.js";
 
         $jsFiles[] = "plugins/CoreHome/javascripts/piwikApp.js";
 
-        $jsFiles[] = "plugins/CoreHome/javascripts/siteselector/siteSelectorModel.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/siteselector/siteSelectorController.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/siteselector/siteSelectorDirectives.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/siteselector/siteselector-model.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/siteselector/siteselector-controller.js";
+        $jsFiles[] = "plugins/CoreHome/javascripts/siteselector/siteselector-directive.js";
     }
 
     public function getClientSideTranslationKeys(&$translationKeys)

plugins/CoreHome/javascripts/siteselector/tests.js → plugins/CoreHome/javascripts/siteselector/siteselector-controller_test.js

@@ -5,7 +5,7 @@
  * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
  */
 
-describe('SiteSelector Tests', function() {
+describe('SiteSelectorController Tests', function() {
     beforeEach(module(function() {
         return function(inject1, inject2) {
         }

plugins/CoreHome/javascripts/siteselector/siteSelectorDirectives.js → plugins/CoreHome/javascripts/siteselector/siteselector-directive.js

@@ -27,7 +27,7 @@ angular.module('piwikApp').directive('piwikSiteSelector', function($document, pi
             allSitesText: '@',
             allSitesLocation: '@'
         },
-        templateUrl: 'plugins/CoreHome/javascripts/siteselector/siteSelectorPartial.html',
+        templateUrl: 'plugins/CoreHome/javascripts/siteselector/siteselector.html',
         controller: 'SiteSelectorController',
         compile: function (element, attrs) {
             element.addClass('sites_autocomplete');