#6622 Logger refactoring: added tests

core/Log/Formatter/LineMessageFormatter.php

@@ -21,6 +21,9 @@ class LineMessageFormatter extends Formatter
      */
     private $logMessageFormat;
 
+    /**
+     * @param string $logMessageFormat
+     */
     public function __construct($logMessageFormat)
     {
         $this->logMessageFormat = $logMessageFormat;

tests/PHPUnit/Unit/Log/Formatter/LineMessageFormatterTest.php

+<?php
+/**
+ * Piwik - free/libre analytics platform
+ *
+ * @link http://piwik.org
+ * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
+ */
+
+namespace Piwik\Tests\Unit\Log\Formatter;
+
+use DateTime;
+use Piwik\Log\Formatter\LineMessageFormatter;
+
+class LineMessageFormatterTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @test
+     */
+    public function it_should_format_with_placeholders()
+    {
+        $formatter = new LineMessageFormatter('%level% %tag% %datetime% %message%');
+
+        $record = array(
+            'message'    => 'Hello world',
+            'datetime'   => DateTime::createFromFormat('U', 0),
+            'level_name' => 'ERROR',
+            'extra'      => array(
+                'class' => 'Foo'
+            ),
+        );
+
+        $formatted = "ERROR Foo 1970-01-01 00:00:00 Hello world\n";
+
+        $this->assertEquals($formatted, $formatter->format($record));
+    }
+
+    /**
+     * @test
+     */
+    public function it_should_insert_request_id_if_defined()
+    {
+        $formatter = new LineMessageFormatter('%message%');
+
+        $record = array(
+            'message'    => 'Hello world',
+            'datetime'   => DateTime::createFromFormat('U', 0),
+            'level_name' => 'ERROR',
+            'extra'      => array(
+                'request_id' => 'request id'
+            ),
+        );
+
+        $formatted = "[request id] Hello world\n";
+
+        $this->assertEquals($formatted, $formatter->format($record));
+    }
+
+    /**
+     * @test
+     */
+    public function it_should_indent_multiline_message()
+    {
+        $formatter = new LineMessageFormatter('%message%');
+
+        $record = array(
+            'message'    => "Hello world\ntest\ntest",
+            'datetime'   => DateTime::createFromFormat('U', 0),
+            'level_name' => 'ERROR',
+        );
+
+        $formatted = <<<LOG
+Hello world
+  test
+  test
+
+LOG;
+
+        $this->assertEquals($formatted, $formatter->format($record));
+    }
+}

tests/PHPUnit/Unit/Log/Processor/ClassNameProcessorTest.php

@@ -21,7 +21,9 @@ class ClassNameProcessorTest extends \PHPUnit_Framework_TestCase
      */
     public function it_should_append_classname_to_extra()
     {
-        $result = $this->process(array(
+        $processor = new ClassNameProcessor();
+
+        $result = $processor(array(
             'extra' => array(
                 'foo' => 'bar',
             ),
@@ -36,10 +38,4 @@ class ClassNameProcessorTest extends \PHPUnit_Framework_TestCase
 
         $this->assertEquals($expected, $result);
     }
-
-    private function process($record)
-    {
-        $processor = new ClassNameProcessor();
-        return $processor($record);
-    }
 }

tests/PHPUnit/Unit/Log/Processor/RequestIdProcessorTest.php

+<?php
+/**
+ * Piwik - free/libre analytics platform
+ *
+ * @link http://piwik.org
+ * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
+ */
+
+namespace Piwik\Tests\Unit\Log\Processor;
+
+use Piwik\Common;
+use Piwik\Log\Processor\RequestIdProcessor;
+
+/**
+ * @group Core
+ * @covers \Piwik\Log\Processor\RequestIdProcessor
+ */
+class RequestIdProcessorTest extends \PHPUnit_Framework_TestCase
+{
+    public function setUp()
+    {
+        parent::setUp();
+        Common::$isCliMode = false;
+    }
+
+    public function tearDown()
+    {
+        parent::tearDown();
+        Common::$isCliMode = true;
+    }
+
+    /**
+     * @test
+     */
+    public function it_should_append_request_id_to_extra()
+    {
+        $processor = new RequestIdProcessor();
+
+        $result = $processor(array());
+
+        $this->assertArrayHasKey('request_id', $result['extra']);
+        $this->assertInternalType('string', $result['extra']['request_id']);
+        $this->assertNotEmpty($result['extra']['request_id']);
+    }
+
+    /**
+     * @test
+     */
+    public function request_id_should_stay_the_same()
+    {
+        $processor = new RequestIdProcessor();
+
+        $result = $processor(array());
+        $id1 = $result['extra']['request_id'];
+
+        $result = $processor(array());
+        $id2 = $result['extra']['request_id'];
+
+        $this->assertEquals($id1, $id2);
+    }
+}