Skip to content
Extraits de code Groupes Projets
Valider 1c500b1f rédigé par Martin Keckeis's avatar Martin Keckeis
Parcourir les fichiers

fixing lineending

parent 075e0a3f
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
Masquer les modifications d'espaces
En ligne Côte à côte
tests/PHPUnit/Unit/UrlHelperTest.php
+ 261
− 261
Voir le fichier @ 1c500b1f
<?php <?php
/** /**
* Piwik - free/libre analytics platform * Piwik - free/libre analytics platform
* *
* @link http://piwik.org * @link http://piwik.org
* @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*/ */
namespace Piwik\Tests\Unit; namespace Piwik\Tests\Unit;
use Piwik\Tests\Framework\TestCase\SystemTestCase; use Piwik\Tests\Framework\TestCase\SystemTestCase;
use Piwik\UrlHelper; use Piwik\UrlHelper;
use Spyc; use Spyc;
class UrlHelperTest extends \PHPUnit_Framework_TestCase class UrlHelperTest extends \PHPUnit_Framework_TestCase
{ {
/** /**
* Dataprovider for testIsUrl * Dataprovider for testIsUrl
*/ */
public function getUrls() public function getUrls()
{ {
return array( return array(
// valid urls // valid urls
array('http://piwik.org', true), array('http://piwik.org', true),
array('http://www.piwik.org', true), array('http://www.piwik.org', true),
array('https://piwik.org', true), array('https://piwik.org', true),
array('https://piwik.org/dir/dir2/?oeajkgea7aega=&ge=a', true), array('https://piwik.org/dir/dir2/?oeajkgea7aega=&ge=a', true),
array('ftp://www.pi-wik.org', true), array('ftp://www.pi-wik.org', true),
array('news://www.pi-wik.org', true), array('news://www.pi-wik.org', true),
array('https://www.tëteâ.org', true), array('https://www.tëteâ.org', true),
array('http://汉语/漢語.cn', true), //chinese array('http://汉语/漢語.cn', true), //chinese
// valid network-path reference RFC3986 // valid network-path reference RFC3986
array('//piwik.org', true), array('//piwik.org', true),
array('//piwik/hello?world=test&test', true), array('//piwik/hello?world=test&test', true),
array('//piwik.org/hello?world=test&test', true), array('//piwik.org/hello?world=test&test', true),
// invalid urls // invalid urls
array('it doesnt look like url', false), array('it doesnt look like url', false),
array('/index?page=test', false), array('/index?page=test', false),
array('http:/index?page=test', false), array('http:/index?page=test', false),
array('http/index?page=test', false), array('http/index?page=test', false),
array('test.html', false), array('test.html', false),
array('/\/\/\/\/\/\\\http://test.com////', false), array('/\/\/\/\/\/\\\http://test.com////', false),
array('jmleslangues.php', false), array('jmleslangues.php', false),
array('http://', false), array('http://', false),
array(' http://', false), array(' http://', false),
array('testhttp://test.com', false), array('testhttp://test.com', false),
); );
} }
/** /**
* @dataProvider getUrls * @dataProvider getUrls
* @group Core * @group Core
*/ */
public function testIsUrl($url, $isValid) public function testIsUrl($url, $isValid)
{ {
$this->assertEquals($isValid, UrlHelper::isLookLikeUrl($url), "$url failed test"); $this->assertEquals($isValid, UrlHelper::isLookLikeUrl($url), "$url failed test");
} }
/** /**
* Dataprovider for testGetParameterFromQueryString * Dataprovider for testGetParameterFromQueryString
*/ */
public function getQueryStrings() public function getQueryStrings()
{ {
return array( // querystring, parameter, expected value return array( // querystring, parameter, expected value
array('x=1', 'x', '1'), array('x=1', 'x', '1'),
array('?x=1', 'x', '1'), array('?x=1', 'x', '1'),
array('?x=y==1', 'x', 'y==1'), array('?x=y==1', 'x', 'y==1'),
array('x[]=', 'x', array('')), array('x[]=', 'x', array('')),
array('x[]=1', 'x', array('1')), array('x[]=1', 'x', array('1')),
array('x[]=y==1', 'x', array('y==1')), array('x[]=y==1', 'x', array('y==1')),
array('?x[]=1&x[]=2', 'x', array('1', '2')), array('?x[]=1&x[]=2', 'x', array('1', '2')),
array('?x%5b%5d=3&x[]=4', 'x', array('3', '4')), array('?x%5b%5d=3&x[]=4', 'x', array('3', '4')),
array('?x%5B]=5&x[%5D=6', 'x', array('5', '6')), array('?x%5B]=5&x[%5D=6', 'x', array('5', '6')),
array('toto=mama&mama=&tuytyt=teaoi&toto=mama second value', 'tuytyt', 'teaoi'), array('toto=mama&mama=&tuytyt=teaoi&toto=mama second value', 'tuytyt', 'teaoi'),
// don't unescape the value, otherwise it becomes // don't unescape the value, otherwise it becomes
// ?x[]=A&y=1 // ?x[]=A&y=1
array('?x%5B%5D=A%26y%3D1', 'x', array('A%26y%3D1')), array('?x%5B%5D=A%26y%3D1', 'x', array('A%26y%3D1')),
// ?z=y&x[]=1 // ?z=y&x[]=1
array('?z=y%26x%5b%5d%3d1', 'x', null), array('?z=y%26x%5b%5d%3d1', 'x', null),
// strange characters // strange characters
array('toto=mama&mama=&tuytyt=Поиск в Интернете Поиск страниц на русском _*()!$!£$^!£$%&toto=mama second value', 'tuytyt', 'Поиск в Интернете Поиск страниц на русском _*()!$!£$^!£$%'), array('toto=mama&mama=&tuytyt=Поиск в Интернете Поиск страниц на русском _*()!$!£$^!£$%&toto=mama second value', 'tuytyt', 'Поиск в Интернете Поиск страниц на русском _*()!$!£$^!£$%'),
// twice the parameter => returns the last value in the url // twice the parameter => returns the last value in the url
array('toto=mama&mama=&tuytyt=teaoi&toto=mama second value', 'toto', 'mama second value'), array('toto=mama&mama=&tuytyt=teaoi&toto=mama second value', 'toto', 'mama second value'),
// empty param // empty param
array('toto=mama&mama=&tuytyt=teaoi', 'mama', ''), array('toto=mama&mama=&tuytyt=teaoi', 'mama', ''),
// missing parameter value => returns false // missing parameter value => returns false
array('x', 'x', false), array('x', 'x', false),
array('toto=mama&mama&tuytyt=teaoi', 'mama', false), array('toto=mama&mama&tuytyt=teaoi', 'mama', false),
// param not found => null // param not found => null
array('toto=mama&mama=titi', 'tot', null), array('toto=mama&mama=titi', 'tot', null),
// empty query string => null // empty query string => null
array('', 'test', null), array('', 'test', null),
); );
} }
/** /**
* @dataProvider getQueryStrings * @dataProvider getQueryStrings
* @group Core * @group Core
*/ */
public function testGetParameterFromQueryString($queryString, $parameter, $expected) public function testGetParameterFromQueryString($queryString, $parameter, $expected)
{ {
$this->assertSame($expected, UrlHelper::getParameterFromQueryString($queryString, $parameter)); $this->assertSame($expected, UrlHelper::getParameterFromQueryString($queryString, $parameter));
} }
/** /**
* @group Core * @group Core
*/ */
public function testGetPathAndQueryFromUrl() public function testGetPathAndQueryFromUrl()
{ {
$this->assertEquals('test/index.php?module=CoreHome', UrlHelper::getPathAndQueryFromUrl('http://piwik.org/test/index.php?module=CoreHome')); $this->assertEquals('test/index.php?module=CoreHome', UrlHelper::getPathAndQueryFromUrl('http://piwik.org/test/index.php?module=CoreHome'));
} }
/** /**
* @group Core * @group Core
*/ */
public function testGetPathAndQueryFromNonUrl() public function testGetPathAndQueryFromNonUrl()
{ {
$this->assertEquals('Others', UrlHelper::getPathAndQueryFromUrl('Others')); $this->assertEquals('Others', UrlHelper::getPathAndQueryFromUrl('Others'));
} }
/** /**
* @group Core * @group Core
*/ */
public function testGetArrayFromQueryString() public function testGetArrayFromQueryString()
{ {
$expected = array( $expected = array(
'a' => false, 'a' => false,
'b' => '', 'b' => '',
'c' => '1', 'c' => '1',
'd' => array(false), 'd' => array(false),
'e' => array(''), 'e' => array(''),
'f' => array('a'), 'f' => array('a'),
'g' => array('b', 'c'), 'g' => array('b', 'c'),
); );
$this->assertEquals(serialize($expected), serialize(UrlHelper::getArrayFromQueryString('a&b=&c=1&d[]&e[]=&f[]=a&g[]=b&g[]=c'))); $this->assertEquals(serialize($expected), serialize(UrlHelper::getArrayFromQueryString('a&b=&c=1&d[]&e[]=&f[]=a&g[]=b&g[]=c')));
} }
/** /**
* Dataprovider for testExtractSearchEngineInformationFromUrl * Dataprovider for testExtractSearchEngineInformationFromUrl
*/ */
public function getSearchEngineUrls() public function getSearchEngineUrls()
{ {
return Spyc::YAMLLoad(PIWIK_PATH_TEST_TO_ROOT .'/tests/resources/extractSearchEngineInformationFromUrlTests.yml'); return Spyc::YAMLLoad(PIWIK_PATH_TEST_TO_ROOT .'/tests/resources/extractSearchEngineInformationFromUrlTests.yml');
} }
/** /**
* @dataProvider getSearchEngineUrls * @dataProvider getSearchEngineUrls
* @group Core * @group Core
*/ */
public function testExtractSearchEngineInformationFromUrl($url, $engine, $keywords) public function testExtractSearchEngineInformationFromUrl($url, $engine, $keywords)
{ {
$this->includeDataFilesForSearchEngineTest(); $this->includeDataFilesForSearchEngineTest();
$returnedValue = UrlHelper::extractSearchEngineInformationFromUrl($url); $returnedValue = UrlHelper::extractSearchEngineInformationFromUrl($url);
$exptectedValue = false; $exptectedValue = false;
if (!empty($engine)) { if (!empty($engine)) {
$exptectedValue = array('name' => $engine, 'keywords' => $keywords); $exptectedValue = array('name' => $engine, 'keywords' => $keywords);
} }
$this->assertEquals($exptectedValue, $returnedValue); $this->assertEquals($exptectedValue, $returnedValue);
} }
/** /**
* Dataprovider for testGetLossyUrl * Dataprovider for testGetLossyUrl
*/ */
public function getLossyUrls() public function getLossyUrls()
{ {
return array( return array(
array('example.com', 'example.com'), array('example.com', 'example.com'),
array('m.example.com', 'example.com'), array('m.example.com', 'example.com'),
array('www.example.com', 'example.com'), array('www.example.com', 'example.com'),
array('search.example.com', 'example.com'), array('search.example.com', 'example.com'),
array('example.ca', 'example.{}'), array('example.ca', 'example.{}'),
array('us.example.com', '{}.example.com'), array('us.example.com', '{}.example.com'),
array('www.m.example.ca', 'example.{}'), array('www.m.example.ca', 'example.{}'),
array('www.google.com.af', 'google.{}'), array('www.google.com.af', 'google.{}'),
array('www.google.co.uk', 'google.{}'), array('www.google.co.uk', 'google.{}'),
array('images.de.ask.com', 'images.{}.ask.com'), array('images.de.ask.com', 'images.{}.ask.com'),
); );
} }
/** /**
* @dataProvider getLossyUrls * @dataProvider getLossyUrls
* @group Core * @group Core
*/ */
public function testGetLossyUrl($input, $expected) public function testGetLossyUrl($input, $expected)
{ {
$this->assertEquals($expected, UrlHelper::getLossyUrl($input)); $this->assertEquals($expected, UrlHelper::getLossyUrl($input));
} }
private function includeDataFilesForSearchEngineTest() private function includeDataFilesForSearchEngineTest()
{ {
include "DataFiles/SearchEngines.php"; include "DataFiles/SearchEngines.php";
} }
/** /**
* @group Core * @group Core
*/ */
public function test_getHostFromUrl() public function test_getHostFromUrl()
{ {
$this->assertEquals('', UrlHelper::getHostFromUrl('')); $this->assertEquals('', UrlHelper::getHostFromUrl(''));
$this->assertEquals('', UrlHelper::getHostFromUrl(null)); $this->assertEquals('', UrlHelper::getHostFromUrl(null));
$this->assertEquals('localhost', UrlHelper::getHostFromUrl('http://localhost')); $this->assertEquals('localhost', UrlHelper::getHostFromUrl('http://localhost'));
$this->assertEquals('localhost', UrlHelper::getHostFromUrl('http://localhost/path')); $this->assertEquals('localhost', UrlHelper::getHostFromUrl('http://localhost/path'));
$this->assertEquals('localhost', UrlHelper::getHostFromUrl('localhost/path')); $this->assertEquals('localhost', UrlHelper::getHostFromUrl('localhost/path'));
$this->assertEquals('sub.localhost', UrlHelper::getHostFromUrl('sub.localhost/path')); $this->assertEquals('sub.localhost', UrlHelper::getHostFromUrl('sub.localhost/path'));
$this->assertEquals('sub.localhost', UrlHelper::getHostFromUrl('http://sub.localhost/path/?query=test')); $this->assertEquals('sub.localhost', UrlHelper::getHostFromUrl('http://sub.localhost/path/?query=test'));
if(SystemTestCase::isPhpVersion53()) { if(SystemTestCase::isPhpVersion53()) {
//parse_url was fixed in 5,4,7 //parse_url was fixed in 5,4,7
// Fixed host recognition when scheme is omitted and a leading component separator is present. // Fixed host recognition when scheme is omitted and a leading component separator is present.
// http://php.net/parse_url // http://php.net/parse_url
return; return;
} }
$this->assertEquals('localhost', UrlHelper::getHostFromUrl('//localhost/path')); $this->assertEquals('localhost', UrlHelper::getHostFromUrl('//localhost/path'));
$this->assertEquals('localhost', UrlHelper::getHostFromUrl('//localhost/path?test=test2')); $this->assertEquals('localhost', UrlHelper::getHostFromUrl('//localhost/path?test=test2'));
$this->assertEquals('example.org', UrlHelper::getHostFromUrl('//example.org/path')); $this->assertEquals('example.org', UrlHelper::getHostFromUrl('//example.org/path'));
$this->assertEquals('example.org', UrlHelper::getHostFromUrl('//example.org/path?test=test2')); $this->assertEquals('example.org', UrlHelper::getHostFromUrl('//example.org/path?test=test2'));
} }
/** /**
* @group Core * @group Core
*/ */
public function test_getQueryFromUrl_ShouldReturnEmtpyString_IfNoQuery() public function test_getQueryFromUrl_ShouldReturnEmtpyString_IfNoQuery()
{ {
$this->assertEquals('', UrlHelper::getQueryFromUrl('', array())); $this->assertEquals('', UrlHelper::getQueryFromUrl('', array()));
$this->assertEquals('', UrlHelper::getQueryFromUrl(null, array())); $this->assertEquals('', UrlHelper::getQueryFromUrl(null, array()));
$this->assertEquals('', UrlHelper::getQueryFromUrl('http://localhost/path', array())); $this->assertEquals('', UrlHelper::getQueryFromUrl('http://localhost/path', array()));
} }
/** /**
* @group Core * @group Core
*/ */
public function test_getQueryFromUrl_ShouldReturnOnlyTheQueryPartOfTheUrl_IfNoAdditionalParamsGiven() public function test_getQueryFromUrl_ShouldReturnOnlyTheQueryPartOfTheUrl_IfNoAdditionalParamsGiven()
{ {
$this->assertEquals('foo=bar&foo2=bar2&test[]=1', UrlHelper::getQueryFromUrl('http://example.com/?foo=bar&foo2=bar2&test[]=1', array())); $this->assertEquals('foo=bar&foo2=bar2&test[]=1', UrlHelper::getQueryFromUrl('http://example.com/?foo=bar&foo2=bar2&test[]=1', array()));
$this->assertEquals('foo=bar&foo2=bar2&test[]=1', UrlHelper::getQueryFromUrl('/?foo=bar&foo2=bar2&test[]=1', array())); $this->assertEquals('foo=bar&foo2=bar2&test[]=1', UrlHelper::getQueryFromUrl('/?foo=bar&foo2=bar2&test[]=1', array()));
$this->assertEquals('segment=pageTitle!@%40Hello%20World;pageTitle!@Peace%20Love%20', UrlHelper::getQueryFromUrl('/?segment=pageTitle!@%40Hello%20World;pageTitle!@Peace%20Love%20', array())); $this->assertEquals('segment=pageTitle!@%40Hello%20World;pageTitle!@Peace%20Love%20', UrlHelper::getQueryFromUrl('/?segment=pageTitle!@%40Hello%20World;pageTitle!@Peace%20Love%20', array()));
} }
/** /**
* @group Core * @group Core
*/ */
public function test_getQueryFromUrl_ShouldAddAdditionalParams_IfGiven() public function test_getQueryFromUrl_ShouldAddAdditionalParams_IfGiven()
{ {
$this->assertEquals('foo=bar&foo2=bar2&test[]=1&add=foo', UrlHelper::getQueryFromUrl('http://example.com/?foo=bar&foo2=bar2&test[]=1', array('add' => 'foo'))); $this->assertEquals('foo=bar&foo2=bar2&test[]=1&add=foo', UrlHelper::getQueryFromUrl('http://example.com/?foo=bar&foo2=bar2&test[]=1', array('add' => 'foo')));
$this->assertEquals('add=foo', UrlHelper::getQueryFromUrl('/', array('add' => 'foo'))); $this->assertEquals('add=foo', UrlHelper::getQueryFromUrl('/', array('add' => 'foo')));
$this->assertEquals('add[]=foo&add[]=test', UrlHelper::getQueryFromUrl('/', array('add' => array('foo', 'test')))); $this->assertEquals('add[]=foo&add[]=test', UrlHelper::getQueryFromUrl('/', array('add' => array('foo', 'test'))));
} }
} }
\ No newline at end of file
0% ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter