Making class abstract to avoid phpunit warning

http://stackoverflow.com/questions/391390/phpunit-warning-on-an-utilitary-class

plugins/Insights/tests/BaseUnit.php → plugins/Insights/tests/BaseUnitTest.php

@@ -12,11 +12,14 @@ use Piwik\DataTable;
 use Piwik\DataTable\Row;
 
 /**
+ * Abstract class because it avoids it being picked up as a test case
+ * (which would trigger warning because it has no test)
+ *
  * @group Insights
  * @group Unit
  * @group Core
  */
-class BaseUnit extends \PHPUnit_Framework_TestCase
+abstract class BaseUnitTest extends \PHPUnit_Framework_TestCase
 {
     /**
      * @var DataTable

plugins/Insights/tests/FilterAverageTest.php

@@ -18,7 +18,7 @@ use Piwik\Plugins\Insights\DataTable\Filter\Average;
  * @group Unit
  * @group Core
  */
-class FilterAverageTest extends BaseUnit
+class FilterAverageTest extends BaseUnitTest
 {
     public function setUp()
     {

plugins/Insights/tests/FilterExcludeLowValueTest.php

@@ -18,7 +18,7 @@ use Piwik\Plugins\Insights\DataTable\Filter\ExcludeLowValue;
  * @group Unit
  * @group Core
  */
-class FilterExcludeLowValueTest extends BaseUnit
+class FilterExcludeLowValueTest extends BaseUnitTest
 {
     public function setUp()
     {

plugins/Insights/tests/FilterInsightTest.php

@@ -18,7 +18,7 @@ use Piwik\Plugins\Insights\DataTable\Filter\Insight;
  * @group Unit
  * @group Core
  */
-class FilterInsightTest extends BaseUnit
+class FilterInsightTest extends BaseUnitTest
 {
     /**
      * @var DataTable

plugins/Insights/tests/FilterLimitTest.php

@@ -18,7 +18,7 @@ use Piwik\Plugins\Insights\DataTable\Filter\Limit;
  * @group Unit
  * @group Core
  */
-class FilterLimitTest extends BaseUnit
+class FilterLimitTest extends BaseUnitTest
 {
     public function setUp()
     {

plugins/Insights/tests/FilterMinGrowthTest.php

@@ -18,7 +18,7 @@ use Piwik\Plugins\Insights\DataTable\Filter\MinGrowth;
  * @group Unit
  * @group Core
  */
-class FilterMinGrowthTest extends BaseUnit
+class FilterMinGrowthTest extends BaseUnitTest
 {
 
     public function setUp()

plugins/Insights/tests/FilterOrderByTest.php

@@ -18,7 +18,7 @@ use Piwik\Plugins\Insights\DataTable\Filter\OrderBy;
  * @group Unit
  * @group Core
  */
-class FilterOrderByTest extends BaseUnit
+class FilterOrderByTest extends BaseUnitTest
 {
     public function setUp()
     {