Skip to content
Extraits de code Groupes Projets
Valider 2755791a rédigé par diosmosis's avatar diosmosis
Parcourir les fichiers

Fixing some tests and providing better output in system test case failure.

parent 46e81357
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
Masquer les modifications d'espaces
En ligne Côte à côte
Affichage de
avec 32 ajouts et 29 suppressions
plugins/Goals/API.php
+ 5
− 3
Voir le fichier @ 2755791a
......@@ -358,9 +358,11 @@ class API extends \Piwik\Plugin\API
|| empty($columns))
&& $idGoal === GoalManager::IDGOAL_ORDER
) {
$extraProcessedMetrics = $dataTable->getMetadata(DataTable::EXTRA_PROCESSED_METRICS_METADATA_NAME);
$extraProcessedMetrics[] = new AverageOrderRevenue();
$dataTable->setMetadata(DataTable::EXTRA_PROCESSED_METRICS_METADATA_NAME, $extraProcessedMetrics);
$dataTable->filter(function (DataTable $table) {
$extraProcessedMetrics = $table->getMetadata(DataTable::EXTRA_PROCESSED_METRICS_METADATA_NAME);
$extraProcessedMetrics[] = new AverageOrderRevenue();
$table->setMetadata(DataTable::EXTRA_PROCESSED_METRICS_METADATA_NAME, $extraProcessedMetrics);
});
}
return $dataTable;
......
tests/PHPUnit/Framework/TestCase/SystemTestCase.php
+ 2
− 1
Voir le fichier @ 2755791a
......@@ -294,7 +294,8 @@ abstract class SystemTestCase extends PHPUnit_Framework_TestCase
}
try {
Response::assertEquals($expectedResponse, $processedResponse, "Differences with expected in '$processedFilePath'");
$errorMessage = get_class($this) . ": Differences with expected in '$processedFilePath'";
Response::assertEquals($expectedResponse, $processedResponse, $errorMessage);
} catch (Exception $ex) {
$this->comparisonFailures[] = $ex;
}
......
tests/PHPUnit/System/expected/test_ArchiveCronTest_noOptions__VisitsSummary.get_day.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -9,9 +9,9 @@
<bounce_count>9</bounce_count>
<sum_visit_length>0</sum_visit_length>
<max_actions>1</max_actions>
<bounce_rate>100%</bounce_rate>
<nb_actions_per_visit>1</nb_actions_per_visit>
<avg_time_on_site>0</avg_time_on_site>
<bounce_rate>100%</bounce_rate>
</result>
<result idSite="2" />
</results>
\ No newline at end of file
tests/PHPUnit/System/expected/test_ArchiveCronTest_noOptions__VisitsSummary.get_month.xml
+ 3
− 3
Voir le fichier @ 2755791a
......@@ -9,9 +9,9 @@
<bounce_count>25</bounce_count>
<sum_visit_length>305</sum_visit_length>
<max_actions>3</max_actions>
<nb_actions_per_visit>1.1</nb_actions_per_visit>
<bounce_rate>92.59%</bounce_rate>
<nb_actions_per_visit>1.11</nb_actions_per_visit>
<avg_time_on_site>11</avg_time_on_site>
<bounce_rate>93%</bounce_rate>
</result>
<result idSite="2">
<nb_uniq_visitors>1</nb_uniq_visitors>
......@@ -22,8 +22,8 @@
<bounce_count>1</bounce_count>
<sum_visit_length>0</sum_visit_length>
<max_actions>1</max_actions>
<bounce_rate>100%</bounce_rate>
<nb_actions_per_visit>1</nb_actions_per_visit>
<avg_time_on_site>0</avg_time_on_site>
<bounce_rate>100%</bounce_rate>
</result>
</results>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_actions__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>18</bounce_count>
<sum_visit_length>0</sum_visit_length>
<max_actions>1</max_actions>
<bounce_rate>100%</bounce_rate>
<nb_actions_per_visit>1</nb_actions_per_visit>
<avg_time_on_site>0</avg_time_on_site>
<bounce_rate>100%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_browserCode__VisitsSummary.get_range.xml
+ 2
− 2
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>14</bounce_count>
<sum_visit_length>16393</sum_visit_length>
<max_actions>3</max_actions>
<nb_actions_per_visit>1.7</nb_actions_per_visit>
<bounce_rate>51.85%</bounce_rate>
<nb_actions_per_visit>1.74</nb_actions_per_visit>
<avg_time_on_site>607</avg_time_on_site>
<bounce_rate>52%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_browserEngine__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>1</bounce_count>
<sum_visit_length>0</sum_visit_length>
<max_actions>1</max_actions>
<bounce_rate>100%</bounce_rate>
<nb_actions_per_visit>1</nb_actions_per_visit>
<avg_time_on_site>0</avg_time_on_site>
<bounce_rate>100%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_browserVersion__VisitsSummary.get_range.xml
+ 2
− 2
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>14</bounce_count>
<sum_visit_length>16393</sum_visit_length>
<max_actions>3</max_actions>
<nb_actions_per_visit>1.7</nb_actions_per_visit>
<bounce_rate>51.85%</bounce_rate>
<nb_actions_per_visit>1.74</nb_actions_per_visit>
<avg_time_on_site>607</avg_time_on_site>
<bounce_rate>52%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_city__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>5</bounce_count>
<sum_visit_length>6305</sum_visit_length>
<max_actions>3</max_actions>
<bounce_rate>50%</bounce_rate>
<nb_actions_per_visit>1.8</nb_actions_per_visit>
<avg_time_on_site>631</avg_time_on_site>
<bounce_rate>50%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_continentCode__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>10</bounce_count>
<sum_visit_length>12610</sum_visit_length>
<max_actions>3</max_actions>
<bounce_rate>50%</bounce_rate>
<nb_actions_per_visit>1.8</nb_actions_per_visit>
<avg_time_on_site>631</avg_time_on_site>
<bounce_rate>50%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_countryCode__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>5</bounce_count>
<sum_visit_length>6305</sum_visit_length>
<max_actions>3</max_actions>
<bounce_rate>50%</bounce_rate>
<nb_actions_per_visit>1.8</nb_actions_per_visit>
<avg_time_on_site>631</avg_time_on_site>
<bounce_rate>50%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_customVariableName1__VisitsSummary.get_range.xml
+ 2
− 2
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>17</bounce_count>
<sum_visit_length>16393</sum_visit_length>
<max_actions>3</max_actions>
<nb_actions_per_visit>1.7</nb_actions_per_visit>
<bounce_rate>56.67%</bounce_rate>
<nb_actions_per_visit>1.67</nb_actions_per_visit>
<avg_time_on_site>546</avg_time_on_site>
<bounce_rate>57%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_customVariableName5__VisitsSummary.get_range.xml
+ 2
− 2
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>17</bounce_count>
<sum_visit_length>16393</sum_visit_length>
<max_actions>3</max_actions>
<nb_actions_per_visit>1.7</nb_actions_per_visit>
<bounce_rate>56.67%</bounce_rate>
<nb_actions_per_visit>1.67</nb_actions_per_visit>
<avg_time_on_site>546</avg_time_on_site>
<bounce_rate>57%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_customVariablePageName2__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>17</bounce_count>
<sum_visit_length>0</sum_visit_length>
<max_actions>1</max_actions>
<bounce_rate>100%</bounce_rate>
<nb_actions_per_visit>1</nb_actions_per_visit>
<avg_time_on_site>0</avg_time_on_site>
<bounce_rate>100%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_customVariablePageName4__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>0</bounce_count>
<sum_visit_length>0</sum_visit_length>
<max_actions>0</max_actions>
<bounce_rate>0%</bounce_rate>
<nb_actions_per_visit>0</nb_actions_per_visit>
<avg_time_on_site>0</avg_time_on_site>
<bounce_rate>0%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_customVariablePageName5__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>17</bounce_count>
<sum_visit_length>0</sum_visit_length>
<max_actions>1</max_actions>
<bounce_rate>100%</bounce_rate>
<nb_actions_per_visit>1</nb_actions_per_visit>
<avg_time_on_site>0</avg_time_on_site>
<bounce_rate>100%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_customVariablePageValue2__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>4</bounce_count>
<sum_visit_length>0</sum_visit_length>
<max_actions>1</max_actions>
<bounce_rate>100%</bounce_rate>
<nb_actions_per_visit>1</nb_actions_per_visit>
<avg_time_on_site>0</avg_time_on_site>
<bounce_rate>100%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_customVariablePageValue4__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>0</bounce_count>
<sum_visit_length>11349</sum_visit_length>
<max_actions>3</max_actions>
<bounce_rate>0%</bounce_rate>
<nb_actions_per_visit>3</nb_actions_per_visit>
<avg_time_on_site>1261</avg_time_on_site>
<bounce_rate>0%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_customVariablePageValue5__VisitsSummary.get_range.xml
+ 1
− 1
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>4</bounce_count>
<sum_visit_length>0</sum_visit_length>
<max_actions>1</max_actions>
<bounce_rate>100%</bounce_rate>
<nb_actions_per_visit>1</nb_actions_per_visit>
<avg_time_on_site>0</avg_time_on_site>
<bounce_rate>100%</bounce_rate>
</result>
\ No newline at end of file
tests/PHPUnit/System/expected/test_AutoSuggestAPITest_customVariableValue1__VisitsSummary.get_range.xml
+ 2
− 2
Voir le fichier @ 2755791a
......@@ -6,7 +6,7 @@
<bounce_count>4</bounce_count>
<sum_visit_length>3783</sum_visit_length>
<max_actions>2</max_actions>
<nb_actions_per_visit>1.4</nb_actions_per_visit>
<bounce_rate>57.14%</bounce_rate>
<nb_actions_per_visit>1.43</nb_actions_per_visit>
<avg_time_on_site>540</avg_time_on_site>
<bounce_rate>57%</bounce_rate>
</result>
\ No newline at end of file
0% ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter