Follow up of previous api change + cleanup NOTICEs in tests

git-svn-id: http://dev.piwik.org/svn/trunk@6974 59fd770c-687e-43c8-a1e3-f5a4ff64c105

core/Access.php

@@ -394,10 +394,7 @@ class Piwik_Access
 			$idSites = $this->getSitesIdWithAtLeastViewAccess();
 		}
 		
-		if(!is_array($idSites))
-		{
-			$idSites = Piwik_Site::getIdSitesFromIdSitesString($idSites);
-		}
+		$idSites = Piwik_Site::getIdSitesFromIdSitesString($idSites);
 		if(empty($idSites))
 		{
 			throw new Piwik_Access_NoAccessException("The parameter 'idSite=' is missing from the request.");

core/RankingQuery.php

@@ -85,7 +85,7 @@ class Piwik_RankingQuery
 	 * The constructor.
 	 * Can be used as a shortcut for setLimit() 
 	 */
-	public function __construct($limit=false)
+	public function __construct($limit = false)
 	{
 		if ($limit !== false)
 		{

core/Tracker/Visit.php

@@ -746,7 +746,7 @@ class Piwik_Tracker_Visit implements Piwik_Tracker_Visit_Interface
 			$toRecord = Piwik_Common::getRequestVar($parameterForceRecord, false, 'int', $this->request);
 			if(!$toRecord)
 			{
-				printDebug($_SERVER['REQUEST_METHOD'].' parameter '.$parameterForceRecord.' not found in URL, request excluded');
+				printDebug(@$_SERVER['REQUEST_METHOD'].' parameter '.$parameterForceRecord.' not found in URL, request excluded');
 				$excluded = true;
 				printDebug("'$parameterForceRecord' parameter not found.");
 			}

plugins/Goals/API.php

@@ -55,11 +55,8 @@ class Piwik_Goals_API
 	{
 		//TODO calls to this function could be cached as static
 		// would help UI at least, since some UI requests would call this 2-3 times..
-		if(!is_array($idSite))
-		{
-			$idSite = Piwik_Site::getIdSitesFromIdSitesString($idSite);
-		}
-		if(empty($idSite)) 
+		$idSite = Piwik_Site::getIdSitesFromIdSitesString($idSite);
+		if(empty($idSite))
 		{
 			return array();
 		}

plugins/UsersManager/API.php

@@ -539,7 +539,7 @@ class Piwik_UsersManager_API
 			$idSites = Piwik_SitesManager_API::getInstance()->getSitesIdWithAdminAccess();
 		}
 		// in case the idSites is an integer we build an array		
-		elseif(!is_array($idSites))
+		else
 		{
 			$idSites = Piwik_Site::getIdSitesFromIdSitesString($idSites);
 		}

tests/PHPUnit/FakeAccess.php

@@ -62,10 +62,7 @@ class FakeAccess
             $websitesAccess=Piwik_SitesManager_API::getInstance()->getAllSitesId();
         }
         
-        if(!is_array($idSites))
-        {
-            $idSites = Piwik_Site::getIdSitesFromIdSitesString($idSites);
-        }
+        $idSites = Piwik_Site::getIdSitesFromIdSitesString($idSites);
         foreach($idSites as $idsite)
         {
             if(!in_array($idsite, $websitesAccess))

tests/core/Database.test.php

@@ -121,10 +121,7 @@ class FakeAccess
 			$websitesAccess=Piwik_SitesManager_API::getInstance()->getAllSitesId();
 		}
 		
-		if(!is_array($idSites))
-		{
-			$idSites = Piwik_Site::getIdSitesFromIdSitesString($idSites);
-		}
+		$idSites = Piwik_Site::getIdSitesFromIdSitesString($idSites);
 		foreach($idSites as $idsite)
 		{
 			if(!in_array($idsite, $websitesAccess))