refs #3813 another data table improvement: refactor data table header to a separate template

 * removes code duplication (we already had a minor inconsistent bug fix - shame on us!)
 * show the sorted column and report documentation after using the search box

@Stefan: the issues I reported are fixed now

@Everyone: this is turning into a general data table improvement ticket

plugins/CoreHome/templates/datatable.tpl

@@ -16,24 +16,9 @@
             {else}
                 <a name="{$properties.uniqueId}"></a>
                 <table cellspacing="0" class="dataTable">
-                    <thead>
-                    <tr>
-                        {foreach from=$dataTableColumns item=column name=head}
-                            <th class="sortable {if $smarty.foreach.head.first}first{elseif $smarty.foreach.head.last}last{/if}" id="{$column}">
-                                {if !empty($columnDocumentation[$column])}
-                                    <div class="columnDocumentation">
-                                        <div class="columnDocumentationTitle">
-                                            {$columnTranslations[$column]|escape:'html'|replace:"&amp;nbsp;":"&nbsp;"}
-                                        </div>
-                                        {$columnDocumentation[$column]|escape:'html'}
-                                    </div>
-                                {/if}
-                                <div id="thDIV">{$columnTranslations[$column]|escape:'html'|replace:"&amp;nbsp;":"&nbsp;"}</div>
-                            </th>
-                        {/foreach}
-                    </tr>
-                    </thead>
-
+                    
+                    {include file="CoreHome/templates/datatable_head.tpl"}
+                    
                     <tbody>
                     {foreach from=$arrayDataTable item=row}
                         <tr {if $row.idsubdatatable && $javascriptVariablesToSet.controllerActionCalledWhenRequestSubTable != null}class="subDataTable"

plugins/CoreHome/templates/datatable_actions.tpl

@@ -11,23 +11,8 @@
                 <div class="pk-emptyDataTable">{'CoreHome_ThereIsNoDataForThisReport'|translate}</div>
             {else}
                 <table cellspacing="0" class="dataTable dataTableActions">
-                    <thead>
-                    <tr>
-                        {foreach from=$dataTableColumns item=column name=head}
-                            <th class="sortable {if $smarty.foreach.head.first}first{elseif $smarty.foreach.head.last}last{/if}" id="{$column}">
-                                {if !empty($columnDocumentation[$column])}
-                                    <div class="columnDocumentation">
-                                        <div class="columnDocumentationTitle">
-                                            {$columnTranslations[$column]|escape:'html'|replace:"&amp;nbsp;":"&nbsp;"}
-                                        </div>
-                                        {$columnDocumentation[$column]|escape:'html'}
-                                    </div>
-                                {/if}
-                                <div id="thDIV">{$columnTranslations[$column]|escape:'html'}</div>
-                            </th>
-                        {/foreach}
-                    </tr>
-                    </thead>
+                    
+                    {include file="CoreHome/templates/datatable_head.tpl"}
 
                     <tbody>
                     {foreach from=$arrayDataTable item=row}

plugins/CoreHome/templates/datatable_actions_recursive.tpl

@@ -7,14 +7,9 @@
                 <div class="pk-emptyDataTable">{'CoreHome_ThereIsNoDataForThisReport'|translate}</div>
             {else}
                 <table cellspacing="0" class="dataTable dataTableActions">
-                    <thead>
-                    <tr>
-                        {foreach from=$dataTableColumns item=column}
-                            <th class="sortable" id="{$column}">{$columnTranslations[$column]|escape:'html'}</th>
-                        {/foreach}
-                    </tr>
-                    </thead>
-
+                    
+                    {include file="CoreHome/templates/datatable_head.tpl"}
+                    
                     <tbody>
                     {foreach from=$arrayDataTable item=row}
                         <tr {if $row.idsubdatatable}class="level{$row.level} rowToProcess subActionsDataTable" id="{$row.idsubdatatable}"

plugins/CoreHome/templates/datatable_head.tpl

+<thead>
+   <tr>
+       {foreach from=$dataTableColumns item=column name=head}
+           <th class="sortable {if $smarty.foreach.head.first}first{elseif $smarty.foreach.head.last}last{/if}" id="{$column}">
+               {if !empty($columnDocumentation[$column])}
+                   <div class="columnDocumentation">
+                       <div class="columnDocumentationTitle">
+                           {$columnTranslations[$column]|escape:'html'|replace:"&amp;nbsp;":"&nbsp;"}
+                       </div>
+                       {$columnDocumentation[$column]|escape:'html'}
+                   </div>
+               {/if}
+               <div id="thDIV">{$columnTranslations[$column]|escape:'html'|replace:"&amp;nbsp;":"&nbsp;"}</div>
+           </th>
+       {/foreach}
+   </tr>
+</thead>
\ No newline at end of file