Merge pull request #298 from czolnowski/password-validator

Password validation extension

plugins/UsersManager/API.php

@@ -409,6 +409,7 @@ class API extends \Piwik\Plugin\API
         Piwik::checkUserHasSuperUserAccessOrIsTheUser($userLogin);
         $this->checkUserIsNotAnonymous($userLogin);
         $userInfo = $this->getUser($userLogin);
+        $passwordHasBeenUpdated = false;
 
         if (empty($password)) {
             $password = $userInfo['password'];
@@ -418,6 +419,8 @@ class API extends \Piwik\Plugin\API
                 UsersManager::checkPassword($password);
                 $password = UsersManager::getPasswordHash($password);
             }
+
+            $passwordHasBeenUpdated = true;
         }
 
         if (empty($alias)) {
@@ -441,10 +444,12 @@ class API extends \Piwik\Plugin\API
 
         /**
          * Triggered after an existing user has been updated.
+         * Event notify about password change.
          * 
          * @param string $userLogin The user's login handle.
+         * @param boolean $passwordHasBeenUpdated Flag containing information about password change.
          */
-        Piwik::postEvent('UsersManager.updateUser.end', array($userLogin));
+        Piwik::postEvent('UsersManager.updateUser.end', array($userLogin, $passwordHasBeenUpdated));
     }
 
     /**

plugins/UsersManager/UsersManager.php

@@ -111,9 +111,27 @@ class UsersManager extends \Piwik\Plugin
 
     public static function checkPassword($password)
     {
+        /**
+         * Triggered before core password validator check password.
+         *
+         * This event exists for enable option to create custom password validation rules.
+         * It can be used to validate password (length, used chars etc) and to notify about checking password.
+         *
+         * **Example**
+         *
+         *     Piwik::addAction('UsersManager.checkPassword', function ($password) {
+         *         if (strlen($password) < 10) {
+         *             throw new Exception('Password is too short.');
+         *         }
+         *     });
+         *
+         * @param string $password Checking password in plain text.
+         */
+        Piwik::postEvent('UsersManager.checkPassword', array($password));
+
         if (!self::isValidPasswordString($password)) {
             throw new Exception(Piwik::translate('UsersManager_ExceptionInvalidPassword', array(self::PASSWORD_MIN_LENGTH,
-                                                                                                        self::PASSWORD_MAX_LENGTH)));
+                self::PASSWORD_MAX_LENGTH)));
         }
     }