apply feedback from code review, always show same length for passwords

plugins/Diagnostics/ConfigReader.php

@@ -60,7 +60,7 @@ class ConfigReader
 
                 $newValue = $value;
                 if ($this->isKeyAPassword($key)) {
-                    $newValue = $this->maskPassword($value);
+                    $newValue = $this->getMaskedPassword();
                 }
 
                 $defaultValue = null;
@@ -107,9 +107,9 @@ class ConfigReader
         return $this->settings->getIniFileChain()->getFrom($this->settings->getPathLocal(), $name);
     }
 
-    private function maskPassword($password)
+    private function getMaskedPassword()
     {
-        return str_pad('', strlen($password), '*');
+        return '******';
     }
 
     private function isKeyAPassword($key)
@@ -169,7 +169,7 @@ class ConfigReader
 
                         if ($setting->uiControlType === PluginSettings::CONTROL_PASSWORD) {
                             $value = $configValues[$pluginName][$name]['value'];
-                            $configValues[$pluginName][$name]['value'] = $this->maskPassword($value);
+                            $configValues[$pluginName][$name]['value'] = $this->getMaskedPassword();
                         }
                     } else {
                         $defaultValue = $setting->getValue();

plugins/Diagnostics/Test/Integration/ConfigReaderTest.php

@@ -121,7 +121,7 @@ with multiple lines',
                 array (
                     'password' =>
                         array (
-                            'value' => '****',
+                            'value' => '******',
                             'description' => '',
                             'isCustomValue' => true,
                             'defaultValue' => NULL,
@@ -249,7 +249,7 @@ Another line',
 
         $configValues = $this->configReader->addConfigValuesFromPluginSettings($existing, array($settings));
 
-        $this->assertSame('****', $configValues['ExampleSettingsPlugin']['metric']['value']);
+        $this->assertSame('******', $configValues['ExampleSettingsPlugin']['metric']['value']);
     }
 
     private function configPath($file)

plugins/Diagnostics/lang/en.json

 {
     "Diagnostics": {
         "ConfigFileTitle": "Config file",
-        "ConfigFileIntroduction": "Here you can view the Piwik configuration. If you are running Piwik in a load balanced environment the page might be different depending from which server this page is loaded. Rows with a different background color are changed config values that are specified for example in the %s file.",
-        "HideUnchanged": "If you want to see only changed values you can %shide all unchanged values%s.",
+        "ConfigFileIntroduction": "Here you can view the Piwik configuration. If you are running Piwik in a load balanced environment the page might be different depending from which server this page is loaded. Rows with a different background color are changed config values that are specified for example in the %1$s file.",
+        "HideUnchanged": "If you want to see only changed values you can %1$shide all unchanged values%2$s.",
         "Sections": "Sections"
     }
 }
\ No newline at end of file

plugins/Diagnostics/plugin.json

 {
-    "description": "Performs diagnostics to check that Piwik is installed and runs correctly.",
-    "require": {
-        "piwik": ">=2.16.0-b2"
-    }
+    "description": "Performs diagnostics to check that Piwik is installed and runs correctly."
 }
\ No newline at end of file