Fix '% Visit' datatable column header bug by using |raw and make sure goal...

Fix '% Visit' datatable column header bug by using |raw and make sure goal names are escaped in HtmlTable::setShowGoalsColumnsProperties.

core/Metrics.php

@@ -292,7 +292,7 @@ class Metrics
 
     public static function getPercentVisitColumn()
     {
-        $percentVisitsLabel = str_replace(' ', html_entity_decode(' '), Piwik_Translate('General_ColumnPercentageVisits'));
+        $percentVisitsLabel = str_replace(' ', ' ', Piwik_Translate('General_ColumnPercentageVisits'));
         return $percentVisitsLabel;
     }
 }
\ No newline at end of file

plugins/CoreHome/templates/_dataTableHead.twig

@@ -10,7 +10,7 @@
                        {{ properties.metrics_documentation[column] }}
                    </div>
                {% endif %}
-               <div id="thDIV">{{ properties.translations[column]|default(column) }}</div>
+               <div id="thDIV">{{ properties.translations[column]|default(column)|raw }}</div>
            </th>
        {% endfor %}
    </tr>

plugins/CoreVisualizations/Visualizations/HtmlTable.php

@@ -376,6 +376,7 @@ class HtmlTable extends DataTableVisualization
         // get all goals to display info for
         $allGoals = array();
 
+        // add the ecommerce goal if ecommerce is enabled for the site
         if (Site::isEcommerceEnabledFor($idSite)) {
             $ecommerceGoal = array(
                 'idgoal' => Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER,
@@ -385,8 +386,11 @@ class HtmlTable extends DataTableVisualization
             $allGoals[$ecommerceGoal['idgoal']] = $ecommerceGoal;
         }
 
+        // add the site's goals (and escape all goal names)
         $siteGoals = Goals_API::getInstance()->getGoals($idSite);
         foreach ($siteGoals as &$goal) {
+            $goal['name'] = Common::sanitizeInputValue($goal['name']);
+
             $goal['quoted_name'] = '"' . $goal['name'] . '"';
             $allGoals[$goal['idgoal']] = $goal;
         }