Skip to content
Extraits de code Groupes Projets
Valider 448fe337 rédigé par mattab's avatar mattab
Parcourir les fichiers

Adding comment to clarify logic refs...

parent b0487d39
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
...@@ -245,6 +245,19 @@ class Archiver extends \Piwik\Plugin\Archiver ...@@ -245,6 +245,19 @@ class Archiver extends \Piwik\Plugin\Archiver
} }
} }
/**
* Delete Visit, Unique Visitor and Users metric from 'page' scope custom variables.
*
* - Custom variables of 'visit' scope: it is expected that these ones have the "visit" column set.
* - Custom variables of 'page' scope: we cannot process "Visits" count for these.
* Why?
* "Actions" column is processed with a SELECT count(*).
* A same visit can set the same custom variable of 'page' scope multiple times.
* We cannot sum the values of count(*) as it would be incorrect.
* The way we could process "Visits" Metric for 'page' scope variable is to issue a count(Distinct *) or so,
* but it is no implemented yet (this would likely be very slow for high traffic sites).
*
*/
protected function removeVisitsMetricsFromActionsAggregate() protected function removeVisitsMetricsFromActionsAggregate()
{ {
$dataArray = & $this->dataArray->getDataArray(); $dataArray = & $this->dataArray->getDataArray();
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter