Improved old icons (#11190)

* these images are png with a wrong file extention

* converted all remaining (non animated) GIFs to PNG

* replaced .gif with .png

* jpg to png | deleted plugins/Live/images/visitor_profile_background.jpg

* changed jpg in templates

* replaced favicon.ico with real multisize ico

plugins/CoreHome/Visitor.php

@@ -32,9 +32,9 @@ class Visitor
         $status = $this->getVisitEcommerceStatus();
 
         if (in_array($status, array('ordered', 'orderedThenAbandonedCart'))) {
-            return "plugins/Morpheus/images/ecommerceOrder.gif";
+            return "plugins/Morpheus/images/ecommerceOrder.png";
         } elseif ($status == 'abandonedCart') {
-            return "plugins/Morpheus/images/ecommerceAbandonedCart.gif";
+            return "plugins/Morpheus/images/ecommerceAbandonedCart.png";
         }
         // Note: it is important that there is no icon when there was no ecommerce conversion
         return null;
@@ -83,7 +83,7 @@ class Visitor
         if ($type == 'returning'
             || $type == 'returningCustomer'
         ) {
-            return "plugins/Live/images/returningVisitor.gif";
+            return "plugins/Live/images/returningVisitor.png";
         }
         return null;
     }

plugins/CoreHome/templates/_dataTableCell.twig

@@ -7,7 +7,7 @@
        href='{% if row.getMetadata('url')|slice(0,4) not in ['http','ftp:'] %}http://{% endif %}{{ row.getMetadata('url')|rawSafeDecoded }}'>
     {% if not row.getMetadata('logo') %}
         <img class="link" width="10" height="9"
-             src="plugins/Morpheus/images/link.gif"/>
+             src="plugins/Morpheus/images/link.png"/>
     {% endif %}
 {% endif %}
 

plugins/CoreHome/templates/_donate.twig

@@ -33,7 +33,7 @@
         </div>
 
         <div class="donate-submit">
-            <input type="image" src="plugins/Morpheus/images/paypal_subscribe.gif" border="0" name="submit"
+            <input type="image" src="plugins/Morpheus/images/paypal_subscribe.png" border="0" name="submit"
                 title="{{ 'CoreHome_SubscribeAndBecomePiwikSupporter'|translate }}"/>
 			<a class="donate-spacer">{{ 'CoreHome_MakeOneTimeDonation'|translate }}</a>
             <a href="index.php?module=CoreHome&action=redirectToPaypal&idSite=1&cmd=_s-xclick&hosted_button_id=RPL23NJURMTFA&bb2_screener_=1357583494+83.233.186.82"

plugins/CorePluginsAdmin/templates/macros.twig

@@ -158,7 +158,7 @@
                                         <p>{{ 'CorePluginsAdmin_ConsiderDonatingCreatorOf'|translate("<b>" ~ name ~ "</b>")|raw }}</p>
                                         <div class="donation-links">
                                             {% if plugin.info.donate.paypal is defined and plugin.info.donate.paypal %}
-                                                <a class="donation-link paypal" target="_blank" href="https://www.paypal.com/cgi-bin/webscr?cmd=_donations&item_name=Piwik%20Plugin%20{{ name|escape('url') }}&bn=PP%2dDonationsBF%3abtn_donateCC_LG%2egif%3aNonHosted&business={{ plugin.info.donate.paypal|escape('url') }}"><img src="plugins/CorePluginsAdmin/images/paypal_donate.jpg" height="30"/></a>
+                                                <a class="donation-link paypal" target="_blank" href="https://www.paypal.com/cgi-bin/webscr?cmd=_donations&item_name=Piwik%20Plugin%20{{ name|escape('url') }}&bn=PP%2dDonationsBF%3abtn_donateCC_LG%2egif%3aNonHosted&business={{ plugin.info.donate.paypal|escape('url') }}"><img src="plugins/CorePluginsAdmin/images/paypal_donate.png" height="30"/></a>
                                             {% endif %}
                                             {% if plugin.info.donate.flattr is defined and plugin.info.donate.flattr %}
                                                 <a class="donation-link flattr" target="_blank" href="{{ plugin.info.donate.flattr }}"><img class="alignnone" title="Flattr" alt="" src="plugins/CorePluginsAdmin/images/flattr.png" height="29" /></a>

plugins/DevicesDetection/functions.php

@@ -17,11 +17,11 @@ use DeviceDetector\Parser\Client\Browser AS BrowserParser;
 function getBrandLogo($label)
 {
     $label = preg_replace("/[^a-z0-9_-]+/i", "_", $label);
-    $path = dirname(__FILE__) . '/images/brand/' . $label . '.ico';
+    $path = dirname(__FILE__) . '/images/brand/' . $label . '.png';
     if (file_exists($path)) {
-        return 'plugins/DevicesDetection/images/brand/' . $label . '.ico';
+        return 'plugins/DevicesDetection/images/brand/' . $label . '.png';
     } else {
-        return 'plugins/DevicesDetection/images/brand/Unknown.ico';
+        return 'plugins/DevicesDetection/images/brand/Unknown.png';
     }
 }
 
@@ -160,17 +160,17 @@ function getDeviceTypeLogo($label)
     $label = strtolower($label);
 
     $deviceTypeLogos = Array(
-        "desktop"       => "normal.gif",
+        "desktop"       => "normal.png",
         "smartphone"    => "smartphone.png",
         "tablet"        => "tablet.png",
         "tv"            => "tv.png",
-        "feature phone" => "mobile.gif",
-        "console"       => "console.gif",
+        "feature phone" => "mobile.png",
+        "console"       => "console.png",
         "car browser"   => "carbrowser.png",
         "camera"        => "camera.png");
 
     if (!array_key_exists($label, $deviceTypeLogos)) {
-        $label = 'unknown.gif';
+        $label = 'unknown.png';
     } else {
         $label = $deviceTypeLogos[$label];
     }