Skip to content
Extraits de code Groupes Projets
Valider 5cf69a0b rédigé par Thomas Steur's avatar Thomas Steur Validation de Thomas Steur
Parcourir les fichiers

wondering if this fixes the skipped test?

parent a040cb98
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
......@@ -165,7 +165,7 @@ require_once PIWIK_INCLUDE_PATH . '/core/Common.php';
*
* @api
*/
class DataTable implements DataTableInterface, \IteratorAggregate
class DataTable implements DataTableInterface, \IteratorAggregate, \ArrayAccess
{
const MAX_DEPTH_DEFAULT = 15;
......@@ -1640,4 +1640,26 @@ class DataTable implements DataTableInterface, \IteratorAggregate
public function getIterator() {
return new \ArrayIterator($this->getRows());
}
public function offsetExists($offset)
{
$row = $this->getRowFromId($offset);
return false !== $row;
}
public function offsetGet($offset)
{
return $this->getRowFromId($offset);
}
public function offsetSet($offset, $value)
{
$this->rows[$offset] = $value;
}
public function offsetUnset($offset)
{
$this->deleteRow($offset);
}
}
\ No newline at end of file
......@@ -100,7 +100,7 @@ class ColumnDelete extends BaseFilter
// remove columns specified in $this->columnsToRemove
if (!empty($this->columnsToRemove)) {
foreach ($table as &$row) {
foreach ($table as $index => $row) {
foreach ($this->columnsToRemove as $column) {
if ($this->deleteIfZeroOnly) {
$value = $row[$column];
......@@ -109,7 +109,7 @@ class ColumnDelete extends BaseFilter
}
}
unset($row[$column]);
unset($table[$index][$column]);
}
}
......@@ -118,7 +118,7 @@ class ColumnDelete extends BaseFilter
// remove columns not specified in $columnsToKeep
if (!empty($this->columnsToKeep)) {
foreach ($table as &$row) {
foreach ($table as $index => $row) {
foreach ($row as $name => $value) {
$keep = false;
......@@ -133,7 +133,7 @@ class ColumnDelete extends BaseFilter
&& $name != 'label' // label cannot be removed via whitelisting
&& !isset($this->columnsToKeep[$name])
) {
unset($row[$name]);
unset($table[$index][$name]);
}
}
}
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter